<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sun, Oct 18, 2015 at 12:08 PM, Sandro Santilli <span dir="ltr"><<a href="mailto:strk@keybit.net" target="_blank">strk@keybit.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">How does that diagram counts contributors ?<br>
<br>
With SVN it's very unlikely that a bot can recognize contributors<br>
other than the committers, while with GIT it's easier to make the<br>
actual contributor visible to a machine (being there an "author"<br>
field in addition to the "committer" field).<br></blockquote><div><br></div><div>Indeed, it counts the committers, and it's true that it can be skewed,</div><div>but I assure you the overall effect is negligible.</div><div><br></div><div>Before pull requests we used to add a "patch by xyz" in the commit</div><div>message to give credit to the actual author. I looked at the year right</div><div>before the github switch, there are 4 commits like that in total (I searched</div><div>for just "by" to make sure not to skip stuff written with slight differences).</div><div><br></div><div>If I look at the last year and ask for a contributor count I get:</div><div><br></div><div>> git shortlog -nsu --since "one year ago" | wc -l<br></div><div>84</div><div><br></div><div>Github tells me there are 34 developers with direct commit access, but I checked</div><div>who made a commit in the last year. we are down to only 24 people.</div><div>Sometimes devs commit from another computer and</div><div>they don't have their mail setup, which makes for a two lines in that statistic, </div><div>one with the username, one with the mail</div><div>e.g. in that list we have for example Mauro listed twice (and so is mine):</div><div><div> 27 Mauro Bartolomeoli</div><div> 24 mbarto<br><br></div></div><div>So that reduces the number of actual unique contributorsq a bit, let's say down to 75-80...</div><div>it's still 50 random people contributing to GeoServer without commit access</div><div>in the last year, or, in other words, 10 times more external contributions</div><div>compared to before the switch to Github.</div><div><br></div><div>The thing is, we still have patches in the bug tracker that are a few years</div><div>old, and they will likely never be merged: when they came in they probably</div><div>were either dirty, or core devs were too busy, and after a few months</div><div>applying them becomes rather challenging, so there they stay: the merge barrier</div><div>was too high, too domanding on the core devs.</div><div><br></div><div>With the current pull request mechanism we have a much improved ability</div><div>to handle contributions, in part because people are reminded of the</div><div>contribution rules the moment they make the pull request, in part because</div><div>the build servers inform the submitter about a problem in the pull request rather quickly,</div><div>but also because we can comment in a more social way about the pull</div><div>request (before reviewing the patch was a one man job), and also because they </div><div>are always nicely grouped and in front of our eyes at every PSC meeting</div><div>(we check the pull request queue like that every two weeks, to see</div><div>if there is anything that merits special attention).</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
I'm not trying to negate the possible benefits in terms of number<br>
of contributors, but I'd be careful about the correctess of available<br>
data.<br>
<span class=""><br>
> There is another benefit of moving to Github, which is build checks on pull<br>
> requests,<br>
<br>
</span>Yes, this is something we unfortunately lost on OSGeo.<br>
We used to have buildbot running to that extent, but lack of volunteers<br>
made that experience come to an end.<br></blockquote><div><br></div><div>Mind, here I'm talking about a special integration, not the normal</div><div>continuous build for commits that are integrated, but a custom build for the</div><div>pull request, which tells you whether or not merging that pull request</div><div>will break the build (to clarify, by build I mean both compiling and running</div><div>all automated tests save for OGC CITE compliance ones).</div><div><br></div><div>The pull request build status, along with an indication if the patch is mergeable, and possibly an indication</div><div>of whether the test coverage went up or down, is a huge time saver.</div><div>If a review of the patch is satisfying, the build give us the green, we can literally</div><div>just press the merge button, thank the contributor, and move on with our work/live,</div><div>instead of spending time trying to apply while the code moved, build, go back and forth</div><div>with the committer in a rather inefficient way (and manually run build/tests every damn time), and so on.</div><div><br></div><div>Cheers</div><div>Andrea</div><div><br></div></div><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><div><div>==</div><div>GeoServer Professional Services from the experts! Visit</div><div><a href="http://goo.gl/it488V" target="_blank">http://goo.gl/it488V</a> for more information.</div><div><span style="font-size:12.8px">==</span><br></div></div><div><br></div></div><div>Ing. Andrea Aime <br></div><div>@geowolf</div><div>Technical Lead</div><div><br></div><div>GeoSolutions S.A.S.</div><div>Via Poggio alle Viti 1187</div><div>55054 Massarosa (LU)</div><div>Italy</div><div>phone: +39 0584 962313</div><div>fax: +39 0584 1660272</div><div>mob: +39 339 8844549</div><div><br></div><div><a href="http://www.geo-solutions.it" target="_blank">http://www.geo-solutions.it</a></div><div><a href="http://twitter.com/geosolutions_it" target="_blank">http://twitter.com/geosolutions_it</a></div><div><br></div><div><p><span lang="IT"><font size="1"><b>AVVERTENZE AI SENSI DEL D.Lgs. 196/2003</b></font></span></p><p><span lang="IT"><font size="1">Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.</font></span></p><p><span lang="IT"><font size="1"> </font></span></p><p><font size="1">The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.</font></p></div><div><br></div><div>-------------------------------------------------------</div></div></div></div></div></div></div></div></div>
</div></div>