From jumpinjackie at gmail.com Tue May 15 04:42:38 2012 From: jumpinjackie at gmail.com (Jackie Ng) Date: Tue May 15 04:43:21 2012 Subject: [fdo-internals] Patch for #829 Message-ID: <1337071358988-4974665.post@n6.nabble.com> Hi All, I've attached a patch for ticket #829 ("Internal error" is meaningless in most contexts where it is thrown) The patch replaces a whole swath of instances in the GenericRdbms core where "internal error" is thrown with a more suitable messages from the existing FDO RDBMS message catalog. Please review. - Jackie -- View this message in context: http://osgeo-org.1560.n6.nabble.com/Patch-for-829-tp4974665.html Sent from the FDO Internals mailing list archive at Nabble.com. From Romica.Dascalescu at autodesk.com Tue May 15 19:12:22 2012 From: Romica.Dascalescu at autodesk.com (Romica Dascalescu) Date: Tue May 15 19:15:47 2012 Subject: [fdo-internals] Patch for #829 In-Reply-To: <1337071358988-4974665.post@n6.nabble.com> References: <1337071358988-4974665.post@n6.nabble.com> Message-ID: <6EFA1BAA06C40C4A9CB058A6130A9185AB1A95@005-TK5MPN1-002.MGDADSK.autodesk.com> Hi Jackie, I had a look and the change is OK, you can drop it in the trunk. Thanks, Romy ________________________________________ From: fdo-internals-bounces@lists.osgeo.org [fdo-internals-bounces@lists.osgeo.org] on behalf of Jackie Ng [jumpinjackie@gmail.com] Sent: Tuesday, May 15, 2012 4:42 AM To: fdo-internals@lists.osgeo.org Subject: [fdo-internals] Patch for #829 Hi All, I've attached a patch for ticket #829 ("Internal error" is meaningless in most contexts where it is thrown) The patch replaces a whole swath of instances in the GenericRdbms core where "internal error" is thrown with a more suitable messages from the existing FDO RDBMS message catalog. Please review. - Jackie -- View this message in context: http://osgeo-org.1560.n6.nabble.com/Patch-for-829-tp4974665.html Sent from the FDO Internals mailing list archive at Nabble.com. _______________________________________________ fdo-internals mailing list fdo-internals@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/fdo-internals From jumpinjackie at gmail.com Fri May 25 16:57:59 2012 From: jumpinjackie at gmail.com (Jackie Ng) Date: Fri May 25 16:58:03 2012 Subject: [fdo-internals] Patch for ticket 831 (Visual C++ 2010 Express 64-bit build support) Message-ID: <1337979479187-4977062.post@n6.nabble.com> Hi All, Attached is a patch to allow compilation with Visual C++ 2010 Express 64-bit. http://trac.osgeo.org/fdo/ticket/831 My one question about this patch is the necessity of enabling browse information in certain project files. This patch disables this setting wherever it is enabled because neither Visual C++ 2010 Express or the Windows 7.1 SDK include the required 64-bit version of bscmake.exe that's needed to process browse information. Basically, is enabling browse information necessary? Please review. Thanks - Jackie -- View this message in context: http://osgeo-org.1560.n6.nabble.com/Patch-for-ticket-831-Visual-C-2010-Express-64-bit-build-support-tp4977062.html Sent from the FDO Internals mailing list archive at Nabble.com. From greg.boone at autodesk.com Fri May 25 23:49:12 2012 From: greg.boone at autodesk.com (Greg Boone) Date: Fri May 25 23:53:15 2012 Subject: [fdo-internals] Patch for ticket 831 (Visual C++ 2010 Express 64-bit build support) In-Reply-To: <1337979479187-4977062.post@n6.nabble.com> References: <1337979479187-4977062.post@n6.nabble.com> Message-ID: The patch looks ok. Looking at the diff, it seems that most projects have the generate browse info flag turned off anyways. You list only a small subset where you needed to make modifications. So, I am OK with the change. Greg -----Original Message----- From: fdo-internals-bounces@lists.osgeo.org [mailto:fdo-internals-bounces@lists.osgeo.org] On Behalf Of Jackie Ng Sent: Friday, May 25, 2012 4:58 PM To: fdo-internals@lists.osgeo.org Subject: [fdo-internals] Patch for ticket 831 (Visual C++ 2010 Express 64-bit build support) Hi All, Attached is a patch to allow compilation with Visual C++ 2010 Express 64-bit. http://trac.osgeo.org/fdo/ticket/831 My one question about this patch is the necessity of enabling browse information in certain project files. This patch disables this setting wherever it is enabled because neither Visual C++ 2010 Express or the Windows 7.1 SDK include the required 64-bit version of bscmake.exe that's needed to process browse information. Basically, is enabling browse information necessary? Please review. Thanks - Jackie -- View this message in context: http://osgeo-org.1560.n6.nabble.com/Patch-for-ticket-831-Visual-C-2010-Express-64-bit-build-support-tp4977062.html Sent from the FDO Internals mailing list archive at Nabble.com. _______________________________________________ fdo-internals mailing list fdo-internals@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/fdo-internals