Trevor,<div><br></div><div>I skimmed the patch. I'm slightly uptight about the concept of instantiating a warper for each tile. In the "gdal/frmts/vrtwarped.cc" code I believe I created the warper once for the whole virtual result and then just invoked poWarper->WarpRegionToBuffer() on a per tile basis but this does mean a fair amount of extra work. Did you examine the approach of just using VRTWarpedDataset? I think that was the approach I used in QGIS at one time in history for warped rasters.</div>
<div><br></div><div>One other nit, the following line is unlikely to work well on some systems:</div><div><br></div><div><div>snprintf(buf, 255, "MEM:::DATAPOINTER=0x%p,PIXELS=%d,LINES=%d,BANDS=4,DATATYPE=Byte,PIXELOFFSET=4,LINEOFFSET=%d,BANDOFFSET=1", resampledBytes, resampledXSize, resampledYSize, resampledXSize*4); </div>
<div><br></div><div>I found for maximum portability I had to do special stuff which is now captured in the CPLPrintPointer() function. You might want to consider using it. </div><div><br></div><div>Best regards,</div><div>
Frank</div><br><div class="gmail_quote">On Fri, Oct 12, 2012 at 1:14 PM, Trevor Wekel <span dir="ltr"><<a href="mailto:trevor_wekel@otxsystems.com" target="_blank">trevor_wekel@otxsystems.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-CA" link="blue" vlink="purple">
<div>
<p class="MsoNormal">Hello list,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I would like to present “RFC 65 - Implement Resampling for GDAL Provider” for review and comment. I would like to add this functionality to the future FDO 3.8 release. The submitted code patch also works with FDO 3.7... (unofficially...)<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><a href="http://trac.osgeo.org/fdo/wiki/FDORfc65" target="_blank">http://trac.osgeo.org/fdo/wiki/FDORfc65</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Regards,<u></u><u></u></p>
<p class="MsoNormal">Trevor<u></u><u></u></p>
</div>
</div>
<br>_______________________________________________<br>
fdo-internals mailing list<br>
<a href="mailto:fdo-internals@lists.osgeo.org">fdo-internals@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/fdo-internals" target="_blank">http://lists.osgeo.org/mailman/listinfo/fdo-internals</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>---------------------------------------+--------------------------------------<br>I set the clouds in motion - turn up | Frank Warmerdam, <a href="mailto:warmerdam@pobox.com" target="_blank">warmerdam@pobox.com</a><br>
light and sound - activate the windows | <a href="http://pobox.com/~warmerdam" target="_blank">http://pobox.com/~warmerdam</a><br>and watch the world go round - Rush | Geospatial Software Developer<br><br>
</div>