<br>Guys, <div><br></div><div>Looks good to me. </div><div><br></div><div>Best regards,</div><div>Frank</div><div><br><div class="gmail_quote">On Tue, Oct 23, 2012 at 2:51 PM, Greg Boone <span dir="ltr"><<a href="mailto:greg.boone@autodesk.com" target="_blank">greg.boone@autodesk.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I think the RFC is ok, the final say on the code review is Frank.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Greg<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> <a href="mailto:fdo-internals-bounces@lists.osgeo.org" target="_blank">fdo-internals-bounces@lists.osgeo.org</a> [mailto:<a href="mailto:fdo-internals-bounces@lists.osgeo.org" target="_blank">fdo-internals-bounces@lists.osgeo.org</a>]
<b>On Behalf Of </b>Trevor Wekel<br>
<b>Sent:</b> Sunday, October 21, 2012 10:56 PM</span></p><div><div class="h5"><br>
<b>To:</b> FDO Internals Mail List<br>
<b>Subject:</b> Re: [fdo-internals] RFC 65 Implement Resampling for GDAL Provider<u></u><u></u></div></div><p></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Frank,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I have attached an updated patch to RFC 65 with the CPLPrintPointer modification and compile fixes [Makefile.am updates] for Linux. The code compiles
and the FDO unit tests are clean on VC10 32bit Windows, VC10 64bit Windows, and 32bit CentOS 5.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I was also able to verify the functionality visually in MapGuide on all three platforms. No code changes are required for MapGuide. Just add
the following parameter to the feature source XML document:<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-CA" style="font-family:"Courier New";color:darkmagenta"><Parameter><u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-CA" style="font-family:"Courier New";color:darkmagenta"> <Name></span><span lang="EN-CA" style="font-family:"Courier New"">ResamplingMethod</span><span lang="EN-CA" style="font-family:"Courier New";color:darkmagenta"></Name><u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-CA" style="font-family:"Courier New";color:darkmagenta"> <Value></span><span lang="EN-CA" style="font-family:"Courier New"">bilinear</span><span lang="EN-CA" style="font-family:"Courier New";color:darkmagenta"></Value><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-family:"Courier New";color:darkmagenta"></Parameter></span><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">If everyone is ok with the RFC “as is”, can we get it approved? I can check the code in the next day or so.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Regards,<br>
Trevor<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">
<a href="mailto:fdo-internals-bounces@lists.osgeo.org" target="_blank">fdo-internals-bounces@lists.osgeo.org</a>
<a href="mailto:[mailto:fdo-internals-bounces@lists.osgeo.org]" target="_blank">[mailto:fdo-internals-bounces@lists.osgeo.org]</a>
<b>On Behalf Of </b>Frank Warmerdam<br>
<b>Sent:</b> October 12, 2012 5:30 PM<br>
<b>To:</b> FDO Internals Mail List<br>
<b>Subject:</b> Re: [fdo-internals] RFC 65 Implement Resampling for GDAL Provider<u></u><u></u></span></p>
</div>
<p class="MsoNormal"><span lang="EN-CA"><u></u> <u></u></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span lang="EN-CA"><u></u> <u></u></span></p>
<div>
<p class="MsoNormal"><span lang="EN-CA">On Fri, Oct 12, 2012 at 3:20 PM, Trevor Wekel <<a href="mailto:trevor_wekel@otxsystems.com" target="_blank">trevor_wekel@otxsystems.com</a>> wrote:<u></u><u></u></span></p>
<div>
<div>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Frank,</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I was not aware of VRTWarpedDataset so did not consider it initially.</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">So I took a quick look at vrtwarped.cpp. I have a question. In vrtwarped.cpp, the
ProcessBlock() seems to cache the results of the warp operation (GDALCopyWords around line 1174) into each raster band. Does this mean that all blocks will end up being cached?</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA"><u></u> <u></u></span></p>
</div>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA">Trevor,<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA">Yes, VRTWarpedDataset will always push produced tiles into the GDAL block cache. Note that most drivers go through the block cache too.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA"> <u></u><u></u></span></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">For FDO, we basically call a ReadNext() to suck the contents of the tile into a buffer
supplied by the caller. The ReadNext() drives the calls to _getTile(). As far as I can tell, our access pattern is linear and we only access each tile once. If we switch to using VRTWarpedDataset, will we have to call ProcessBlock() for each tile? Will
this end up caching all the blocks as we do the linear read?</span><span lang="EN-CA"><u></u><u></u></span></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><span lang="EN-CA"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA"> In a web context, the ideal would be a long lived server which keeps around the VRTWarpedDataset for subsequent use. I not sure how practical that is in the FDO/MapGuide use case. In this situation caching the blocks
can help subsequent views but there might be better other layers at which to do that.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA"><u></u> <u></u></span></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">As an alternative to using VRTWarpedDataset, would it be ok to instantiate a GDALWarpOperation
as a member of the FdoRfpStreamReaderByTileResample? Pseudo code would be something like this:</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:9.5pt;font-family:Consolas">FdoRfpStreamReaderGdalByTileResample::FdoRfpStreamReaderGdalByTileResample()</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:9.5pt;font-family:Consolas">{</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:9.5pt;font-family:Consolas">m_warpOp = new GDALWarpOperation();</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:9.5pt;font-family:Consolas">}</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none">
<span lang="EN-CA" style="font-size:9.5pt;font-family:Consolas">FdoRfpStreamReaderGdalByTileResample::_getTile()</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">{</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none">
<span lang="EN-CA" style="font-size:9.5pt;font-family:Consolas">warpOptions = GDALCreateWarpOptions();</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none">
<span lang="EN-CA" style="font-size:9.5pt;font-family:Consolas">// populate warp options</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none">
<span lang="EN-CA" style="font-size:9.5pt;font-family:Consolas">m_warpOp->Initialize(warpOptions);</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none">
<span lang="EN-CA" style="font-size:9.5pt;font-family:Consolas">m_warpOp->WarpRegion(0,0,origXSize,origYSize);</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal" style="text-autospace:none">
<span lang="EN-CA" style="font-size:9.5pt;font-family:Consolas">}</span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span><span lang="EN-CA"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">This may improve the speed of the _getTile() call if a) Initialize() can be called more
than once and b) the new GDALWarpOperation() does a lot of setup work</span><span lang="EN-CA"><u></u><u></u></span></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><span lang="EN-CA"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA">It is more likely to be the Iniitalize() that is expensive and reinitialzing an existing WarpOperation is not a well trod path and likely to lead to pain. I advise against it. In retrospect, sticking with your existing
approach is likely ok but you might want to get a sense of how much time is spent in the setup code vs. the actual warping. Larger tiles will help.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA">Best regards,<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA"> <u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span lang="EN-CA">-- <br>
---------------------------------------+--------------------------------------<br>
I set the clouds in motion - turn up | Frank Warmerdam, <a href="mailto:warmerdam@pobox.com" target="_blank">
warmerdam@pobox.com</a><br>
light and sound - activate the windows | <a href="http://pobox.com/~warmerdam" target="_blank">
http://pobox.com/~warmerdam</a><br>
and watch the world go round - Rush | Geospatial Software Developer<u></u><u></u></span></p>
</div></div></div>
</div>
<br>_______________________________________________<br>
fdo-internals mailing list<br>
<a href="mailto:fdo-internals@lists.osgeo.org">fdo-internals@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/fdo-internals" target="_blank">http://lists.osgeo.org/mailman/listinfo/fdo-internals</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>---------------------------------------+--------------------------------------<br>I set the clouds in motion - turn up | Frank Warmerdam, <a href="mailto:warmerdam@pobox.com" target="_blank">warmerdam@pobox.com</a><br>
light and sound - activate the windows | <a href="http://pobox.com/~warmerdam" target="_blank">http://pobox.com/~warmerdam</a><br>and watch the world go round - Rush | Geospatial Software Developer<br><br>
</div>