<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Looks good.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Greg<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> fdo-internals [mailto:fdo-internals-bounces@lists.osgeo.org]
<b>On Behalf Of </b>Karsten Winter<br>
<b>Sent:</b> Monday, January 18, 2016 11:30 AM<br>
<b>To:</b> FDO Internals Mail List <fdo-internals@lists.osgeo.org><br>
<b>Subject:</b> [fdo-internals] Patch for FDOCommonFile.cpp issue<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi all<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">During my investigations for problems of failing SHP unit tests I found an issue which came up after the use of VS 2015.<o:p></o:p></p>
<p class="MsoNormal">Several SHP unit tests are failing now, because CPG file will not be deleted during the clean-up.<o:p></o:p></p>
<p class="MsoNormal">So I was debugging it down to the method GetAllFiles (Utilities\Common\Src\FdoCommonFile.cpp).<o:p></o:p></p>
<p class="MsoNormal">This method returns all files, except with size 0. I guess this is to exclude subfolders/parentfolder, which is working correct.<o:p></o:p></p>
<p class="MsoNormal">But the CPG files also have a size of 0 KB. It must be different in previous versions, because the unit tests were running successfully.<o:p></o:p></p>
<p class="MsoNormal">So the files will not be returned and therefore not instantiated for cleanup.<o:p></o:p></p>
<p class="MsoNormal">I would to fix it with the attached patch, that only subdirs will not be included in the list of files. But all other files , even with size 0. I guess it makes more sense and would match the name of the method.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">As this is not critical and impacts only the unit tests, I would wait with the submission after the branch, so that we have more time for testing.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="DE-CH">Best regards<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="DE-CH">Karsten<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><b><span lang="DE-CH" style="font-family:"Arial",sans-serif"><o:p> </o:p></span></b></p>
<p class="MsoNormal" style="margin-left:1.45pt"><b><span lang="DE-CH" style="font-family:"Arial",sans-serif">Karsten Winter<o:p></o:p></span></b></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span lang="DE-CH" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383">Software - Engineer<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383">Solution Engineering, IPG- ICP
<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383">Autodesk S.a.r.l.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span lang="DE-CH" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383">Worbstrasse 223<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span lang="DE-CH" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383">3073 Gümligen<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span lang="DE-CH" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383">Switzerland<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span lang="DE-CH" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span lang="DE-CH" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383">Central +41 (0)31 9582020<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span lang="DE-CH" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383">Fax +41 (0)31 9582022<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:1.45pt"><span lang="DE-CH" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="DE-CH" style="font-size:8.0pt;font-family:"Arial",sans-serif;color:#838383"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:7.5pt;font-family:"Arial",sans-serif;color:#929396"><img width="283" height="41" id="Picture_x0020_1" src="cid:image001.png@01D15215.F6A0A8D0" alt="Description: Description: Description: Description: Description: Description: cid:C3593B93-B89C-44B0-A763-6E009A4C92D6"></span><span lang="DE-CH"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:7.5pt;font-family:"Arial",sans-serif"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:7.5pt;font-family:"Arial",sans-serif">CONFIDENTIALITY NOTICE
<br>
This email transmission is intended only for the use of the individual or entity named above and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby
notified that any disclosure, copying, distribution or use of any of the information contained in this transmission is strictly PROHIBITED</span><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>