[fdo-trac] #318: [REVIEW] PostGIS provider patch 3.4 from Bruno Scott

[FDO]

#318: [REVIEW] PostGIS provider patch 3.4 from Bruno Scott
------------------------------+---------------------------------------------
 Reporter:  mloskot           |         Owner:  mloskot 
     Type:  task              |        Status:  assigned
 Priority:  critical          |     Milestone:  3.4.0   
Component:  PostGIS Provider  |       Version:          
 Severity:  1                 |    Resolution:          
 Keywords:  postgis patch     |   External_id:          
------------------------------+---------------------------------------------
Comment (by mloskot):

 Bruno,

 Is this intentional that in file
 ''Providers/PostGIS/Src/Provider/DeleteCommand.cpp'', lines 49-51:
 {{{
 // eric barby - faster way of describing schema
 SchemaDescription *schemaDesc = mConn->DescribeSchema();
 if (!schemaDesc || !schemaDesc->IsDescribed())
 }}}

 schemaDesc is not wrapped with FdoPtr ?

 The ''Connection::DescribeSchema'' increments reference counter to the
 schema description object. So, client of the schemaDesc is supposed to
 decrement it, ideally  using automatic collection with FdoPtr.

-- 
Ticket URL: <http://trac.osgeo.org/fdo/ticket/318#comment:12>
FDO <http://fdo.osgeo.org/>
Feature Data Objects