Hello Dan and Greg,<br><br>we are currently using 3.5, and we are in the middle of a release. I could patch 3.5 locally and use<br>our own binaries. <br><br>I'll try to run the test suite during beginning of the week, and check if the tests triggers new code. I assume<br>
there are tests that validates geometries. I can add necessary test code if I find that something is left out.<br><br>After testing I can attach the patch.<br><br>PS the memory leak I mentioned was fixed in a different way than I described.<br>
<br><br>-- Oyvind<br><br><br><br><br><div class="gmail_quote">On Fri, Feb 18, 2011 at 5:23 PM, Dan Stoica <span dir="ltr"><<a href="mailto:dan.stoica@autodesk.com">dan.stoica@autodesk.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div link="blue" vlink="purple" lang="EN-US">
<div>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Hi Oyvind,</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">In addition, before submitting the patch please run the unit tests suite.</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Does your change needs a specific unit test thus making sure it is exercised?</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Dan.</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<div>
<div style="border-style: solid none none; border-color: rgb(181, 196, 223) -moz-use-text-color -moz-use-text-color; border-width: 1pt medium medium; padding: 3pt 0in 0in;">
<p class="MsoNormal"><b><span style="font-size: 10pt;">From:</span></b><span style="font-size: 10pt;"> <a href="mailto:fdo-users-bounces@lists.osgeo.org" target="_blank">fdo-users-bounces@lists.osgeo.org</a> [mailto:<a href="mailto:fdo-users-bounces@lists.osgeo.org" target="_blank">fdo-users-bounces@lists.osgeo.org</a>]
<b>On Behalf Of </b>Greg Boone<br>
<b>Sent:</b> Friday, February 18, 2011 10:19 AM<div class="im"><br>
<b>To:</b> FDO Users Mail List<br>
</div><b>Subject:</b> RE: [fdo-users] Re: SDE and slow multi-geometries</span></p>
</div>
</div><div><div></div><div class="h5">
<p class="MsoNormal"> </p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Can you create an svn patch and attach it to the ticket related to this defect? Once that is done I can have a few people look at the changes and have it submitted.
</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">At this point these changes can go into the trunk, and possibly the 3.6 branch. Is there a requirement to have the changes ported back to 3.5?</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);">Greg</span></p>
<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>
<p class="MsoNormal"><b><span style="font-size: 10pt;">From:</span></b><span style="font-size: 10pt;"> <a href="mailto:fdo-users-bounces@lists.osgeo.org" target="_blank">fdo-users-bounces@lists.osgeo.org</a> [mailto:<a href="mailto:fdo-users-bounces@lists.osgeo.org" target="_blank">fdo-users-bounces@lists.osgeo.org</a>]
<b>On Behalf Of </b>Oyvind Idland<br>
<b>Sent:</b> Friday, February 18, 2011 5:05 AM<br>
<b>To:</b> FDO Users Mail List<br>
<b>Subject:</b> [fdo-users] Re: SDE and slow multi-geometries</span></p>
<p class="MsoNormal"> </p>
<p class="MsoNormal" style="margin-bottom: 12pt;">The code is now fixed. As I got started, I also did some related code cleanup:<br>
<br>
- the macro function EXPAND() are now gone. Instead, I made a simple templated<br>
array class with an array subscript operator. This looks much cleaner now and can be
<br>
debugged.<br>
<br>
<br>
- the macro function ADD_POINT is also gone, replaced with an inline static function.<br>
<br>
<br>
- memory leak: ArcSDEConnection, line 885: <br>
<br>
CHAR *qualified_table_name = new CHAR[SE_QUALIFIED_TABLE_NAME+1];<br>
<br>
This one never gets deleted. I can't see any reason to use new, so I replaced it<br>
with an array instead:<br>
<br>
CHAR qualified_table_name [SE_QUALIFIED_TABLE_NAME+1];<br>
<br>
<br>
<br>
However, there are still things I'd like to do with the code: The geometry buffering is
<br>
attached to the ArcSDEConnection class, and functions like convert_sde_shape_to_fgf()<br>
are poking around in these arrays (XY, Z, parts etc). What I would like to do, is to<br>
wrap all these arrays together with the indexing code into a new SDE geometry <br>
handling class. This won't add anything new, just make it more clean.<br>
<br>
<br>
Where can I submit/send the changes ?<br>
<br>
<br>
-- Oyvind<br>
<br>
<br>
<br>
</p>
<div>
<p class="MsoNormal">On Wed, Feb 16, 2011 at 4:53 PM, Oyvind Idland <<a href="mailto:oyvind.idland@gmail.com" target="_blank">oyvind.idland@gmail.com</a>> wrote:</p>
<p class="MsoNormal">Hello,<br>
<br>
I have been looking into an issue that was brought up here earlier. Turns out that the SDE API<br>
is slower than cold molassis when using SE_shape_get_num_points() on multipart geometries.<br>
<br>
I did some experimentation using the index tables returned from SE_shape_get_all_points()<br>
directly. The total processing speed on my dataset went from roughly 20 secs down to less than
<br>
1 sec. There are several huge polygons with 200+ holes in them, and multilines.<br>
<br>
Why the native SDE API is so slow is a mystery, those indices should not require heavy<br>
calculation.<br>
<br>
The code is experimental so far, but when I finish writing the code, I can submit a patch<br>
if desired.<br>
<br>
<br>
-- Øyvind Idland </p>
</div>
<p class="MsoNormal"> </p>
</div></div></div>
</div>
<br>_______________________________________________<br>
fdo-users mailing list<br>
<a href="mailto:fdo-users@lists.osgeo.org">fdo-users@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/fdo-users" target="_blank">http://lists.osgeo.org/mailman/listinfo/fdo-users</a><br>
<br></blockquote></div><br>