<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">This looks like a good area for refactoring. I agree that having the default constructor call the non-default constructor is not the best approach.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Greg<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> fdo-users-bounces@lists.osgeo.org [mailto:fdo-users-bounces@lists.osgeo.org]
<b>On Behalf Of </b>Oyvind Idland<br>
<b>Sent:</b> Monday, February 28, 2011 7:41 AM<br>
<b>To:</b> FDO Users Mail List<br>
<b>Subject:</b> [fdo-users] ArcSDE: Another serious bug (general C++ trap)<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">In the definition of ArcSDEFilterToSql (in ArcSDEFilterToSQL.h), there are two<br>
constructors:<br>
<br>
ArcSDEFilterToSql() { ArcSDEFilterToSql(NULL, NULL); } // 0-argument constructor to please FdoPtr::operator-><br>
<br>
ArcSDEFilterToSql (ArcSDEConnection *conn, FdoClassDefinition* definition);<br>
<br>
<br>
The first one with no arguments will not work, in fact, it will just allocate another instance of itself and return.<br>
<br>
There is, as far as I know, no way to make a constructor call another constructor in C++. Instead, an init() method<br>
must be implemented.<br>
<br>
I don't know if this constructor has ever been used, I just saw it while refactoring code.. but I am a bit worried if<br>
this has been done several places.<br>
<br>
<br>
-- Oyvind<br>
<br>
<br>
<br>
<br>
<o:p></o:p></p>
</div>
</body>
</html>