[fusion-dev] [Code Review]Theme widget cause an error on raster layer

[Mike Adair]

Arthur,

I don't know enough about the theme task to really comment but your 
change looks simple enough and if it fixes the issue then it should be 
fine to commit.

Mike



Arthur Liu wrote:
>
> Hi all,
>
> Would you please review the patch at 
> http://trac.osgeo.org/fusion/attachment/ticket/359/thememain.patch for 
> ticket http://trac.osgeo.org/fusion/ticket/359?
>
> Comments:
>
> Theme widget doesn’t work on raster and drawing layers(if I am right), 
> but it should not throw error like 
> http://trac.osgeo.org/fusion/attachment/ticket/359/Raster.JPG
>
> [Analysis]
>
> For layers which don't contain the geometry property, the layer's name 
> will not be record in layerNames in theme.php
>
> So in thememain.php the layerSelect.value will be null, and the 
> layerInfo request will fail.
>
> [Resolution/Workaround]
>
> To resolve this problem, I checked the layerSelect.value, if it's 
> null, just return.
>
> Thanks,
>
> Arthur
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> fusion-dev mailing list
> fusion-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/fusion-dev
>   

-- 
   Michael Adair
   Senior Software Architect
   DM Solutions Group Inc.

   Office: (613) 565-5056 x26
   madair at dmsolutions.ca
   http://www.dmsolutions.ca
   http://research.dmsolutions.ca