[gdal-dev] Improving ogr dxf driver spline reader

[Even Rouault]

Le vendredi 01 avril 2016 19:36:41, Pero Brbora a écrit :
> Hi,
> 
> I would like to improve ogr dxf driver spline reader. I have created
> few test files and found mistakes in source code. Current spline
> reader creates splines only from control points, and then tries to
> recreate knots and sets weights to 1. From my understanding of splines
> they are completely defined with control points, knots and weights -
> and all this data can be read from dxf file.
> 
> Is it ok to:
> first) submit ticket with description and test files
> second) 

Screenshots of a reader that correctly displays the splines attached to the 
ticket can be useful to check that the proposed fix looks good.

> submit pull request which targets autotest part of gdal and
> adds tests which show that current implementation fails
> third) submit pull request which targets ogr dxf dxf driver and fixes
> all of the above

The usual practice is a single pull request with driver fix + small samples + 
new tests with the (fixed) expected result (and/or fixes to existing tests that 
would have been wrong previously)

> 
> Is this correct approach for contributing to gdal?
> 
> Thanks, bye
> 
> _______________________________________________
> gdal-dev mailing list
> gdal-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/gdal-dev

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com