[gdal-dev] compile error on windows

[Even Rouault]

Le mardi 03 mai 2016 18:23:47, Jeff McKenna a écrit :
> On 2016-05-03 4:54 AM, Even Rouault wrote:
> >> -EXTRAFLAGS     =     -I$(HDF5_DIR)\include -DWIN32 -D_HDF5USEDLL_
> >> +EXTRAFLAGS     =     -I$(HDF5_DIR)\include -DWIN32
> >> -DH5_BUILT_AS_DYNAMIC_LIB
> > 
> > Jeff,
> > 
> > does the above match your experience ? We could probably define both
> > _HDF5USEDLL_ and H5_BUILT_AS_DYNAMIC_LIB to address different versions.
> > 
> > I see in https://www.hdfgroup.org/windows/faq.html that _HDF5USEDLL_ is
> > still advised.
> 
> Hi Even,
> 
> I only set -D_HDF5USEDLL in /frmts/hdf5/makefile.vc and I don't have any
> issues compiling GDAL against HDF5-1.8.16

If you have the opportunity, it would be good if you could check if defining 
both _HDF5USEDLL_ and H5_BUILT_AS_DYNAMIC_LIB doesn't affect negatively your 
builds. Ideally, we'd like to have a default set of compilation flags that 
works out of the box for (almost) everybody.

> 
> It likely comes down to how HDf5 is compiled (the cmake settings), which
> again calls for everyone to be sure to make sure these notes are
> recorded on the buildhints page (which by all the discussion here
> lately, that page should be getting lots and lots of edits lately -
> that's a strong nudge from me to everyone).
> https://trac.osgeo.org/gdal/wiki/HDF

> 
> -jeff

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com