[gdal-dev] Automating code style enforcement ?

Mateusz Loskot mateusz at loskot.net
Fri May 5 04:46:56 PDT 2017


On 5 May 2017 at 13:35, Even Rouault <even.rouault at spatialys.com> wrote:
>
> In case we want to have a policy regarding braces around single statements,
> one finding coming from the openjpeg discussion I mentionned :
>
> """
> Moreover, concerning braces around single statements, it seems astyle does
> this with the add-braces option:
> http://astyle.sourceforge.net/astyle.html#_add-braces
> As far as I understood, clang-format does not, and requires another tool
> (clang-tidy) to deal with these cases. So one more point for astyle.
> """

Rather, it is a separation of concerns: linting vs formatting
AFAIU, clang-format does not modify any code (ie. add tokens).

I'm not clang-format advocate. I'll repeat myself:
My personal preference is to use clang-format.
I proposed it to GEOS via GEOS RFC.
Kurt found the RFC useful and is using it as a template
to prepare one for GDAL.
IMHO, at the end of the day, tool does not matter as long as proposed
goals are achieved.

Best regards,
-- 
Mateusz Loskot, http://mateusz.loskot.net


More information about the gdal-dev mailing list