[gdal-dev] WCS 1.1 in GDAL

Even Rouault even.rouault at spatialys.com
Wed Nov 1 04:20:52 PDT 2017


On mercredi 1 novembre 2017 13:05:09 CET Ari Jolma wrote:
> Ari Jolma kirjoitti 01.11.2017 klo 11:04:
> > It seems to me that WCS 1.1 has been dormant and perhaps nobody has
> > really used it ever(?).
> > 
> > I just found the gdalgmlcoverage.cpp file in gcore, which is only used
> > by the WCS driver and only in its 1.1 part
> 
> Actually, in 1.0, since 1.1 does not seem to use the gml:RectifiedGrid,
> however, 2.0 uses it again.
> 
> Anyway, the question is, should gdalgmlcoverage.cpp be in the gcore? 

Feel free to move it to frmts/wcs as it only used by it. You'd probably want to remove the 
declaration of it from gcore/gdal_priv.h as well.
Looking at GDALParseGMLCoverage() code, I see a "GDALJP2Metadata" remaining 
CPLDebug message, but it is no longer used by the GMLJP2 code which has a specialized 
version of it now. You may have a look at GDALJP2Metadata::ParseGMLCoverageDesc() in 
gcore/gdaljp2metadata.cpp by the way, in particular the logic for axis inversion around lines 
1055-1089. Note: there are also stuff specific of GMLJP2 issues at the end of the function, so 
I would *not* recommend blindly porting all this.

> The
> GDAL sources are sometimes confusing. For example there is gmlutils.cpp
> - which is used in WCS

In your in-progress work I suppose. Can't see that in trunk.
Could probably make sense to move it in ogr/  then  (we have already ogr/
gml2ogrgeometry.cpp and ogr2gmlgeometry.cpp there)

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/gdal-dev/attachments/20171101/2dcd7b96/attachment.html>


More information about the gdal-dev mailing list