[gdal-dev] #include tiffio.h in gtiff/libgeotiff/

[Ari Jolma]

On 12.04.2018 19:25, Even Rouault wrote:
> On jeudi 12 avril 2018 09:56:35 CEST Ari Jolma wrote:
>> The file frmts/gtiff/libgeotiff/xtiffio.h #include's "tiffio.h", which
>> is in frmts/gtiff/libtiff. However, when compiling in this directory
>> frmts/gtiff/libtiff is not included.
> I presume the libtiff.so must be present on the system, but not the TIFF
> headers.

More likely the libtiff.a since compiling the conftest.c tests for it 
(with -ltiff). In Linux Mint that would mean a broken libtiff-dev 
package - at least that's how I can reproduce the case in it. 
Interesting that a such situation should exist in a FreeBSD test 
environment.

>   Likely development package of libtiff missing.
> GDAL's configure apparently only check the presence of the .so but doens't
> check that the header is available.

Yes.

> Internal tiffio.h is included by internal libgeotiff if GDAL detects use of
> internal libtiff (TIFF_SETTING=internal in GDALmake.opt)
> But it wouldn't be correct for the internal libgeotiff to include the internal
> tiffio.h and linking against external libgeotiff.

I guess in this case the best way is to explicitly set 
--with-libtiff=internal.


>
> So the immediate fix is make sure libtiff headers are present on the system
> (or explicitly select internal libtiff in ./configure)
> And an improvement in configure.ac would be also welcome to check that the
> headers of external libtiff are available.

Maybe AC_CHECK_HEADER could be used in addition.

BTW, interestingly the "Check if user requests renaming internal 
libgeotiff symbols" seems to appear twice in the configure.ac.

>
> Even
>

Thanks,

Ari