Daniel,<br><br>I don't think we extensively use filenames and URLs in the style strings however we may indeed consider the dot '.' as a reserved char for example in the parameters which could be a float value in the style strings. In such sense the comma ',' could also be a character which already used as a separator in the style strings. By all means if we go ahead with this variant, the upper level libraries using the style strings (like mapserver) should also be fixed. We may consider whether such fix should be appied only in the development version only or in the stable branch as well.<br>
<br><br>BTW: How is the MITAB upstream project normally updated with the changes in the GDAL project. Is that based on the SVN changeset in GDAL (in the mitab subdir) or based on the bugs submitted to the maptools tracker? I can see a variety of changes/fixes even in the GDAL stable branch which should also be applied in MITAB before pulling the whole mainstream back in the GDAL SVN.<br>
<br><br>Best regards,<br><br>Tamas<br><br><br><br><div class="gmail_quote">2010/9/23 Daniel Morissette <span dir="ltr"><<a href="mailto:dmorissette@mapgears.com">dmorissette@mapgears.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
(Cross-posted to mapserver-dev)<br>
<br>
Okay, I finally found traces of the previous discussions on this topic<br>
in one GDAL ticket, and a related MITAB bugzilla entry:<br>
<br>
<a href="http://trac.osgeo.org/gdal/ticket/3571" target="_blank">http://trac.osgeo.org/gdal/ticket/3571</a><br>
<br>
and<br>
<br>
<a href="http://bugzilla.maptools.org/show_bug.cgi?id=2206" target="_blank">http://bugzilla.maptools.org/show_bug.cgi?id=2206</a><br>
<br>
<wrist_slap><br>
Tamas and I would have saved lots of time if winkey had included a<br>
reference to the ticket number in his SVN commit change log... please<br>
all developers take this as a reminder to include refs to ticket number<br>
in SVN change logs, and references to the SVN revision number when<br>
closing tickets... this makes it much easier to go back in history.<br>
</wrist_slap><br>
<br>
Sounds like what needs to happen is:<br>
<br>
1- Add version-specific code in MapServer's msOGRGetSymbolId() to look<br>
for "," vs "." delimiter in symbol ids depending on GDAL/OGR version<br>
<br>
2- Add prominent note about this backwards incompatibility in the MITAB<br>
driver notes, the GDAL/OGR 1.8 release notes, and on the list so that<br>
developers of other applications using style strings can update their<br>
code before it breaks in the user's hands<br>
<br>
3- Update MITAB upstream with the same change (so that it is not<br>
overwritten in future updates of the OGR copy)<br>
<br>
4- And perhaps ensure that no other driver in OGR currently generates<br>
symbol ids with "." and need the same fix.<br>
<br>
What do you think Tamas?<br>
<font color="#888888"><br>
Daniel<br>
</font><div><div></div><div class="h5"><br>
<br>
Daniel Morissette wrote:<br>
> Hi Tamas,<br>
><br>
> I remember that I discussed with other devs this a little while ago, I'm<br>
> just not sure if that was on the list or on IRC... however I'm a bit<br>
> surprised since I see that r19724 was done by winkey and I thought I had<br>
> this discussion with aboudreault, so I'll need to dig a bit further to<br>
> refresh my mind about this.<br>
><br>
> Anyway, I think in the end the conclusion was that we should bite the<br>
> bullet and fix things to really use "," as a separator (instead of "."<br>
> which is currently wrong and causes some side-effects which I can't<br>
> remember just now). The only side-effect of this fix is on applications<br>
> using Style strings, and there are probably very few of them, the only<br>
> one I know about myself is MapServer, and the fix for them will be to<br>
> add a version-specific #ifdef to look for either "," or "." depending on<br>
> the GDAL/OGR version.<br>
><br>
> I'll try to dig out the discussions that we had about this and get back<br>
> to you with more details.<br>
><br>
> Daniel<br>
><br>
><br>
> Tamas Szekeres wrote:<br>
>> Hi All,<br>
>><br>
>> There have been a backward incompatible change in r19724<br>
>> <<a href="http://trac.osgeo.org/gdal/changeset/19724" target="_blank">http://trac.osgeo.org/gdal/changeset/19724</a>> related to the OGR style<br>
>> string format. According to this change the separator in the feature<br>
>> style id has been changed from '.' to ','<br>
>> Unfortunately such kind of changes may cause existing applications to<br>
>> work incorrectly and would also need to be fixed. For instance this<br>
>> change affects the mapserver function msOGRGetSymbolId in mapogr.cpp<br>
>> <<a href="http://trac.osgeo.org/mapserver/browser/trunk/mapserver/mapogr.cpp" target="_blank">http://trac.osgeo.org/mapserver/browser/trunk/mapserver/mapogr.cpp</a>> as<br>
>> well. So as to fix this issue in mapserver, we would probably require to<br>
>> keep the original code simultaneously, depending on the gdal version.<br>
>><br>
>> I'd be curious to know whether we have any compelling reason to apply<br>
>> these modifications, or we just wanted to follow the feature style<br>
>> specification <<a href="http://www.gdal.org/ogr/ogr_feature_style.html" target="_blank">http://www.gdal.org/ogr/ogr_feature_style.html</a>> with<br>
>> these changes? In the latter case I would personally in favour of<br>
>> reverting these changes in gdal and handle this issue by fixing the<br>
>> feature style documentation to follow the original syntax.<br>
>><br>
>> Any ideas?<br>
>><br>
>><br>
>> Best regards,<br>
>><br>
>> Tamas<br>
>><br>
>><br>
>><br>
>> ------------------------------------------------------------------------<br>
>><br>
>> _______________________________________________<br>
>> gdal-dev mailing list<br>
>> <a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a><br>
>> <a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
><br>
><br>
<br>
<br>
--<br>
Daniel Morissette<br>
<a href="http://www.mapgears.com/" target="_blank">http://www.mapgears.com/</a><br>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
</div></div></blockquote></div><br>