<div dir="ltr">Here is what cppcheck 1.64 reports as 'errors' in gdal-1.10.1:<div><br></div><div><div>[frmts\adrg\adrgdataset.cpp:1071]: (error) Memory leak: TILEINDEX</div><div>[frmts\coasp\coasp_dataset.cpp:199]: (error) Undefined behavior: Variable 'pszItemValue' is used as parameter and destination in s[n]printf().</div>
<div>[frmts\dted\dted_create.c:181]: (error) Resource leak: fp</div><div>[frmts\envisat\EnvisatFile.c:286]: (error) Memory leak: self</div><div>[frmts\envisat\EnvisatFile.c:609]: (error) Memory leak: dsd_text</div><div>[frmts\envisat\EnvisatFile.c:1776]: (error) Memory leak: entry</div>
<div>[frmts\georaster\georaster_dataset.cpp:188]: (error) Possible null pointer dereference: poGRD</div><div>[frmts\georaster\georaster_dataset.cpp:189]: (error) Possible null pointer dereference: poGRD</div><div>[frmts\georaster\georaster_dataset.cpp:190]: (error) Possible null pointer dereference: poGRD</div>
<div>[frmts\georaster\georaster_dataset.cpp:191]: (error) Possible null pointer dereference: poGRD</div><div>[frmts\georaster\oci_wrapper.cpp:1590]: (error) Pointer to local array variable returned.</div><div>[frmts\gif\giflib\gifalloc.c:67]: (error) Memory leak: Object</div>
<div>[frmts\grib\degrib18\degrib\clock.c:2071]: (error) Common realloc mistake: 'Stack' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\clock.c:2175]: (error) Common realloc mistake: 'Rel' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\clock.c:2197]: (error) Common realloc mistake: 'Rel' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\clock.c:2209]: (error) Common realloc mistake: 'Rel' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\grib2api.c:594]: (error) Uninitialized variable: igdstmpl</div><div>[frmts\grib\degrib18\degrib\metaparse.cpp:2628]: (error) Common realloc mistake: 'freq' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\myerror.c:109]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\myerror.c:126]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\myerror.c:132]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\myerror.c:149]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\myerror.c:158]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\myerror.c:187]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\myerror.c:195]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\myerror.c:203]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\myerror.c:211]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\myerror.c:218]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\myerror.c:229]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\myerror.c:241]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\myerror.c:257]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\myerror.c:442]: (error) Common realloc mistake: 'preBuffer' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\myerror.c:534]: (error) Common realloc mistake: 'buff' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\myutil.c:85]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\myutil.c:92]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\myutil.c:99]: (error) Common realloc mistake: 'buffer' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\myutil.c:149]: (error) Common realloc mistake: 'argv' nulled but not freed upon failure</div><div>[frmts\grib\degrib18\degrib\tdlpack.cpp:3256]: (error) Common realloc mistake: 'subGroup' nulled but not freed upon failure</div>
<div>[frmts\grib\degrib18\degrib\tdlpack.cpp:4179]: (error) Read and write operations without a call to a positioning function (fseek, fsetpos or rewind) or fflush in between result in undefined behaviour.</div><div>[frmts\grib\degrib18\g2clib-1.0.4\compack.c:159]: (error) Uninitialized variable: ival1</div>
<div>[frmts\grib\degrib18\g2clib-1.0.4\comunpack.c:198]: (error) Memory leak: ifld</div><div>[frmts\grib\degrib18\g2clib-1.0.4\misspack.c:203]: (error) Uninitialized variable: ival1</div><div>[frmts\grib\degrib18\g2clib-1.0.4\misspack.c:118]: (error) Uninitialized variable: rmisss</div>
<div>[frmts\grib\degrib18\g2clib-1.0.4\pngunpack.c:61]: (error) Memory leak: ifld</div><div>[frmts\grib\degrib18\g2clib-1.0.4\pngunpack.c:61]: (error) Memory leak: ctemp</div><div>[frmts\hdf4\hdf-eos\EHapi.c:2315]: (error) Common realloc mistake: 'metabuf' nulled but not freed upon failure</div>
<div>[frmts\hdf4\hdf-eos\EHapi.c:3665]: (error) Common realloc mistake: 'EHXtypeTable' nulled but not freed upon failure</div><div>[frmts\hdf4\hdf-eos\EHapi.c:3668]: (error) Common realloc mistake: 'EHXacsTable' nulled but not freed upon failure</div>
<div>[frmts\hdf4\hdf-eos\EHapi.c:3671]: (error) Common realloc mistake: 'EHXfidTable' nulled but not freed upon failure</div><div>[frmts\hdf4\hdf-eos\EHapi.c:3674]: (error) Common realloc mistake: 'EHXsdTable' nulled but not freed upon failure</div>
<div>[frmts\hdf4\hdf-eos\GDapi.c:2411]: (error) Array 'HDFcomp[5]' accessed at index 19, which is out of bounds.</div><div>[frmts\hdf4\hdf-eos\GDapi.c:2177]: (error) Array 'originNames[4]' accessed at index 15, which is out of bounds.</div>
<div>[frmts\hdf4\hdf-eos\GDapi.c:2292]: (error) Array 'pixregNames[2]' accessed at index 7, which is out of bounds.</div><div>[frmts\hdf4\hdf-eos\SWapi.c:4995]: (error) Memory leak: fillbuf</div><div>[frmts\hdf4\hdf-eos\SWapi.c:5615]: (error) Memory leak: flag</div>
<div>[frmts\hdf4\hdf-eos\SWapi.c:6239]: (error) Memory leak: flag</div><div>[frmts\idrisi\IdrisiDataset.cpp:1886]: (error) syntax error</div><div>[frmts\ilwis\ilwisdataset.cpp:1425]: (error) syntax error</div><div>[frmts\msg\msgdataset.cpp:532]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.</div>
<div>[frmts\netcdf\netcdfdataset.cpp:5997]: (error) Uninitialized variable: strtime</div><div>[frmts\pcidsk\sdk\core\pcidsk_utils.cpp:644]: (error) Common realloc mistake: 'pszWorkBuffer' nulled but not freed upon failure</div>
<div>[frmts\pcidsk\sdk\core\pcidskexception.cpp:170]: (error) Common realloc mistake: 'pszWorkBuffer' nulled but not freed upon failure</div><div>[frmts\png\libpng\pngrutil.c:996]: (error) Uninitialized variable: igamma</div>
<div>[frmts\rasterlite\rasterlitedataset.cpp:1179]: (error) Possible null pointer dereference: poDS</div><div>[frmts\rasterlite\rasterlitedataset.cpp:1185]: (error) Possible null pointer dereference: poDS</div><div>[frmts\rasterlite\rasterlitedataset.cpp:1186]: (error) Possible null pointer dereference: poDS</div>
<div>[frmts\rasterlite\rasterlitedataset.cpp:1187]: (error) Possible null pointer dereference: poDS</div><div>[frmts\rasterlite\rasterlitedataset.cpp:1188]: (error) Possible null pointer dereference: poDS</div><div>[frmts\rasterlite\rasterlitedataset.cpp:1190]: (error) Possible null pointer dereference: poDS</div>
<div>[frmts\rasterlite\rasterlitedataset.cpp:1191]: (error) Possible null pointer dereference: poDS</div><div>[frmts\rasterlite\rasterlitedataset.cpp:1192]: (error) Possible null pointer dereference: poDS</div><div>[frmts\rasterlite\rasterlitedataset.cpp:1193]: (error) Possible null pointer dereference: poDS</div>
<div>[frmts\rasterlite\rasterlitedataset.cpp:1194]: (error) Possible null pointer dereference: poDS</div><div>[frmts\rasterlite\rasterlitedataset.cpp:1195]: (error) Possible null pointer dereference: poDS</div><div>[frmts\rasterlite\rasterlitedataset.cpp:1196]: (error) Possible null pointer dereference: poDS</div>
<div>[frmts\rasterlite\rasterlitedataset.cpp:1267]: (error) Possible null pointer dereference: poDS</div><div>[frmts\raw\atlsci_spheroid.cpp:122]: (error) syntax error</div><div>[frmts\raw\mffdataset.cpp:1451]: (error) syntax error</div>
<div>[frmts\sgi\sgidataset.cpp:523]: (error) Using 'memcpy' on struct that contains a 'std::string'.</div><div>[ogr\ogrsf_frmts\dgn\dgnhelp.cpp:1379]: (error) syntax error</div><div>[ogr\ogrsf_frmts\dwg\ogrdwglayer.cpp:323]: (error) Invalid number of character ({) when these macros are defined: 'notdef'.</div>
<div>[ogr\ogrsf_frmts\filegdb\FGdbLayer.cpp:1914]: (error) syntax error</div><div>[ogr\ogrsf_frmts\generic\ogrdatasource.cpp:1425]: (error) Possible null pointer dereference: papoSrcLayers</div><div>[ogr\ogrsf_frmts\mitab\mitab_coordsys.cpp:747]: (error) Buffer is accessed out of bounds.</div>
<div>[ogr\ogrsf_frmts\mitab\mitab_geometry.cpp:223]: (error) Memory leak: xintersect</div><div>[ogr\ogrsf_frmts\ntf\ntffilereader.cpp:260]: (error) Memory pointed to by 'poRecord' is freed twice.</div><div>[ogr\ogrsf_frmts\pg\ogrpgdatasource.cpp:1102]: (error) Memory leak: poLayer</div>
<div>[ogr\ogrsf_frmts\shape\shptree.c:241]: (error) Memory leak: psTree</div><div>[port\cpl_minizip_zip.cpp:608]: (error) Memory leak: zi</div><div>[port\cpl_strtod.cpp:67]: (error) Division by zero.</div></div><div><br>
</div>
<div>I'd be happy to provide fix patches, but i have not much time at the moment, so it won't be before a 1.11 release.</div><div><br></div><div>If you want to see the other 'warnings', and get un updated report on GDAL trunk, maybe you could ask to those who manage <a href="http://debbie.postgis.net:8080/view/GDAL/">http://debbie.postgis.net:8080/view/GDAL/</a> to add the cppcheck plugin to their Jenkins?</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-03-26 9:15 GMT+01:00 Even Rouault <span dir="ltr"><<a href="mailto:even.rouault@mines-paris.org" target="_blank">even.rouault@mines-paris.org</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Olivier,<br>
<br>
If you could share with us the errors that have been reported (and the options<br>
you have used to pass cppcheck on GDAL source), that would be a good<br>
contribution. Even better if you can submit a patch to fix them ;-)<br>
Not saying they shouldn't be fixed, but I don't see that as a blocker point<br>
however, unless they show up in nominal code paths. They have likely existed for<br>
years.<br>
We also have registered GDAL to the Coverity scanner, and we try to fix errors<br>
that are reported in new code.<br>
<br>
Even<br>
<div class=""><br>
> I think you should take a look at what cppcheck finds when scanning GDAL<br>
> source before the next release. There are a few tens of small errors.<br>
> Mostly, small leaks in particalr cases. Not very important errors, but that<br>
> ought to be fixed before doing an release in my opinion<br>
><br>
><br>
> 2014-03-26 8:49 GMT+01:00 Paul Meems <<a href="mailto:bontepaarden@gmail.com">bontepaarden@gmail.com</a>>:<br>
><br>
> > +1 for adding VS2013 binaries in GISInternals<br>
> ><br>
> > Thanks,<br>
> ><br>
> > Paul<br>
> ><br>
</div>> > *Paul Meems *<br>
<div class="">> > Release manager, configuration manager<br>
> > and forum moderator of MapWindow GIS.<br>
> > <a href="http://www.mapwindow.org" target="_blank">www.mapwindow.org</a><br>
> ><br>
> > Owner of MapWindow.nl - Support for<br>
> > Dutch speaking users.<br>
> > <a href="http://www.mapwindow.nl" target="_blank">www.mapwindow.nl</a><br>
> ><br>
> ><br>
> ><br>
</div>> > *Join us at the MapWindow GIS Conference 2014<br>
> > <<a href="http://geogis.detek.unideb.hu/TKonferencia/2014/" target="_blank">http://geogis.detek.unideb.hu/TKonferencia/2014/</a>>, in Debrecen Hungary*<br>
<div><div class="h5">> ><br>
> ><br>
> > 2014-03-26 6:25 GMT+01:00 xavier lhomme <<a href="mailto:lhomme.xavier@gmail.com">lhomme.xavier@gmail.com</a>>:<br>
> ><br>
> > Hi<br>
> >> Adding Visual Studio 2012 2013 in GISInternals for Gdal 1.11 should be<br>
> >> great too.<br>
> >> Xav<br>
> >> Le 25 mars 2014 22:57, "Tamas Szekeres" <<a href="mailto:szekerest@gmail.com">szekerest@gmail.com</a>> a écrit :<br>
> >><br>
> >> That sounds good to me.<br>
> >>><br>
> >>> Best regards,<br>
> >>><br>
> >>> Tamas<br>
> >>><br>
> >>><br>
> >>><br>
> >>> 2014-03-25 22:37 GMT+01:00 Even Rouault <<a href="mailto:even.rouault@mines-paris.org">even.rouault@mines-paris.org</a>>:<br>
> >>><br>
> >>>> Hi,<br>
> >>>><br>
> >>>> GDAL 1.10 was released about one year ago, so it is time to think about<br>
> >>>> the next<br>
> >>>> release. I think we should just call it 1.11 given that there are no<br>
> >>>> major<br>
> >>>> architectural changes (although there have been non trivial changes in<br>
> >>>> RAT<br>
> >>>> management and for multiple geometry field support, but that only<br>
> >>>> impacts core &<br>
> >>>> drivers), and the C API and ABI is still preserved (for those who have<br>
> >>>> looked at<br>
> >>>> the other thread, my experiments on unification are *not* in trunk).<br>
> >>>> For the<br>
> >>>> details, I have initiated the preliminary NEWS :<br>
> >>>> <a href="http://trac.osgeo.org/gdal/export/27091/trunk/gdal/NEWS" target="_blank">http://trac.osgeo.org/gdal/export/27091/trunk/gdal/NEWS</a> (*)<br>
> >>>> There are some mentions to 2.0 in the documentation of new features,<br>
> >>>> but I'll<br>
> >>>> end up fixing them to reflect the 1.11 numbering.<br>
> >>>><br>
> >>>> I think we are in a good shape to start the beta phase soon. If people<br>
> >>>> have<br>
> >>>> features or bug fixes almost ready that they'd like to be in 1.11,<br>
> >>>> please speak<br>
> >>>> up now. Otherwise I suggest issuing a beta-1 at the end of next week,<br>
> >>>> give it a<br>
> >>>> week for testing, and depending on the outcome, issue a beta-2, or just<br>
> >>>> try<br>
> >>>> RC-1. Unless someone volunteers (the process is fairly well documented<br>
> >>>> in<br>
> >>>> HOWTO-RELEASE), I can be release manager for 1.11.<br>
> >>>><br>
> >>>> Any opinion about that plan ?<br>
> >>>><br>
> >>>> Best regards,<br>
> >>>><br>
> >>>> Even<br>
> >>>><br>
> >>>> --<br>
> >>>> Geospatial professional services<br>
> >>>> <a href="http://even.rouault.free.fr/services.html" target="_blank">http://even.rouault.free.fr/services.html</a><br>
> >>>> _______________________________________________<br>
> >>>> gdal-dev mailing list<br>
> >>>> <a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a><br>
> >>>> <a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
> >>>><br>
> >>><br>
> >>><br>
> >>> _______________________________________________<br>
> >>> gdal-dev mailing list<br>
> >>> <a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a><br>
> >>> <a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
> >>><br>
> >><br>
> >> _______________________________________________<br>
> >> gdal-dev mailing list<br>
> >> <a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a><br>
> >> <a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
> >><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > gdal-dev mailing list<br>
> > <a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a><br>
> > <a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
> ><br>
><br>
><br>
><br>
> --<br>
> [image: Geovariances]<br>
><br>
</div></div>> Olivier BARTHELEMY *Software development engineer*<br>
<div class="">> Geovariances, 49bis avenue Franklin Roosevelt - 77215 AVON CEDEX - FRANCE<br>
</div>> | <a href="http://www.geovariances.com" target="_blank">www.geovariances.com</a> <<a href="http://link.geovariances.com/eml-home" target="_blank">http://link.geovariances.com/eml-home</a>><br>
> Keep posted about Geovariances <<a href="http://link.geovariances.com/eml-geowidget" target="_blank">http://link.geovariances.com/eml-geowidget</a>><br>
> <<a href="http://link.geovariances.com/eml-linkedin-gv" target="_blank">http://link.geovariances.com/eml-linkedin-gv</a>><br>
> <<a href="http://link.geovariances.com/eml-linkedin" target="_blank">http://link.geovariances.com/eml-linkedin</a>><br>
> <<a href="http://link.geovariances.com/eml-twitter" target="_blank">http://link.geovariances.com/eml-twitter</a>><br>
> <<a href="http://link.geovariances.com/eml-youtube" target="_blank">http://link.geovariances.com/eml-youtube</a>><br>
> <<a href="http://link.geovariances.com/eml-slideshare" target="_blank">http://link.geovariances.com/eml-slideshare</a>><br>
><br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div><table style="font-family:'Times New Roman'"><tbody><tr><td><div style="width:500px;font-size:10px;font-family:Verdana;color:rgb(136,136,136)">
<div><img src="http://link.geovariances.com/eml-logo" alt="Geovariances" width="180" height="35"></div><br><div><span style="color:rgb(85,85,85);font-weight:bold">Olivier BARTHELEMY</span> <em>Software development engineer</em><br>
Geovariances, 49bis avenue Franklin Roosevelt - 77215 AVON CEDEX - FRANCE<br><span style="color:rgb(255,102,0)">|</span> <a href="http://link.geovariances.com/eml-home" target="_blank">www.geovariances.com</a></div></div>
</td></tr><tr><td><div style="float:right;margin-right:10px;font-size:10px;font-family:Verdana;color:rgb(136,136,136)">Keep posted about Geovariances <a href="http://link.geovariances.com/eml-geowidget" title="Download GeoWidget" target="_blank"><img src="http://link.geovariances.com/eml-geowidget-img" width="16" height="16" align="absmiddle" border="0"></a> <a href="http://link.geovariances.com/eml-linkedin-gv" title="Follow us on LinkedIn" target="_blank"><img src="http://link.geovariances.com/eml-linkedin-img" width="16" height="16" align="absmiddle" border="0"></a> <a href="http://link.geovariances.com/eml-linkedin" title="Join our Isatis forum on LinkedIn" target="_blank"><img src="http://link.geovariances.com/eml-isatis-linkedin-img" width="16" height="16" align="absmiddle" border="0"></a> <a href="http://link.geovariances.com/eml-twitter" title="Follow us on Twitter" target="_blank"><img src="http://link.geovariances.com/eml-twitter-img" width="16" height="16" align="absmiddle" border="0"></a> <a href="http://link.geovariances.com/eml-youtube" title="Watch our demos videos on YouTube" target="_blank"><img src="http://link.geovariances.com/eml-youtube-img" width="16" height="16" align="absmiddle" border="0"></a> <a href="http://link.geovariances.com/eml-slideshare" title="Watch our presentations on SlideShare" target="_blank"><img src="http://link.geovariances.com/eml-slideshare-img" width="16" height="16" align="absmiddle" border="0"></a></div>
</td></tr></tbody></table></div></div>
</div>