<!DOCTYPE html><html><head>
<style type="text/css">body { font-family:'Times New Roman'; font-size:13px}</style>
</head>
<body><div>Kurt,</div><div><br></div><div>Yes, that fixed it thanks. I see now only this warning</div><div><br></div><div>v:\gdal\frmts\hdf4\hdf4imagedataset.cpp(2550) : warning C4701: potentially uninitialized local variable 'iWrkNumType' used</div><div><br></div><div>but it's probably a false positive. As are ...</div><div><br></div><div>v:\gdal\frmts\hdf4\hdf-eos\ehapi.c(449) : warning C4701: potentially uninitialized local variable 'sdInterfaceID' used<br>v:\gdal\frmts\hdf4\hdf-eos\ehapi.c(436) : warning C4701: potentially uninitialized local variable 'HDFfid' used<br>v:\gdal\frmts\hdf4\hdf-eos\ehapi.c(446) : warning C4701: potentially uninitialized local variable 'acs' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(2632) : warning C4701: potentially uninitialized local variable 'ndims' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(3270) : warning C4701: potentially uninitialized local variable 'c_info' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(3281) : warning C4701: potentially uninitialized local variable 'chunkDef' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(8618) : warning C4701: potentially uninitialized local variable 'rank' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9568) : warning C4701: potentially uninitialized local variable 'xdum' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9070) : warning C4701: potentially uninitialized local variable 'j' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9569) : warning C4701: potentially uninitialized local variable 'ydum' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9685) : warning C4701: potentially uninitialized local variable 'size' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9847) : warning C4701: potentially uninitialized local variable 'xdum' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(9848) : warning C4701: potentially uninitialized local variable 'ydum' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(10113) : warning C4701: potentially uninitialized local variable 'nRetn' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(6501) : warning C4701: potentially uninitialized local variable 'yMtr0' used<br>v:\gdal\frmts\hdf4\hdf-eos\gdapi.c(6500) : warning C4701: potentially uninitialized local variable 'xMtr0' used<br>v:\gdal\frmts\hdf4\hdf-eos\swapi.c(4282) : warning C4701: potentially uninitialized local variable 'nVal' used<br>v:\gdal\frmts\hdf4\hdf-eos\swapi.c(5839) : warning C4701: potentially uninitialized local variable 'j' used<br>v:\gdal\frmts\hdf4\hdf-eos\swapi.c(7267) : warning C4701: potentially uninitialized local variable 'incr' used<br>v:\gdal\frmts\hdf4\hdf-eos\swapi.c(7301) : warning C4701: potentially uninitialized local variable 'offset' used<br>v:\gdal\frmts\hdf4\hdf-eos\swapi.c(7271) : warning C4701: potentially uninitialized local variable 'index' used<br>v:\gdal\frmts\hdf4\hdf-eos\swapi.c(7249) : warning C4701: potentially uninitialized local variable 'bufOffset' used<br>v:\gdal\frmts\hdf4\hdf-eos\swapi.c(8428) : warning C4701: potentially uninitialized local variable 'incr' used<br>v:\gdal\frmts\hdf4\hdf-eos\swapi.c(8414) : warning C4701: potentially uninitialized local variable 'index' used<br>v:\gdal\frmts\hdf4\hdf-eos\swapi.c(9199) : warning C4701: potentially uninitialized local variable 'j' used<br>v:\gdal\frmts\hdf4\hdf-eos\swapi.c(2451) : warning C4701: potentially uninitialized local variable 'vdataID' used<br> xcopy /D /Y *.obj ..\..\o<br>V:EHapi.obj<br>V:gctp_wrap.obj<br>V:GDapi.obj<br>V:SWapi.obj<br>4 File(s) copied<br><br>V:\gdal\frmts>cd hdf5 && nmake /nologo /f makefile.vc && cd .. || exit 1<br> cl /Zi /Fd..\..\gdal_w64.pdb /nologo /MD /EHsc /FC /D_CRT_SECURE_NO_DEPRECATE /D_CRT_NONSTDC_NO_DEPRECATE /DDEBUG /W4 /wd4127 /wd4251 /wd4275 /wd4786 /wd4100 /wd4245 /wd4206 /wd4018 /wd4389 /DHAVE_SSE_AT_COMPILE_TIME -I..\..\port -I..\..\ogr -I..\..\gcore -I..\..\alg -I..\..\ogr\ogrsf_frmts -I..\..\gnm -I..\..\gnm\gnm_frmts -I..\..\apps -IC:\programs\compa_libs\hdf5-1.8.12\compileds\VC12_64\include -DWIN32 -D_HDF5USEDLL_ -DOGR_ENABLED -DGDAL_COMPILATION /c hdf5dataset.cpp hdf5imagedataset.cpp bagdataset.cpp gh5_convenience.cpp iso19115_srs.cpp<br>hdf5dataset.cpp<br>c:\programs\compa_libs\hdf5-1.8.12\compileds\vc12_64\include\h5api_adpt.h(30) : warning C4005: '_HDF5USEDLL_' : macro redefinition<br> command-line arguments : see previous definition of '_HDF5USEDLL_'<br>v:\gdal\frmts\hdf5\hdf5dataset.cpp(1197) : warning C4244: '*=' : conversion from 'hsize_t' to 'unsigned int', possible loss of data<br>hdf5imagedataset.cpp<br>c:\programs\compa_libs\hdf5-1.8.12\compileds\vc12_64\include\h5api_adpt.h(30) : warning C4005: '_HDF5USEDLL_' : macro redefinition<br> command-line arguments : see previous definition of '_HDF5USEDLL_'<br>v:\gdal\frmts\hdf5\hdf5imagedataset.cpp(388) : warning C4267: '=' : conversion from 'size_t' to 'int', possible loss of data<br>bagdataset.cpp<br>c:\programs\compa_libs\hdf5-1.8.12\compileds\vc12_64\include\h5api_adpt.h(30) : warning C4005: '_HDF5USEDLL_' : macro redefinition<br> command-line arguments : see previous definition of '_HDF5USEDLL_'<br>v:\gdal\frmts\hdf5\bagdataset.cpp(314) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data<br>v:\gdal\frmts\hdf5\bagdataset.cpp(358) : warning C4244: 'initializing' : conversion from 'hsize_t' to 'int', possible loss of data<br>gh5_convenience.cpp<br>c:\programs\compa_libs\hdf5-1.8.12\compileds\vc12_64\include\h5api_adpt.h(30) : warning C4005: '_HDF5USEDLL_' : macro redefinition<br> command-line arguments : see previous definition of '_HDF5USEDLL_'<br>v:\gdal\frmts\hdf5\gh5_convenience.cpp(62) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data<br>iso19115_srs.cpp</div><div><br></div><div><br></div><blockquote style="margin: 0 0 0.80ex; border-left: #0000FF 2px solid; padding-left: 1ex"><div dir="ltr">Hi Joaquim,<div><br></div><div>Yes, MAX should work - that was what was originally in the code. I'm trying hard to get away from macros and such and get to the most robust code we can. I really want to find a way that we can use <a href="http://www.cplusplus.com/reference/algorithm/max/">std::max</a> which is the C++ way to get the maximum value. I'd like to get macro usage down as far as possible in the C++ and only use them in pure C code. There are limits, but std::max shouldn't be one of them. Any help would be greatly appreciated.</div><div><br></div><div>Thanks!</div><div>-kurt</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 13, 2015 at 11:28 AM, Joaquim Luis <span dir="ltr"><<a href="mailto:jluis@ualg.pt" target="_blank">jluis@ualg.pt</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>Hi Kurt,</div><div><br></div><div>I'll update but later. Now I have to go. Meanwhile I had replaced std::max by MAX and it passed that point.</div><div><div class="h5"><div><br></div><div><br></div><div><br></div><blockquote style="margin:0 0 0.80ex;border-left:#0000ff 2px solid;padding-left:1ex"><div dir="ltr">Hi Joaquim,<div><br></div><div>I broke the build with <a href="https://trac.osgeo.org/gdal/changeset/31403/" target="_blank">https://trac.osgeo.org/gdal/changeset/31403/</a>. Even created a ticket: <a href="https://trac.osgeo.org/gdal/ticket/6212" target="_blank">https://trac.osgeo.org/gdal/ticket/6212</a> and I added your error message to the ticket.</div><div><br></div><div><a href="http://build.gisinternals.com/sdk/Default.aspx" target="_blank">http://build.gisinternals.com/sdk/Default.aspx</a> has been down, so it's been tough to see what is happening.<br></div><div><br></div><div>It looks like with my latest fix that the max macro is indeed gone, but now it looks like you are hitting trouble with C++11. I've just submitted <a href="https://trac.osgeo.org/gdal/changeset/31463" target="_blank">https://trac.osgeo.org/gdal/changeset/31463</a> which might fix the issue. Can you do a svn update, try again and let me know what you get?</div><div><br></div><div>Thanks,</div><div>-kurt</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 13, 2015 at 10:46 AM, Joaquim Luis <span dir="ltr"><<a href="mailto:jluis@ualg.pt" target="_blank">jluis@ualg.pt</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The error is<br>
<br>
v:\gdal\frmts\hdf4\hdf4imagedataset.cpp(2386) : error C2784: '_Ty std::max(std::initializer_list<_Elem>,_Pr)' : could not deduce template argument for 'std::initializer_list<_Elem>' from 'int'<br>
c:\program files (x86)\microsoft visual studio 12.0\vc\include\algorithm(4108) : see declaration of 'std::max'<br>
<br>
Joaquim<br>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>--<div><a href="http://schwehr.org" target="_blank">http://schwehr.org</a></div></div>
</div>
</blockquote><br><br><br></div></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">--<div><a href="http://schwehr.org" target="_blank">http://schwehr.org</a></div></div>
</div>
</blockquote><br><br><br></body></html>