<div dir="ltr">I didn't see any objections, so I'm going to go ahead and start removing the option and the #if cpp stuff.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 17, 2016 at 10:55 AM, Dmitry Baryshnikov <span dir="ltr"><<a href="mailto:bishop.dev@gmail.com" target="_blank">bishop.dev@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Hi Kurt, <br>
<br>
I think, that it's time to do this.<br>
<pre cols="72">Best regards,
Dmitry</pre>
<div>17.03.2016 19:19, Kurt Schwehr пишет:<br>
</div><div><div class="h5">
<blockquote type="cite">
<div dir="ltr">I propose that we remove --without-ogr and
OGR_ENABLED. Happy to hear arguments for the contrary. I
commented here:
<div><br>
</div>
<div><a href="https://trac.osgeo.org/gdal/ticket/6117" target="_blank">https://trac.osgeo.org/gdal/ticket/6117</a><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Jun 23, 2015 at 9:14 AM, Even
Rouault <span dir="ltr"><<a href="mailto:even.rouault@spatialys.com" target="_blank">even.rouault@spatialys.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Kor,<br>
<br>
I'm half surprised this ended up being broken. At the time
of<br>
<a href="https://trac.osgeo.org/gdal/wiki/rfc46_gdal_ogr_unification" rel="noreferrer" target="_blank">https://trac.osgeo.org/gdal/wiki/rfc46_gdal_ogr_unification</a>,
it still worked<br>
apparently but I might have accidentaly broken it later.<br>
<br>
Anyway I was wondering if it was worth fixing that? as it
might be a continuing<br>
maintenance pain... This was something I actually considered
during RFC 46 (I<br>
mean dropping support for --without-ogr).<br>
<br>
Even<br>
<br>
> Dear all,<br>
><br>
> I may have found an issue in the build scripts of gdal
2.0.0. Building<br>
> gdal without ogr on Linux fails on my machine:<br>
><br>
> ./configure --without-ogr<br>
> make -j8<br>
><br>
> I attached the output of configure and copied the
snippets from the<br>
> build output detailing the errors below.<br>
><br>
> When I change --without-ogr into --with-ogr, the build
succeeds.<br>
><br>
> Maybe something OGR-ish is building while it
shouldn't(?).<br>
><br>
> Best regards,<br>
> Kor de Jong<br>
><br>
><br>
><br>
><br>
> libtool: compile: /opt/gcc-4.9/bin/g++
-I/tmp/blah/gdal-2.0.0/port<br>
> -I/tmp/blah/gdal-2.0.0/gcore -I/tmp/blah/gdal-2.0.0/alg<br>
> -I/tmp/blah/gdal-2.0.0/ogr
-I/tmp/blah/gdal-2.0.0/ogr/ogrsf_frmts -g -O2<br>
> -Wall -I/tmp/blah/gdal-2.0.0/port -I/usr/include
-DGDAL_COMPILATION -c<br>
> mffdataset.cpp -o ../o/mffdataset.o >/dev/null
2>&1<br>
> ogrutils.cpp: In function ‘int
OGRGeneralCmdLineProcessor(int, char***,<br>
> int)’:<br>
> ogrutils.cpp:526:60: error: ‘GDAL_OF_VECTOR’ was not
declared in this scope<br>
> return GDALGeneralCmdLineProcessor( nArgc,
ppapszArgv,<br>
> GDAL_OF_VECTOR );<br>
>
^<br>
> ogrutils.cpp:526:75: error:
‘GDALGeneralCmdLineProcessor’ was not<br>
> declared in this scope<br>
> return GDALGeneralCmdLineProcessor( nArgc,
ppapszArgv,<br>
> GDAL_OF_VECTOR );<br>
><br>
> ^<br>
> ogrutils.cpp:527:1: warning: control reaches end of
non-void function<br>
> [-Wreturn-type]<br>
> }<br>
> ^<br>
> make[1]: *** [ogrutils.lo] Error 1<br>
> make[1]: *** Waiting for unfinished jobs....<br>
><br>
><br>
><br>
><br>
><br>
> pdfwritabledataset.cpp: In member function ‘virtual
OGRErr<br>
> PDFWritableVectorDataset::SyncToDisk()’:<br>
> pdfwritabledataset.cpp:307:17: error: ‘class
GDALPDFWriter’ has no<br>
> member named ‘WriteOGRLayer’<br>
> oWriter.WriteOGRLayer((OGRDataSourceH)this,<br>
> ^<br>
> make[2]: *** [../o/pdfwritabledataset.lo] Error 1<br>
> make[2]: *** Waiting for unfinished jobs....<br>
><br>
><br>
><br>
> make[1]: *** [pdf-install-obj] Error 2<br>
> make[1]: *** Waiting for unfinished jobs....<br>
> make: *** [frmts-target] Error 2<br>
<span><font color="#888888"><br>
--<br>
Spatialys - Geospatial professional services<br>
<a href="http://www.spatialys.com" rel="noreferrer" target="_blank">http://www.spatialys.com</a><br>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a></font></span></blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div>--
<div><a href="http://schwehr.org" target="_blank">http://schwehr.org</a></div>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
gdal-dev mailing list
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a>
<a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a></pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">--<div><a href="http://schwehr.org" target="_blank">http://schwehr.org</a></div></div>
</div>