<div dir="ltr"><div><div><div><div>Hello Dmitry,<br><br></div>Thank you for your feedback. I will look into all the files in libpng once again.<br><br></div>About the python support - I think I found the problem, I guess that when I was downloading the source, due to poor net at the time a few files didn't get through. So now I'm downloading again, and I'll let you know if there are any more issues.<br><br></div>Cheers<br></div>Tanuj<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 22, 2016 at 1:33 AM, Dmitry Baryshnikov <span dir="ltr"><<a href="mailto:bishop.dev@gmail.com" target="_blank">bishop.dev@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    Hi Tanuj,<br>
    <br>
    I compare current libpng folder and previous one:<br>
    1. You include a lot of files needed to build standalone library,
    but not need in GDAL sources tree (like configure, CMakeLists.txt,
    etc.). <br>
    2. The <a href="http://makefile.vc" target="_blank">makefile.vc</a> removed and it seems to me the windows build will
    fail in that case.<br>
    3. There was a libpng_gdal.patch file, are you sure that this file
    is not necessary?<br>
    4. You included several files need for libpng unit testing, but not
    needed by GDAL. According to GNUMakefile in png folder, it get all
    *.c files from libpng folder, so we need minimum set of *.c and *.h
    files there (but enough for VC building too).<br>
    <br>
    About python support - do you did sudo make install (Linux)? The
    only building is not enough to have python bindings work (there is a
    tick with PYTHONPATH, but not sure that it works. <br>
    <pre cols="72">Best regards,
    Dmitry</pre>
    <div>20.03.2016 10:15, Tanuj Kumar пишет:<br>
    </div><div><div class="h5">
    <blockquote type="cite">
      <div dir="ltr">
        <div>
          <div>
            <div>
              <div>
                <div>
                  <div>Hello Dmitry,<br>
                  </div>
                  Sorry for the long delay, my exams had the better of
                  me, but now they're over :) .<br>
                </div>
                I have updated libpng 1.6.21 and i have created a pull
                request after removing files from original libpng 1.6.21
                that I think would not be required as a library in GDAL.<br>
              </div>
              All test on travis have been passed, and you can see the
              pull request here : <a href="https://github.com/OSGeo/gdal/pull/108" target="_blank">https://github.com/OSGeo/gdal/pull/108</a><br>
              <br>
            </div>
            As for building on desktop, I configured with python, but
            the same issue of "ImportError: No module named osgeo
            persists". I am trying to understand why this is happening,
            and am working out how to get rid of this problem by reading
            GDAL wiki.<br>
            <br>
          </div>
          Cheers<br>
        </div>
        Tanuj<br>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Tue, Mar 15, 2016 at 1:24 AM, Dmitry
          Baryshnikov <span dir="ltr"><<a href="mailto:bishop.dev@gmail.com" target="_blank">bishop.dev@gmail.com</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div text="#000000" bgcolor="#FFFFFF"> Hi Tanuj,<br>
              <br>
              The error: ImportError: No module named osgeo <br>
              is because you build gdal without python support (you need
              python with developers headers). <br>
              On Linux Linux this is done via such command:<br>
              ./configure --with-python ... <other config options><br>
              <br>
              On Windows it depends how you build. On Windows I launch
              separate tests successfully but never try the whole tests
              (run_all.py).<br>
              <pre cols="72">Best regards,
    Dmitry</pre>
              <div>14.03.2016 19:11, Tanuj Kumar пишет:<br>
              </div>
              <div>
                <div>
                  <blockquote type="cite">
                    <div dir="ltr">Hello Dmitry,
                      <div>I was reading up on the gdalautotest wiki(<a href="http://trac.osgeo.org/gdal/wiki/TestingNotes" target="_blank"></a><a href="http://trac.osgeo.org/gdal/wiki/TestingNotes" target="_blank">http://trac.osgeo.org/gdal/wiki/TestingNotes</a>),

                        and it says, "<span>After building with either
                          the old or new generation python bindings, and
                          installing them (or adding them to your path
                          from the build tree)..."</span></div>
                      <div><span><br>
                        </span></div>
                      <div>I could not understand what that means. I
                        guess this is important because when I tried the
                        commands given on that page, I got the following
                        error :<br>
                        <br>
                      </div>
                      <div>File "./run_all.py", line 37, in
                        <module></div>
                      <div>import gdaltest</div>
                      <div>File"pymod/gdaltest.py", line 37, in
                        <module></div>
                      <div>from osgeo import gdal</div>
                      <div>ImportError: No module named osgeo<br>
                        <br>
                        <br>
                      </div>
                      <div>Now, as far as I could understand, it is
                        importing a file called "gdal.py" from a folder
                        called osgeo. I searched for it, and got its
                        path as "gdal/swig/python/osgeo, whereas the
                        autotest folder is separate.<br>
                      </div>
                      <div>So my guess is I have to somehow specify the
                        path of "gdal.py"<br>
                      </div>
                      <div><br>
                      </div>
                      <div>Could you or anyone please guide me on how to
                        proceed with this?<br>
                        <br>
                      </div>
                      <div>Thanks<br>
                      </div>
                      <div>Tanuj<br>
                      </div>
                    </div>
                    <div class="gmail_extra"><br>
                      <div class="gmail_quote">On Sat, Mar 12, 2016 at
                        11:00 PM, Tanuj Kumar <span dir="ltr"><<a href="mailto:kmrtnjscnc@gmail.com" target="_blank"></a><a href="mailto:kmrtnjscnc@gmail.com" target="_blank">kmrtnjscnc@gmail.com</a>></span>
                        wrote:<br>
                        <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                          <div dir="ltr">Alright, thank you very much,
                            I'll get to work on it!</div>
                          <div>
                            <div>
                              <div class="gmail_extra"><br>
                                <div class="gmail_quote">On Sat, Mar 12,
                                  2016 at 10:47 PM, Dmitry Baryshnikov <span dir="ltr"><<a href="mailto:bishop.dev@gmail.com" target="_blank"></a><a href="mailto:bishop.dev@gmail.com" target="_blank">bishop.dev@gmail.com</a>></span>
                                  wrote:<br>
                                  <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                                    <div text="#000000" bgcolor="#FFFFFF"> Hi Tanuj,<br>
                                      <br>
                                      I wrote a big letter to the list.
                                      There is some answers there. Also
                                      I add comments below.<br>
                                      <pre cols="72">Best regards,
    Dmitry</pre>
                                      <div>12.03.2016 10:36, Tanuj Kumar
                                        пишет:<br>
                                      </div>
                                      <span>
                                        <blockquote type="cite">
                                          <div dir="ltr">
                                            <div>
                                              <div>
                                                <div>
                                                  <div>
                                                    <div>Sorry for
                                                      replying so late,
                                                      got caught up in
                                                      an exam :)<br>
                                                      <br>
                                                    </div>
                                                    I replaced libpng
                                                    folder of gdal
                                                    (frmts/png/libpng)
                                                    with libpng 1.6.21.
                                                    And then used
                                                    ./configure and make
                                                    install on this test
                                                    version of gdal,
                                                    which installed
                                                    successfully. I used
                                                    gdalinfo on a png
                                                    file provided with
                                                    the libpng 1.6.21
                                                    source, to check if
                                                    it was OK, and it
                                                    successfully gave
                                                    the png file
                                                    details.<br>
                                                    <br>
                                                  </div>
                                                  <div>Is that enough to
                                                    check the build on
                                                    the computer?<br>
                                                  </div>
                                                </div>
                                              </div>
                                            </div>
                                          </div>
                                        </blockquote>
                                      </span> No, the autotests must be
                                      passed.<span><br>
                                        <blockquote type="cite">
                                          <div dir="ltr">
                                            <div>
                                              <div>
                                                <div>
                                                  <div><br>
                                                  </div>
                                                  <div>I have also
                                                    tested the gdal
                                                    library with libpng
                                                    1.6.21 on Travis,
                                                    and the build
                                                    succeeded.<br>
                                                    <a href="https://travis-ci.org/Raeburn1687/gdal/builds/115487530" target="_blank"></a><a href="https://travis-ci.org/Raeburn1687/gdal/builds/115487530" target="_blank">https://travis-ci.org/Raeburn1687/gdal/builds/115487530</a><br>
                                                    <br>
                                                  </div>
                                                  <div>Would all that be
                                                    enough to check
                                                    whether the update
                                                    was succesful?<br>
                                                  </div>
                                                </div>
                                              </div>
                                            </div>
                                          </div>
                                        </blockquote>
                                      </span> I expected that travis
                                      from main gdal repo checked your
                                      PR.<span><br>
                                        <blockquote type="cite">
                                          <div dir="ltr">
                                            <div>
                                              <div>
                                                <div><br>
                                                  PS - Although I have
                                                  copied the files from
                                                  libpng 1.6.21 source
                                                  to the gdal libpng
                                                  folder, how would I
                                                  know if any of those
                                                  files are not required
                                                  for gdal?<br>
                                                </div>
                                                <br>
                                              </div>
                                            </div>
                                          </div>
                                        </blockquote>
                                      </span> You need to see the
                                      previous version. Some files not
                                      needed (i.e. configures and so on,
                                      which already comes from gdal, but
                                      legal notice must be present
                                      (license, autors, etc.) ). Don't
                                      hesitate to ask in list.
                                      <div>
                                        <div><br>
                                          <br>
                                          <blockquote type="cite">
                                            <div dir="ltr">
                                              <div>Thank you<br>
                                                <br>
                                              </div>
                                              Tanuj<br>
                                            </div>
                                            <div class="gmail_extra"><br>
                                              <div class="gmail_quote">On
                                                Thu, Mar 10, 2016 at
                                                2:07 PM, Dmitry
                                                Baryshnikov <span dir="ltr"><<a href="mailto:bishop.dev@gmail.com" target="_blank"></a><a href="mailto:bishop.dev@gmail.com" target="_blank">bishop.dev@gmail.com</a>></span>
                                                wrote:<br>
                                                <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                                                  <div text="#000000" bgcolor="#FFFFFF">
                                                    Hi Tanuj,
                                                    <div>09.03.2016
                                                      13:17, Tanuj Kumar
                                                      пишет:<br>
                                                    </div>
                                                    <span>
                                                      <blockquote type="cite">
                                                        <div dir="ltr">
                                                          <div>
                                                          <div>
                                                          <div>
                                                          <div>
                                                          <div>Yes, I
                                                          have looked at
                                                          the ideas
                                                          list, and I am
                                                          currently
                                                          reading up on
                                                          idea no. 16,
                                                          which is,
                                                          implementing
                                                          support for
                                                          the proposed
                                                          standard for
                                                          incrementally
                                                          parseable
                                                          GeoJSON data.<br>
                                                          <br>
                                                          </div>
                                                          Also, I was
                                                          thinking that
                                                          maybe I could
                                                          work on ticket
                                                          no 6294, <a href="https://trac.osgeo.org/gdal/ticket/6294" target="_blank"></a><a href="https://trac.osgeo.org/gdal/ticket/6294" target="_blank">https://trac.osgeo.org/gdal/ticket/6294</a><br>
                                                          </div>
                                                          after I've
                                                          studied about
                                                          the GSoC idea,
                                                          which is not
                                                          really a bug,
                                                          but an
                                                          enhancement.
                                                          But if there
                                                          are any other
                                                          tickets that
                                                          you or anyone
                                                          else would
                                                          like to
                                                          recommend me
                                                          to work on,
                                                          I'd love to
                                                          see them too!<br>
                                                          </div>
                                                          </div>
                                                          </div>
                                                        </div>
                                                      </blockquote>
                                                    </span> I think this
                                                    rather arguing
                                                    ticket as the bool
                                                    is not exist in
                                                    plain C, and
                                                    duplication
                                                    functions seems to
                                                    me not good idea.<br>
                                                    I think this ticket
                                                    <a href="https://trac.osgeo.org/gdal/ticket/6185" target="_blank"></a><a href="https://trac.osgeo.org/gdal/ticket/6185" target="_blank">https://trac.osgeo.org/gdal/ticket/6185</a>
                                                    is good for: 1.
                                                    building GDAL, 2.
                                                    Testing via TraviC
                                                    on GitHub. By the
                                                    way the libpng
                                                    version is 1.6.21 or
                                                    maybe higher.<br>
                                                    <br>
                                                    Anyhow, you have to
                                                    try to build gdal
                                                    and test it with
                                                    autotests from <span lang="en"><span>appropriate</span></span>
                                                    folder. <span>
                                                      <blockquote type="cite">
                                                        <div dir="ltr">
                                                          <div>
                                                          <div>
                                                          <div><br>
                                                          </div>
                                                          Now, about the
                                                          GSoC idea, do
                                                          I need to know
                                                          JSON( or
                                                          GeoJSON, for
                                                          that matter)
                                                          to work on it?
                                                          I only ask
                                                          because the
                                                          idea lists
                                                          C/C++ as the
                                                          required
                                                          skills, but I
                                                          feel that
                                                          maybe this
                                                          work would
                                                          involve
                                                          knowing JSON
                                                          too...<br>
                                                          </div>
                                                          </div>
                                                        </div>
                                                      </blockquote>
                                                    </span> Yes,
                                                    certainly. But JSON
                                                    are very simple.
                                                    Also GeoJSON spec.
                                                    can be found here <a href="http://geojson.org/" target="_blank"></a><a href="http://geojson.org/" target="_blank">http://geojson.org/</a>Thanks


                                                    and regards,
                                                    <div>
                                                      <div><br>
                                                        <blockquote type="cite">
                                                          <div dir="ltr">
                                                          <div> <br>
                                                          </div>
                                                          Tanuj<br>
                                                          <div>
                                                          <div>
                                                          <div>
                                                          <div>
                                                          <div><br>
                                                          </div>
                                                          </div>
                                                          </div>
                                                          </div>
                                                          </div>
                                                          </div>
                                                          <div class="gmail_extra"><br>
                                                          <div class="gmail_quote">On

                                                          Wed, Mar 9,
                                                          2016 at 2:58
                                                          PM, Dmitry
                                                          Baryshnikov <span dir="ltr"><<a href="mailto:bishop.dev@gmail.com" target="_blank"></a><a href="mailto:bishop.dev@gmail.com" target="_blank">bishop.dev@gmail.com</a>></span>
                                                          wrote:<br>
                                                          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                                                          <div text="#000000" bgcolor="#FFFFFF"> Hi, Tanuj<br>
                                                          <br>
                                                          I'll look for
                                                          opened tickets
                                                          for you, or
                                                          maybe others
                                                          can recommend
                                                          some for you.<br>
                                                          <br>
                                                          By the way, do
                                                          you see the
                                                          idea list (<a href="https://trac.osgeo.org/gdal/wiki/SummerOfCode#a2016IdeasList" target="_blank"></a><a href="https://trac.osgeo.org/gdal/wiki/SummerOfCode#a2016IdeasList" target="_blank">https://trac.osgeo.org/gdal/wiki/SummerOfCode#a2016IdeasList</a>)?




                                                          <br>
                                                          The ideas are
                                                          not ranked yet
                                                          - the numbers
                                                          in the list -
                                                          are only in
                                                          order. <br>
                                                          This is a task
                                                          for us to rank
                                                          the ideas. <br>
                                                          But, have you
                                                          some
                                                          preferable
                                                          idea (or
                                                          ideas) for
                                                          GSoC from this
                                                          list or maybe
                                                          you have got
                                                          own?<br>
                                                          <br>
                                                          <pre cols="72">Best regards,
    Dmitry</pre>
                                                          <div>04.03.2016

                                                          16:11, Tanuj
                                                          Kumar пишет:<br>
                                                          </div>
                                                          <blockquote type="cite">
                                                          <div>
                                                          <div>
                                                          <div dir="ltr">
                                                          <div>
                                                          <div>
                                                          <div>
                                                          <div>Hello,<br>
                                                          </div>
                                                          I am
                                                          interested in
                                                          applying for
                                                          GSoC this
                                                          year.
                                                          Currently, I
                                                          am reading up
                                                          on the GDAL
                                                          Summer of Code
                                                          ideas list. I
                                                          know C++ and
                                                          C, and I have
                                                          some
                                                          experience on
                                                          working on
                                                          linux.<br>
                                                          </div>
                                                          Could the
                                                          mentors please
                                                          recommend a
                                                          bug for me to
                                                          work on, I'd
                                                          really love to
                                                          start off as
                                                          soon as
                                                          possible!<br>
                                                          <br>
                                                          </div>
                                                          Thank you,<br>
                                                          </div>
                                                          <div><br>
                                                          </div>
                                                          Tanuj Kumar<br>
                                                          <span><font color="#888888">Birla


                                                          institute of
                                                          Technology and
                                                          Science<br>
                                                          </font></span><span><font color="#888888">Pilani, Rajasthan,<br>
                                                          </font></span><span><font color="#888888">India</font></span><br>
                                                          </div>
                                                          <br>
                                                          <fieldset></fieldset>
                                                          <br>
                                                          </div>
                                                          </div>
                                                          <pre>_______________________________________________
gdal-dev mailing list
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a>
<a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a></pre>
                                                          </blockquote>
                                                          <br>
                                                          </div>
                                                          <br>
_______________________________________________<br>
                                                          gdal-dev
                                                          mailing list<br>
                                                          <a href="mailto:gdal-dev@lists.osgeo.org" target="_blank"></a><a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
                                                          <a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank"></a><a href="http://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
                                                          </blockquote>
                                                          </div>
                                                          <br>
                                                          </div>
                                                        </blockquote>
                                                        <br>
                                                      </div>
                                                    </div>
                                                    <pre cols="72">Best regards,
    Dmitry</pre>
                                                  </div>
                                                </blockquote>
                                              </div>
                                              <br>
                                            </div>
                                          </blockquote>
                                          <br>
                                        </div>
                                      </div>
                                    </div>
                                  </blockquote>
                                </div>
                                <br>
                              </div>
                            </div>
                          </div>
                        </blockquote>
                      </div>
                      <br>
                    </div>
                  </blockquote>
                  <br>
                </div>
              </div>
            </div>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
  </div></div></div>

</blockquote></div><br></div>