<div dir="ltr">Dmitry,<div><br></div><div>Thank you for doing <a href="https://trac.osgeo.org/gdal/changeset/41095">https://trac.osgeo.org/gdal/changeset/41095</a></div><div><br></div><div>Sorry, I didn't know about the pull request. I get spammed by github notifications and have yet to figure out how make the 99.99% I don't care about go away. :|</div><div><br></div><div>I think commits should always reference relevant issues and pull requests. The commit message here <a href="https://trac.osgeo.org/gdal/changeset/41086">https://trac.osgeo.org/gdal/changeset/41086</a> was not particularly useful. In reading that patch, I assumed that this was a code brand new to GDAL. I filter out the changes for drivers that I don't use and the diffs never go through my repo (0.8M lines locally versus 1.8M in svn). The description for r41085 never mentions migrating code from wms to port or the pr.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 20, 2017 at 1:58 PM, Dmitry Baryshnikov <span dir="ltr"><<a href="mailto:bishop.dev@gmail.com" target="_blank">bishop.dev@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Hi Ari,</p>
<p>The pull request and discussion can be found here:
<a class="m_-8462408375501910622moz-txt-link-freetext" href="https://github.com/OSGeo/gdal/pull/280" target="_blank">https://github.com/OSGeo/gdal/<wbr>pull/280</a></p>
<p>I cannot imagine that this improvements will affect something
else. MD5 used for cache paths initially, I only added some
improvements for WMS cache size limits, expire time and split
cache per dataset base (i.e. to delete cached files when dataset
deletes).<br>
</p>
<p>What about your idea about common caching classes/functions -
this is topic to discuss. <br>
</p>
<pre class="m_-8462408375501910622moz-signature" cols="72">Best regards,
Dmitry</pre>
<div class="m_-8462408375501910622moz-cite-prefix">21.12.2017 0:32, Ari Jolma пишет:<br>
</div>
<blockquote type="cite"><span class="">My
comments on this:
<br>
<br>
1) The MD5 function seems to be needed only(?) for the WMS cache
and probably also WFS. To me that highlights the need for some
integration work regarding caching in GDAL. I also implemented yet
another caching code for the WCS (without MD5). Looking at my
$HOME/.gdal I see also gmlas_xsd_cache and srs_cache.
<br>
<br>
2) This discussion thread also highlights the need to go towards
more pull request style development at least for bigger changes.
<br>
<br>
Ari
<br>
<br>
<br>
Kurt Schwehr kirjoitti 21.12.2017 klo 02:56:
<br>
</span><blockquote type="cite"><span class="">Dmitry,
<br>
<br>
Statements like this indicate a world of trouble:
<br>
<br>
> I'm not sure that Python produce the same hash than
cvs_MD5*.
<br>
> Also I'm not sure what in future they will be the same.
<br>
<br>
If you remove the swig and python stuff, move the CPLMD5String
to cpl_md5.{cpp,h}, and follow Even's suggestions, I will be
much happier with the change. A C++ test would be good too.
I'll be happy to do a quick fix up of a few things that I see in
the md5 code once it is to that point. I do think it is a good
thing that there be md5 support in port along with the existing
sha{1,256} code.
<br>
<br>
I see what you are saying about
the OGRGeometry::exportTo{<wbr>json,kml,gml}, but that doesn't (to
me) support your argument. My personal opinion is that GDAL
would have been stronger if those had separate and not been a
part of OGRGeometry.
<br>
<br>
If there is a critical difference between CPLMD5String or a
language and use case where md5 support in that language from
GDAL is really required, you need to first document that issue.
<br>
<br></span><span class="">
On Wed, Dec 20, 2017 at 7:46 AM, Dmitry Baryshnikov
<<a class="m_-8462408375501910622moz-txt-link-abbreviated" href="mailto:bishop.dev@gmail.com" target="_blank">bishop.dev@gmail.com</a> <a class="m_-8462408375501910622moz-txt-link-rfc2396E" href="mailto:bishop.dev@gmail.com" target="_blank"><mailto:bishop.dev@gmail.com></a>>
wrote:
<br>
<br>
Just the note that CPLMD5String not only for Python, but any
other
<br>
API clients: C/C++, Java, Perl, etc.
<br>
<br>
But, I agree, it can be easily removed.
<br>
<br>
Best regards,
<br>
Dmitry
<br>
<br></span>
20.12.2017 18 <a class="m_-8462408375501910622moz-txt-link-rfc2396E" href="tel:20.12.2017%2018" target="_blank"><tel:20.12.2017%2018></a>:35, Even Rouault
пишет:
<br><span class="">
<br>
And why are you exposing this to python? Python
has
<br>
md5 hashing
<br>
<br>
already
<br>
<br>
built in.
<br>
<br>
I'm not sure that Python produce the same hash than
cvs_MD5*.
<br>
<br>
I do hope they return the same thing. MD5 is a
standardized
<br>
algorithm:
<br>
<a class="m_-8462408375501910622moz-txt-link-freetext" href="https://tools.ietf.org/html/rfc1321" target="_blank">https://tools.ietf.org/html/<wbr>rfc1321</a>
<br>
<a class="m_-8462408375501910622moz-txt-link-rfc2396E" href="https://tools.ietf.org/html/rfc1321" target="_blank"><https://tools.ietf.org/html/<wbr>rfc1321></a>
<br>
<br>
I'm not sure we really need to expose it our CPL MD5
through
<br>
Python.
<br>
<br>
<br>
______________________________<wbr>_________________
<br>
gdal-dev mailing list
<br></span>
<a class="m_-8462408375501910622moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a>
<a class="m_-8462408375501910622moz-txt-link-rfc2396E" href="mailto:gdal-dev@lists.osgeo.org" target="_blank"><mailto:gdal-dev@lists.osgeo.<wbr>org></a>
<br>
<a class="m_-8462408375501910622moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/gdal-dev</a>
<br><span class="">
<a class="m_-8462408375501910622moz-txt-link-rfc2396E" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank"><https://lists.osgeo.org/<wbr>mailman/listinfo/gdal-dev></a>
<br>
<br>
<br>
<br>
<br>
-- <br>
-- <br>
<a class="m_-8462408375501910622moz-txt-link-freetext" href="http://schwehr.org" target="_blank">http://schwehr.org</a>
<br>
<br>
<br>
______________________________<wbr>_________________
<br>
gdal-dev mailing list
<br>
<a class="m_-8462408375501910622moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a>
<br>
<a class="m_-8462408375501910622moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/gdal-dev</a>
<br>
</span></blockquote><span class="">
<br>
<br>
<br>
<fieldset class="m_-8462408375501910622mimeAttachmentHeader"></fieldset>
<br>
<pre>______________________________<wbr>_________________
gdal-dev mailing list
<a class="m_-8462408375501910622moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a>
<a class="m_-8462408375501910622moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/gdal-dev</a></pre>
</span></blockquote>
<br>
</div>
<br>______________________________<wbr>_________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/gdal-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">--<div><a href="http://schwehr.org" target="_blank">http://schwehr.org</a></div></div>
</div>