<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>My comments on this:</p>
<p>1) The MD5 function seems to be needed only(?) for the WMS cache
and probably also WFS. To me that highlights the need for some
integration work regarding caching in GDAL. I also implemented yet
another caching code for the WCS (without MD5). Looking at my
$HOME/.gdal I see also gmlas_xsd_cache and srs_cache.</p>
<p>2) This discussion thread also highlights the need to go towards
more pull request style development at least for bigger changes. <br>
</p>
<p>Ari<br>
</p>
<br>
<div class="moz-cite-prefix">Kurt Schwehr kirjoitti 21.12.2017 klo
02:56:<br>
</div>
<blockquote type="cite"
cite="mid:CACmBxyvfkhNUo-qh8m7jUWXhb5JoKM_EVWxq-LWeXRm1N-Cstw@mail.gmail.com">
<div dir="ltr">Dmitry,
<div><br>
</div>
<div>Statements like this indicate a world of trouble:
<div><br>
</div>
<div>> <span style="font-size:12.8px">I'm not sure that
Python produce the same hash than cvs_MD5*.</span></div>
<span style="font-size:12.8px">> Also I'm not sure what in
future they will be the same.</span><br
style="font-size:12.8px">
<div><br>
</div>
<div>If you remove the swig and python stuff, move the <span
style="font-size:12.8px">CPLMD5String to cpl_md5.{cpp,h},
and follow Even's suggestions, I will be much happier with
the change. A C++ test would be good too. I'll be happy
to do a quick fix up of a few things that I see in the md5
code once it is to that point. I do think it is a good
thing that there be md5 support in port along with the
existing sha{1,256} code.</span></div>
<div><br>
</div>
<div>I see what you are saying about
the OGRGeometry::exportTo{json,kml,gml}, but that doesn't
(to me) support your argument. My personal opinion is that
GDAL would have been stronger if those had separate and not
been a part of OGRGeometry.<br>
</div>
</div>
<div><br>
</div>
<div><span style="font-size:12.8px">If there is a critical
difference between </span><span style="font-size:12.8px">CPLMD5String
or a language and use case where md5 support in that
language from GDAL is really required, you need to first
document that issue.</span></div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Dec 20, 2017 at 7:46 AM, Dmitry
Baryshnikov <span dir="ltr"><<a
href="mailto:bishop.dev@gmail.com" target="_blank"
moz-do-not-send="true">bishop.dev@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class="">Just the note that CPLMD5String not only for
Python, but any other API clients: C/C++, Java, Perl, etc.<br>
<br>
But, I agree, it can be easily removed.<br>
<br>
Best regards,<br>
Dmitry<br>
<br>
<a href="tel:20.12.2017%2018" value="+12012201718"
target="_blank" moz-do-not-send="true">20.12.2017 18</a>:35,
Even Rouault пишет:<br>
</span>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
And why are you exposing this to python? Python has
md5 hashing<br>
</blockquote>
</blockquote>
<span class="">
already<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
built in.<br>
</blockquote>
I'm not sure that Python produce the same hash than
cvs_MD5*.<br>
</blockquote>
I do hope they return the same thing. MD5 is a
standardized algorithm:<br>
<a href="https://tools.ietf.org/html/rfc1321"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://tools.ietf.org/html/rf<wbr>c1321</a><br>
<br>
I'm not sure we really need to expose it our CPL MD5
through Python.<br>
<br>
</span></blockquote>
<div class="HOEnZb">
<div class="h5">
<br>
______________________________<wbr>_________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org"
target="_blank" moz-do-not-send="true">gdal-dev@lists.osgeo.org</a><br>
<a
href="https://lists.osgeo.org/mailman/listinfo/gdal-dev"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://lists.osgeo.org/mailma<wbr>n/listinfo/gdal-dev</a></div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature" data-smartmail="gmail_signature">--
<div><a href="http://schwehr.org" target="_blank"
moz-do-not-send="true">http://schwehr.org</a></div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
gdal-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a></pre>
</blockquote>
<br>
</body>
</html>