<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.Shkpostityyli18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;}
span.Shkpostityyli19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;}
span.pl-c1
{mso-style-name:pl-c1;}
span.pl-s
{mso-style-name:pl-s;}
span.pl-pds
{mso-style-name:pl-pds;}
span.pl-k
{mso-style-name:pl-k;}
span.Shkpostityyli24
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 2.0cm 70.85pt 2.0cm;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="FI" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Thanks Brad, works after those edits and gives me an occasion to have a try with a pull request!<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">-Jukka-<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="mso-fareast-language:FI">Lähettäjä:</span></b><span style="mso-fareast-language:FI"> bradh@frogmouth.net [mailto:bradh@frogmouth.net]
<br>
<b>Lähetetty:</b> 29. marraskuuta 2018 11:43<br>
<b>Vastaanottaja:</b> Rahkonen Jukka (MML) <jukka.rahkonen@maanmittauslaitos.fi>; gdal-dev@lists.osgeo.org<br>
<b>Aihe:</b> RE: [gdal-dev] Issue with validate_gpkg.py<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-AU">Looks like (line 59)<br>
<span class="pl-c1">type</span>.startswith(<span class="pl-pds">'</span><span class="pl-s">TEXT(</span><span class="pl-pds">'</span>)
<span class="pl-k">or</span> <span class="pl-c1">type</span>.startswith(<span class="pl-pds">'</span><span class="pl-s">BLOB(</span><span class="pl-pds">'</span>)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-AU">Should be <o:p></o:p></span></p>
<p class="MsoNormal"><span class="pl-c1"><span lang="EN-AU">typ</span></span><span lang="EN-AU">.startswith(<span class="pl-pds">'</span><span class="pl-s">TEXT(</span><span class="pl-pds">'</span>)
<span class="pl-k">or</span> <span class="pl-c1">typ</span>.startswith(<span class="pl-pds">'</span><span class="pl-s">BLOB(</span><span class="pl-pds">'</span>)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-AU"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-AU">(i.e. remove the two “e” characters)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-AU"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-AU">Brad<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-AU"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="mso-fareast-language:EN-AU">From:</span></b><span lang="EN-US" style="mso-fareast-language:EN-AU"> gdal-dev <<a href="mailto:gdal-dev-bounces@lists.osgeo.org">gdal-dev-bounces@lists.osgeo.org</a>>
<b>On Behalf Of </b>Rahkonen Jukka (MML)<br>
<b>Sent:</b> Thursday, 29 November 2018 8:36 PM<br>
<b>To:</b> 'gdal-dev@lists.osgeo.org' (<a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a>) <<a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a>><br>
<b>Subject:</b> [gdal-dev] Issue with validate_gpkg.py<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-AU"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I try to run validate_gpkg.py that I downloaded today from GitHub. I run it under OSGeo4W installation on Windows, GDAL version GDAL 2.3.2, released 2018/09/21, and Python version Python 2.7.14.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Validation stops at this error message:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Traceback (most recent call last):<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> File "validate_gpkg.py", line 1611, in <module><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> verbose=verbose)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> File "validate_gpkg.py", line 1578, in check<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> checker.check()<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> File "validate_gpkg.py", line 1555, in check<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> self._check_features(c)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> File "validate_gpkg.py", line 596, in _check_features<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> self._check_vector_user_table(c, table_name)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> File "validate_gpkg.py", line 367, in _check_vector_user_table<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> self._assert(_is_valid_data_type(typ), 5,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> File "validate_gpkg.py", line 59, in _is_valid_data_type<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> type.startswith('TEXT(') or type.startswith('BLOB(')<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">AttributeError: type object 'type' has no attribute 'startswith'<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Is there something that a user can do for making the script to run?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">-Jukka Rahkonen-<o:p></o:p></span></p>
</div>
</body>
</html>