<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Hi,
<blockquote type="cite"
cite="mid:AM0PR02MB5777368BAAABDE84DC38EF9493FE9@AM0PR02MB5777.eurprd02.prod.outlook.com">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US"> Can you point us to an
example of a GDAL plugin that is offered as download from a
GDAL external website?</span></p>
</div>
</blockquote>
See <a class="moz-txt-link-freetext" href="https://github.com/OSGeo/gdal/pull/3447#issuecomment-776819142">https://github.com/OSGeo/gdal/pull/3447#issuecomment-776819142</a><br>
<blockquote type="cite"
cite="mid:AM0PR02MB5777368BAAABDE84DC38EF9493FE9@AM0PR02MB5777.eurprd02.prod.outlook.com">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US"> This might be an
option, but we would prefer contributing directly to GDAL,
of course. Maintaining binary plugin versions externally for
all the relevant versions/platforms/compilers will probably
be difficult.</span></p>
</div>
</blockquote>
For the platforms/compilers part, you already need to do that to
provide the binaries of the ODBC driver. Adding GDAL versions (GDAL
driver ABI generally changes at feature versions) of course would
add an extra dimension to this.<br>
<blockquote type="cite"
cite="mid:AM0PR02MB5777368BAAABDE84DC38EF9493FE9@AM0PR02MB5777.eurprd02.prod.outlook.com">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US"> Would it be sufficient
if the OGR SAP HANA driver is reviewed by members of our
team? And if that’s not sufficient, what options do we have
to find someone who is qualified to do the final review?</span></p>
</div>
</blockquote>
<p>Ultimately you need to find someone who has merge rights to be
enthusiastic enough to press the merge button. Either because
he/she has reviewed itself the code (because he/she's interested
naturally in the work, or you find compelling ways of making
him/her interested in it) and is happy to see his name in the
merge commit, or he/she trusts someone else who has done the
review. <br>
</p>
<p>I'm interested if other PSC members have an opinion if this
should rather be proposed as a in-tree driver or out-of-tree one.<br>
</p>
<p>Even<br>
</p>
<blockquote type="cite"
cite="mid:AM0PR02MB5777368BAAABDE84DC38EF9493FE9@AM0PR02MB5777.eurprd02.prod.outlook.com">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US"> </span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks, and best
regards,</span></p>
<p class="MsoNormal"><span lang="EN-US">Stefan</span><span></span></p>
<p class="MsoNormal"><span> </span></p>
<div>
<div>
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span
lang="EN-US"> gdal-dev
<a class="moz-txt-link-rfc2396E" href="mailto:gdal-dev-bounces@lists.osgeo.org"><gdal-dev-bounces@lists.osgeo.org></a>
<b>On Behalf Of </b>Even Rouault<br>
<b>Sent:</b> Friday, August 13, 2021 7:31 PM<br>
<b>To:</b> Rylov, Maxim <a class="moz-txt-link-rfc2396E" href="mailto:maxim.rylov@sap.com"><maxim.rylov@sap.com></a>;
<a class="moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a><br>
<b>Subject:</b> Re: [gdal-dev] HANA driver proposal</span></p>
</div>
</div>
<p class="MsoNormal"> </p>
<p>Maxim,</p>
<p class="MsoNormal"><span lang="EN-US">> “I assume the
driver would depend on the ODBC library, and would require
users to build
</span><a href="https://github.com/SAP/odbc-cpp-wrapper"
moz-do-not-send="true"><span lang="EN-US">https://github.com/SAP/odbc-cpp-wrapper</span></a><span
lang="EN-US"> as the corresponding ODBC driver ?”</span><span
lang="EN-US">
</span></p>
<blockquote>
<div>
<p><span lang="EN-US">The odbc-cpp-wrapper library is going
to be used only during the compilation phase and linked
statically, thus end users will get only one
dynamic/shared library of the HANA driver. Hence, no
additional actions are required from end users. For
those who want to compile the GDAL sources with HANA
support on their own, the sources of the
odbc-cpp-wrapper are needed. However, this step can be
omitted if we store a copy of the library in
</span><a
href="https://github.com/OSGeo/gdal/tree/master/gdal/third_party"
moz-do-not-send="true"><span lang="EN-US">https://github.com/OSGeo/gdal/tree/master/gdal/third_party</span></a><span
lang="EN-US"> like we did in QGIS (see
</span><a
href="https://github.com/qgis/QGIS/tree/master/external/odbccpp"
moz-do-not-send="true"><span lang="EN-US">https://github.com/qgis/QGIS/tree/master/external/odbccpp</span></a><span
lang="EN-US">).
</span></p>
</div>
</blockquote>
<p>I can anticipate potential issues if both GDAL and QGIS have
a odbcpp vendorized copy, and that for some reason they differ
in versions. That could cause symbol clashes at runtime.
Putting the vendorized copy in a dedicated namespace prefix
(GDAL::) could avoid that.</p>
<p>Otherwise, isn't the cpl_odbc.h abstraction good enough ?</p>
<p>Side note: are you aware of <a
href="https://github.com/nanodbc/nanodbc"
moz-do-not-send="true">https://github.com/nanodbc/nanodbc</a>
that is also a C++ wrapper for ODBC ? (Mateusz one of our PSC
members was the main developer of it, although I believe he
has retired from it)</p>
<blockquote>
<div>
<p><span lang="EN-US">Note, that any HANA plugin (GDAL/QGIS)
also requires the SAP HANA Client (<a
href="https://tools.hana.ondemand.com/#hanatools"
moz-do-not-send="true">https://tools.hana.ondemand.com/#hanatools</a>)
to be able to connect an SAP HANA database.</span></p>
</div>
</blockquote>
<p class="MsoNormal">Is that the ODBC driver for SAP HANA ?<br>
<br>
</p>
<blockquote>
<div>
<p class="MsoNormal"><span lang="EN-US">Unfortunately, we
are not able to answer the remaining raised points</span><span
lang="EN-US">
</span><span lang="EN-US">as they are beyond our expertise</span><span
lang="EN-US">.</span></p>
<p class="MsoNormal"><span lang="EN-US">Perhaps they should
be addressed in a separate dedicated discussion.</span></p>
</div>
</blockquote>
<p>Well, if you contribute to GDAL, then that should be in your
area of interest and concern :-)</p>
<p>I think the main practical issue for this to go forward is
for you to find someone who would want to review your
contribution.</p>
<p>Another option is to propose the OGR SAP HANA driver as a
plugin for download from your website.</p>
<p>Even</p>
<pre>-- </pre>
<pre><a href="http://www.spatialys.com" moz-do-not-send="true">http://www.spatialys.com</a></pre>
<pre>My software is free, but my time generally not.</pre>
</div>
</blockquote>
<pre class="moz-signature" cols="72">--
<a class="moz-txt-link-freetext" href="http://www.spatialys.com">http://www.spatialys.com</a>
My software is free, but my time generally not.</pre>
</body>
</html>