<div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif">Even,</div><div class="gmail_default" style="font-family:arial,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,sans-serif">I'm not a huge GoogleTest fan but then I'm also not saying it *worse* than any alternative, but the reasons are reasonably convincing, and I'm happy if those running and contributing tests are happy! </div><div class="gmail_default" style="font-family:arial,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,sans-serif">Should I understand from the RFC that <a href="https://github.com/rouault/gdal/tree/gtest">https://github.com/rouault/gdal/tree/gtest</a> implements the migration? (ie. we have already done the work to migrate, we just need to agree on it?)</div><div class="gmail_default" style="font-family:arial,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,sans-serif">Best regards,</div><div class="gmail_default" style="font-family:arial,sans-serif">Frank</div><div class="gmail_default" style="font-family:arial,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 18, 2022 at 2:27 PM Javier Jimenez Shaw <<a href="mailto:j1@jimenezshaw.com">j1@jimenezshaw.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I am not in the PSC, but this RFC sounds very good. Thanks!</div><div><br></div><div>Now that the tests are going to change, maybe it is a good idea to apply clang-format to them.<br></div><div><div><div dir="ltr">.___ ._ ..._ .. . ._. .___ .. __ . _. . __.. ... .... ._ .__<br>Entre dos pensamientos racionales <br>hay infinitos pensamientos irracionales.<br><br></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 16 Nov 2022 at 20:28, Kurt Schwehr <<a href="mailto:schwehr@gmail.com" target="_blank">schwehr@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I am +1 for this switch, but I'm definitely biased by working at Google. My thoughts:<div><br></div><div>tut definitely gets the job done, but I found it a bit awkward too. But I think the updates and the additional features of GoogleTest are probably worth it. I especially like the distinction between ASSERT.* that immediately stops a test when it finds and issue and EXPECT that lets the test move forward until the end of that test so that I can see all of the results of EXPECTS. The formerly separate "mock" capabilities are really handy too.<br></div><div><br></div><div>I wrote a bunch of C++ GDAL tests using GoogleTests in the 2013-207 time frame (Even used a bit of that work as starters to the tests in PROJ, but he went way beyond what I had). I have a lot of the tests in github, but they are written against very old versions of GDAL. And, the GoogleTest ability to work with newer versions of C++ has gotten a lot stronger. C++17 wasn't even available when I wrote a lot of the test code. We have been upgrading GDAL and improving the tests, so if there is interest, I can try to do some updates to the repo. If any of the autotest2 code is used, the license should be switched from Apache 2.0 to the MIT style license <a href="https://github.com/OSGeo/gdal/blob/a394f9cb299b2c3c2159098483d1fece3a464fda/LICENSE.TXT#L15" target="_blank">mentioned here</a>.</div><div><br></div><div><a href="https://github.com/schwehr/gdal-autotest2/tree/master/cpp" target="_blank">https://github.com/schwehr/gdal-autotest2/tree/master/cpp</a><br></div><div><br></div><div>-Kurt</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Nov 16, 2022 at 10:42 AM Even Rouault <<a href="mailto:even.rouault@spatialys.com" target="_blank">even.rouault@spatialys.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
As this is RFC season. I've prepared RFC88: Use GoogleTest framework for <br>
C/C++ unit tests<br>
<br>
Text at <a href="https://github.com/OSGeo/gdal/pull/6720" rel="noreferrer" target="_blank">https://github.com/OSGeo/gdal/pull/6720</a><br>
<br>
Summary:<br>
<br>
The document proposes and describes conversion of the existing C/C++<br>
autotest suite to use the `GoogleTest<br>
framework <<a href="https://github.com/google/googletest" rel="noreferrer" target="_blank">https://github.com/google/googletest</a>>`__.<br>
<br>
GoogleTest is a popular and maintained framework for C/C++ test<br>
writing, that is a better replacement for the `TUT framework<br>
<<a href="https://github.com/mrzechonek/tut-framework" rel="noreferrer" target="_blank">https://github.com/mrzechonek/tut-framework</a>>`__ that we use currently.<br>
<br>
Even<br>
<br>
-- <br>
<a href="http://www.spatialys.com" rel="noreferrer" target="_blank">http://www.spatialys.com</a><br>
My software is free, but my time generally not.<br>
<br>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
</blockquote></div>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
</blockquote></div>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><font face="monospace">---------------------------------------+--------------------------------------<br>I set the clouds in motion - turn up | Frank Warmerdam, <a href="mailto:warmerdam@pobox.com" target="_blank">warmerdam@pobox.com</a><br>light and sound - activate the windows | +1 650-701-7823<br>and watch the world go round - Rush | Geospatial Software Developer</font></div></div></div></div></div>