<div dir="auto">BTW: Travis is still running the checks on the PRs, it just doesn't show up in GitHub.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 29, 2020, 15:30 James Klassen <<a href="mailto:klassen.js@gmail.com">klassen.js@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">The more I think about this, I'm going to make a PR that just fixes the build.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 29, 2020, 15:14 James Klassen <<a href="mailto:klassen.js@gmail.com" target="_blank" rel="noreferrer">klassen.js@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">And the Travis-CI integration is still listed as installed/enabled, but I do see anything about that tests being run in the PRs. It looks to me like GitHub is broken w.r.t. Travis ATM.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 29, 2020, 15:11 James Klassen <<a href="mailto:klassen.js@gmail.com" rel="noreferrer noreferrer" target="_blank">klassen.js@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">I did look at cherry-picking the one commit from #558 but it appears to do more than is on the label, so I was worried that would break things more.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 29, 2020, 15:09 James Klassen <<a href="mailto:klassen.js@gmail.com" rel="noreferrer noreferrer noreferrer" target="_blank">klassen.js@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">I can merge the two PRs but I haven't had time to properly look them over yet. But at the same time, if master is broken anyway, what can it hurt?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 29, 2020, 15:01 Christopher Hughes <<a href="mailto:chughes@co.lincoln.or.us" rel="noreferrer noreferrer noreferrer noreferrer" target="_blank">chughes@co.lincoln.or.us</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Awesome thanks! Glad to hear it's a known issue with a fix in the works.</div><div>Brent, I'll try your suggestion in the meantime.</div><div><br></div><div>Chris<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 29, 2020 at 11:53 AM Brent Fraser <<a href="mailto:bfraser@geoanalytic.com" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">bfraser@geoanalytic.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Chris,<br>
<br>
I think the fault is mine with a poorly tested code change. Dan has a <br>
pull request pending that will fix the issues, but in the mean time you can <br>
simple change lines 501 and 523 to fix the two errors:<br>
<br>
501: delete the comment: " // for lines..."<br>
<br>
523: change the<br>
!= 200<br>
to<br>
!== 200<br>
<br>
Best Regards,<br>
Brent Fraser<br>
<br>
<br>
<br>
-------- Original Message --------<br>
> From: "Christopher Hughes" <<a href="mailto:chughes@co.lincoln.or.us" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">chughes@co.lincoln.or.us</a>><br>
> Sent: June 29, 2020 12:43 PM<br>
> To: "GeoMoose Users" <<a href="mailto:geomoose-users@lists.osgeo.org" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">geomoose-users@lists.osgeo.org</a>><br>
> Subject: [Geomoose-users] GM3 - Error building on current clone<br>
><br>
> Hello,<br>
><br>
> I'm having a new issue rebuilding the geomoose javascript on windows per<br>
> <a href="https://geomoose.github.io/gm3/install_on_windows.html" rel="noreferrer noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">https://geomoose.github.io/gm3/install_on_windows.html</a><br>
><br>
> I'm building on a current clone of geomoose 3, so the package-lock.json<br>
> file should be up to date with the repo. After cloning<br>
> and running 'npm install'; running 'npm run build' fails. I've tried<br>
> deleting the node_modules directory and re-running npm install<br>
> without success. I haven't made any changes to my clone of the repo.<br>
><br>
> I've included some of the relevant errors below:<br>
> [image: image.png]<br>
><br>
> Any tips would be appreciated!<br>
><br>
> Chris<br>
><br>
><br>
> --<br>
> Chris Hughes<br>
><br>
> GIS Analyst<br>
> Lincoln County Surveyor Department<br>
> 880 NE 7th St. l Newport, OR 97365<br>
> Tel: (541) 574 1283<br>
> _______________________________________________ Geomoose-users mailing <br>
list <a href="mailto:Geomoose-users@lists.osgeo.org" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">Geomoose-users@lists.osgeo.org</a> <br>
<a href="https://lists.osgeo.org/mailman/listinfo/geomoose-users" rel="noreferrer noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/geomoose-users</a><br>
<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><font size="4">Chris Hughes</font><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">GIS Analyst</div><div style="font-size:12.8px"><font size="1">Lincoln County Surveyor Department </font></div><div><font size="1"><span style="font-family:Roboto,arial,sans-serif">880 NE 7th S</span><span style="font-family:Roboto,arial,sans-serif">t</span>. l Newport, OR 97365</font></div><div style="font-size:12.8px"><font size="1">Tel: (541) 574 1283</font></div></div></div>
_______________________________________________<br>
Geomoose-users mailing list<br>
<a href="mailto:Geomoose-users@lists.osgeo.org" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">Geomoose-users@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/geomoose-users" rel="noreferrer noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/geomoose-users</a></blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>