[geos-devel] Thread Safe CAPI ready for review

[Chuck Thibert]

Hi Regina,

Thanks for giving it a try and finding this.  I forgot to add the
changes in the root directory.  I didn't think to make a patch because
of the new files I was adding.  This time I went ahead and did an svn
add just to be able to take a good patch.

And yes, this was done in Trunk and not a branch.

I've attached the new patch file to the ticket.

Thanks again,
Chuck


On Fri, 2008-11-28 at 19:19 -0500, Obe, Regina wrote:
> Chuck,
> 
> This is all fairly new to me so I could be missing something here.
> I'm having trouble compiling these new changes you have under Visual
> Studio 2008
> 
> 1) First off all, it looks like you provided the changed files rather
> than a patch.  Shouldn't you have provided a patch instead?
> 2) I presume this patch is for Trunk rather than 3.0 branch?
> 
> 
> Now the error I get is this
> 
> 1>c:\projects\geos\trunk\capi\geos_c.h(32) : fatal error C1083: Cannot
> open include file: 'geosTS_c.h': No such file or directory
> 
> 
> I assume that somehow the geosTS_c.h.in you provided is supposed to
> somehow get transformed to geosTS_c.h, but not quite clear how that
> magic happens.
> 
> I presume it is not happening because you only provided a Makefile.am
> and I guess a similar change needs to happen for VC something or
> other?
> 
> Haven't tried the changes on my OpenSUSE VM yet, but hope to at some
> point.
> 
> Thanks,
> Regina
> 
> 
> -----Original Message-----
> From: geos-devel-bounces at lists.osgeo.org on behalf of Chuck Thibert
> Sent: Fri 11/28/2008 4:19 PM
> To: GEOS Development List
> Subject: [geos-devel] Thread Safe CAPI ready for review
> 
> Hello,
> 
> I've attached the changed and new files to ticket 210.  This is based
> on
> revision 2230, which was the latest when I updated today (Nov. 28.)
> 
> I don't have access to Windows or Mac development boxes for testing.
> This was developed on Fedora Core 8.  Would love if someone could
> check
> these out for me on Mac/Windows.
> 
> Thanks,
> Chuck
> 
> 
> On Thu, 2008-11-27 at 14:17 -0500, Chuck Thibert wrote:
> > Hi Paul,
> >
> > RE: Thread Safe API.  I'm looking to finish up in the next day or
> so,
> > assuming no gotchas.  Just finalizing the last changes for the old
> API
> > calling the new one.  I'm pushing to have it ready for review by
> Friday,
> > or early next week.
> >
> > Chuck
> >
> > On Thu, 2008-11-27 at 10:08 -0800, Paul Ramsey wrote:
> > > Hi all, what features are we waiting on for the 3.1.0 release?
> > > In the interest of "getting as much in as possible" I wouldn't
> mind
> > > seeing the thread-safe API in place prior to release. What is the
> > > timeline on that? Are there other functions we want to expose in
> the
> > > CAPI before release, is the other question, since it will be a
> while
> > > before our next opportunity.
> > >
> > > P.
> > > _______________________________________________
> > > geos-devel mailing list
> > > geos-devel at lists.osgeo.org
> > > http://lists.osgeo.org/mailman/listinfo/geos-devel
> > _______________________________________________
> > geos-devel mailing list
> > geos-devel at lists.osgeo.org
> > http://lists.osgeo.org/mailman/listinfo/geos-devel
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/geos-devel
> 
> 
> 
> 
> 
> 
> 
> ______________________________________________________________________
> 
> The substance of this message, including any attachments, may be
> confidential, legally privileged and/or exempt from disclosure
> pursuant to Massachusetts law. It is intended solely for the
> addressee. If you received this in error, please contact the sender
> and delete the material from any computer.
> 
> 
> ______________________________________________________________________
> 
> Help make the earth a greener place. If at all possible resist
> printing this email and join us in saving paper. 
> 
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/geos-devel