[geos-devel] 3.0.3 To Do

[Obe, Regina]

Sorry it took so long to test on VC9 (VS 2008 Professional on Vista).  Before Sanak's patch and after upgrading solution to 2008 doesn't compile, but after applying Sanak's patch and upgrading solution to 2008 - it compiles.

The geos_test compiles and after running against the CAPI/test.wkt and doing a diff compare between the test.out and what I got, I see no difference.

HOWEVER:  Why does it say - GEOS version 3.0.0rc4-CAPI-1.3.3  -- shouldn't we change that version. To I don't know something like 3.0.3

The geos_unit doesn't give any errors either.

One thing I did notice is a lot of warnings about how Wp64 is deprecated and will be removed in a future release.  I don't recall getting that when compiling under VC8.  Get same when compiling against trunk.

also just a lot of somewhat scary looking warnings - which I'm sure everyone on the GEOS team is aware of (I wasn't paying too much attention when compiling under VC8, so they were probably there too).

So for 3.0 branch
geos_lib - 0 error(s), 371 warning(s)

For Trunk
1>geos_lib - 0 error(s), 453 warning(s)

3.0  Warnings:
lots of  "assignment operator could not be generated"
lots of unreferenced parameters (no big deal)
lot of conversion from 'size_t' to 'int', possible loss of data - assume no big deal
There was a warning about int64 being cast to long - can't remember whether that was in trunk or branch.


Trunk warnings:
Things like - lots of  "assignment operator could not be generated"
 "'geos::io::WKTReader' : type name first seen using 'class' now seen using 'struct'"
monotonechainbuilder.cpp(103) : warning C4018: '>=' : signed/unsigned mismatch
nodedsegmentstring.h(88) : warning C4018: '<' : signed/unsigned mismatch
conversion from 'size_t' to 'int', possible loss of data (assume no big deal)

The geos_test is not in trunk for vc8, do we want it there or do we not even care to have this test at all for VC?

Anyrate I guess the moral is for 3.1 we should probably cleanup some of these warnings since its hard to tell which warnings are important and which are not. But Paul already stated the obvious before, I'm just restating it.

-----Original Message-----
From: geos-devel-bounces at lists.osgeo.org on behalf of Sanak
Sent: Thu 10/23/2008 1:52 PM
To: GEOS Development List
Subject: Re: [geos-devel] 3.0.3 To Do
 
Ok, I had added geostest project to msvc80 solution file.
Please see the attach
file(geos-branches-3.0-build-msvc80_add_geostest.patch).
geostest.vcproj will generate capi/test.out.

I think that the cause of difference between generated test.out and
test.expected is precision of floating point, but I don't know details.

And another Visual C++ specific problem may be capi version.(capi/
geos_c.h.in)
---
Index: geos_c.h.in
===================================================================
--- geos_c.h.in    (revision 2208)
+++ geos_c.h.in    (working copy)
@@ -51,9 +51,9 @@
 #if defined(_MSC_VER)
 #include <geos/version.h>
 #define GEOS_CAPI_VERSION_MAJOR 1
-#define GEOS_CAPI_VERSION_MINOR 3
+#define GEOS_CAPI_VERSION_MINOR 4
 #define GEOS_CAPI_VERSION_PATCH 3
-#define GEOS_CAPI_VERSION "3.0.0rc4-CAPI-1.3.3"
+#define GEOS_CAPI_VERSION "3.0.3-CAPI-1.4.3"
 #else
 #define GEOS_VERSION_MAJOR @VERSION_MAJOR@
 #define GEOS_VERSION_MINOR @VERSION_MINOR@
---

Regards,

2008/10/24 Frank Warmerdam <warmerdam at pobox.com>

> Obe, Regina wrote:
>
>> I know Frank already tested on Visual C++ Express (which is basically
>> Visual 2008 Express) and got some test fail errors.  Do we have a solution
>> file for that (or would people just use the msvc80 solution file for that if
>> they wanted to use a solution) .
>>
> ...
>
>> Running regression tests using geos_unitd.exe...
>> ===============================
>>  GEOS Test Suite Application
>> ===============================
>> capi::GEOSCoordSeq: ..... 5
>> capi::GEOSSimplify: . 1
>>
>
> Folks,
>
> I would note that I wasn't running geos_unitd.exe, I ran geostest.exe
> against capi/test.wkt and compared to capi/test.expected.  If I get
> back to my windows build I'll look into the geos_unitd.exe which I wasn't
> aware of.
>
> Best regards,
> --
>
> ---------------------------------------+--------------------------------------
> I set the clouds in motion - turn up   | Frank Warmerdam,
> warmerdam at pobox.com
> light and sound - activate the windows | http://pobox.com/~warmerdam<http://pobox.com/%7Ewarmerdam>
> and watch the world go round - Rush    | Geospatial Programmer for Rent
>
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/geos-devel
>















-----------------------------------------
The substance of this message, including any attachments, may be
confidential, legally privileged and/or exempt from disclosure
pursuant to Massachusetts law. It is intended
solely for the addressee. If you received this in error, please
contact the sender and delete the material from any computer.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osgeo.org/pipermail/geos-devel/attachments/20081023/d1cc4ab1/attachment-0001.html