From dark.panda+lists at gmail.com  Mon May  2 07:32:17 2016
From: dark.panda+lists at gmail.com (J Smith)
Date: Mon, 2 May 2016 10:32:17 -0400
Subject: [geos-devel] Extraction of PHP extension into PECL-style package
In-Reply-To: <20160321091553.GA5079@localhost>
References: <CADFUPgfNfRHmEFABU9Zqgc06QybDaxN=fORyiFS1NybNtTPfEQ@mail.gmail.com>
 <20160307094517.GC4143@localhost>
 <CADFUPgcXWMS+jKOwQ7mD7fJj_Eipcccdh0_oW74X__V76jG6GQ@mail.gmail.com>
 <20160307161006.GA15236@localhost>
 <CADFUPgeotutf6ePTjT1HSoXYM6Zr8gQ8Q6c2xeskBnVFv4WUPQ@mail.gmail.com>
 <20160308174822.GA7540@localhost>
 <CADFUPgdg13t4ykSn9gDPUbQY+WvV9xNnnfv+j7A+hUCyo-xfag@mail.gmail.com>
 <20160310220027.GC9592@localhost> <20160310220230.GD9592@localhost>
 <CADFUPge-JMKWNE1YZ6cco_0ArH-xDJi0vim778V3pOWuTjQyiw@mail.gmail.com>
 <20160321091553.GA5079@localhost>
Message-ID: <CADFUPge1zcA4fpFSNci+BkUya3NSc7UuNkiBG=q093Kx-M9t=A@mail.gmail.com>

G'day list.

Just a quick update on the GEOS PHP bindings. I took some time last
night to take a look at PHP 7 and did a quick migration to their new
API. I'm able to compile cleanly and some of the tests are running,
although I need to sort through the individual methods and clean up
some bits and pieces here and there. Most of the pain at this point
involves changes to the way PHP 7 manages memory and moving over to
new data types like zend_string where it makes sense. It's definitely
a decent start, even if it's a bit rough at the moment. Once I get
everything stabilized I'll look into abstracting some of the changes
away into some macros and the like so that both PHP 5 and 7 can
compile from the same code base, as right now I've torn things apart
for the sake of getting to know PHP 7 a bit better. The major hang up
at the moment is the new memory management system, as I'm experiencing
segfaults at process shutdown and with garbage collection, but it's
nothing that's insurmountable, just some basic refactoring and
rejiggering that's necessary. I'll have some more time available soon
to try and wrap up a first pass, after which the abstractions will
come in.

Cheers, list.

On Mon, Mar 21, 2016 at 5:15 AM, Sandro Santilli <strk at keybit.net> wrote:
> On Sun, Mar 20, 2016 at 07:48:46PM -0400, J Smith wrote:
>> On Thu, Mar 10, 2016 at 5:02 PM, Sandro Santilli <strk at keybit.net> wrote:
>> >
>> > Also, the "make check" run ends with prompting me, which is really
>> > annoying. The prompt asks if I want to send the report to the PHP QA
>> > team. Really ? Should we send successful test run reports for a single
>> > package to "the PHP QA team" ?? I wouldn't want to be in that team :)
>> >
>>
>> Yeah, that's annoying. All part of the standard test suite for PECL
>> extensions. :/
>>
>> How about this...
>>
>> - I'll make the tests spit out more output on success so we know
>> things are working fine. Likewise when there's a problem, it'll be
>> more obvious what failed.
>
> I actually like the output to be short and clean on success
> (just a short report of how many tests were run). This wasn't
> the case IIRC.
>
> Can't comment on the quality of failure reports as if I understood
> correctly there was no failure in my run.
>
>> - I'll see what I can do about `make check`, have it not prompt
>> anything. I'll leave `make test` as-is because that's the standard
>> PECL testing command and there might be some dependencies on it
>> behaving that way, but `make check` shouldn't have any similar
>> dependencies since it's an OSGEO-thing I assume, right?
>
> 'make check' can be just an alias for 'make note'.
>
>> On another note, I'll be looking into PHP7 compatibility. I took an
>> initial look about a month ago, doesn't look too bad, but it'll take
>> it some time I figure.
>
> Great, thanks !
>
> --strk;
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/geos-devel

From strk at keybit.net  Mon May  2 08:08:04 2016
From: strk at keybit.net (Sandro Santilli)
Date: Mon, 2 May 2016 17:08:04 +0200
Subject: [geos-devel] Extraction of PHP extension into PECL-style package
In-Reply-To: <CADFUPge1zcA4fpFSNci+BkUya3NSc7UuNkiBG=q093Kx-M9t=A@mail.gmail.com>
References: <CADFUPgcXWMS+jKOwQ7mD7fJj_Eipcccdh0_oW74X__V76jG6GQ@mail.gmail.com>
 <20160307161006.GA15236@localhost>
 <CADFUPgeotutf6ePTjT1HSoXYM6Zr8gQ8Q6c2xeskBnVFv4WUPQ@mail.gmail.com>
 <20160308174822.GA7540@localhost>
 <CADFUPgdg13t4ykSn9gDPUbQY+WvV9xNnnfv+j7A+hUCyo-xfag@mail.gmail.com>
 <20160310220027.GC9592@localhost> <20160310220230.GD9592@localhost>
 <CADFUPge-JMKWNE1YZ6cco_0ArH-xDJi0vim778V3pOWuTjQyiw@mail.gmail.com>
 <20160321091553.GA5079@localhost>
 <CADFUPge1zcA4fpFSNci+BkUya3NSc7UuNkiBG=q093Kx-M9t=A@mail.gmail.com>
Message-ID: <20160502150804.GA7220@localhost>

Thanks for the update, J
Let me know when you need some testing

--strk;

On Mon, May 02, 2016 at 10:32:17AM -0400, J Smith wrote:
> G'day list.
> 
> Just a quick update on the GEOS PHP bindings. I took some time last
> night to take a look at PHP 7 and did a quick migration to their new
> API. I'm able to compile cleanly and some of the tests are running,
> although I need to sort through the individual methods and clean up
> some bits and pieces here and there. Most of the pain at this point
> involves changes to the way PHP 7 manages memory and moving over to
> new data types like zend_string where it makes sense. It's definitely
> a decent start, even if it's a bit rough at the moment. Once I get
> everything stabilized I'll look into abstracting some of the changes
> away into some macros and the like so that both PHP 5 and 7 can
> compile from the same code base, as right now I've torn things apart
> for the sake of getting to know PHP 7 a bit better. The major hang up
> at the moment is the new memory management system, as I'm experiencing
> segfaults at process shutdown and with garbage collection, but it's
> nothing that's insurmountable, just some basic refactoring and
> rejiggering that's necessary. I'll have some more time available soon
> to try and wrap up a first pass, after which the abstractions will
> come in.
> 
> Cheers, list.
> 
> On Mon, Mar 21, 2016 at 5:15 AM, Sandro Santilli <strk at keybit.net> wrote:
> > On Sun, Mar 20, 2016 at 07:48:46PM -0400, J Smith wrote:
> >> On Thu, Mar 10, 2016 at 5:02 PM, Sandro Santilli <strk at keybit.net> wrote:
> >> >
> >> > Also, the "make check" run ends with prompting me, which is really
> >> > annoying. The prompt asks if I want to send the report to the PHP QA
> >> > team. Really ? Should we send successful test run reports for a single
> >> > package to "the PHP QA team" ?? I wouldn't want to be in that team :)
> >> >
> >>
> >> Yeah, that's annoying. All part of the standard test suite for PECL
> >> extensions. :/
> >>
> >> How about this...
> >>
> >> - I'll make the tests spit out more output on success so we know
> >> things are working fine. Likewise when there's a problem, it'll be
> >> more obvious what failed.
> >
> > I actually like the output to be short and clean on success
> > (just a short report of how many tests were run). This wasn't
> > the case IIRC.
> >
> > Can't comment on the quality of failure reports as if I understood
> > correctly there was no failure in my run.
> >
> >> - I'll see what I can do about `make check`, have it not prompt
> >> anything. I'll leave `make test` as-is because that's the standard
> >> PECL testing command and there might be some dependencies on it
> >> behaving that way, but `make check` shouldn't have any similar
> >> dependencies since it's an OSGEO-thing I assume, right?
> >
> > 'make check' can be just an alias for 'make note'.
> >
> >> On another note, I'll be looking into PHP7 compatibility. I took an
> >> initial look about a month ago, doesn't look too bad, but it'll take
> >> it some time I figure.
> >
> > Great, thanks !
> >
> > --strk;

From geos-trac at osgeo.org  Tue May  3 05:56:23 2016
From: geos-trac at osgeo.org (GEOS)
Date: Tue, 03 May 2016 12:56:23 -0000
Subject: [geos-devel] [GEOS] #777: SVN version won't build on Windows
Message-ID: <043.d306a6cc7706b203543ab43f9059fd62@osgeo.org>

#777: SVN version won't build on Windows
------------------------+--------------------------
 Reporter:  jluis       |      Owner:  geos-devel@…
     Type:  defect      |     Status:  new
 Priority:  major       |  Milestone:  3.5.1
Component:  Default     |    Version:  svn-trunk
 Severity:  Unassigned  |   Keywords:
------------------------+--------------------------
 It errors with

 [ 81%] Building CXX object capi/CMakeFiles/geos_c.dir/geos_c.cpp.obj
 geos_c.cpp
 V:\geos_SVN\build\capi\geos_c.h(826) : error C2059: syntax error :
 '__declspec(dllexport)'
 V:\geos_SVN\build\capi\geos_c.h(831) : error C2059: syntax error :
 '__declspec(dllexport)'
 V:\geos_SVN\build\capi\geos_c.h(1746) : error C2059: syntax error :
 '__declspec(dllexport)'
 V:\geos_SVN\build\capi\geos_c.h(1764) : error C2059: syntax error :
 '__declspec(dllexport)'
 V:\geos_SVN\capi\geos_c.cpp(1165) : error C3861:
 'GEOSSTRtree_nearest_generic': identifier not found
 V:\geos_SVN\capi\geos_c.cpp(1174) : error C3861:
 'GEOSSTRtree_nearest_generic_r': identifier not found
 NMAKE : fatal error U1077: 'C:\PROGRA~2\MICROS~3.0\VC\bin\cl.exe' : return
 code '0x2'

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/777>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From geos-trac at osgeo.org  Tue May  3 06:00:48 2016
From: geos-trac at osgeo.org (GEOS)
Date: Tue, 03 May 2016 13:00:48 -0000
Subject: [geos-devel] [GEOS] #777: SVN version won't build on Windows
In-Reply-To: <043.d306a6cc7706b203543ab43f9059fd62@osgeo.org>
References: <043.d306a6cc7706b203543ab43f9059fd62@osgeo.org>
Message-ID: <058.5e34c8891237f93fd22a38d0bd3ac4d2@osgeo.org>

#777: SVN version won't build on Windows
------------------------+---------------------------
 Reporter:  jluis       |       Owner:  geos-devel@…
     Type:  defect      |      Status:  new
 Priority:  major       |   Milestone:  3.5.1
Component:  Default     |     Version:  svn-trunk
 Severity:  Unassigned  |  Resolution:
 Keywords:              |
------------------------+---------------------------

Comment (by strk):

 Probably a missing file in the vc build scripts,
 but nobody likes windows so nobody cares to maintain
 those scripts. If you send a patch, it could be applied.

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/777#comment:1>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From geos-trac at osgeo.org  Wed May 11 03:24:46 2016
From: geos-trac at osgeo.org (GEOS)
Date: Wed, 11 May 2016 10:24:46 -0000
Subject: [geos-devel] [GEOS] #778: Generate ChangeLog from git log
Message-ID: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>

#778: Generate ChangeLog from git log
------------------------+--------------------------
 Reporter:  strk        |      Owner:  geos-devel@…
     Type:  task        |     Status:  new
 Priority:  major       |  Milestone:  3.6.0
Component:  Default     |    Version:
 Severity:  Unassigned  |   Keywords:  git
------------------------+--------------------------
 A git2cl tool exists and is packaged on debian, but as the current
 ChangeLog format includes revision numbers we'll need to drop that
 information for the new ChangeLog (no revision numbers in a git-only
 repo).

 One possibility here is to save the old ChangeLog files into a
 subdirectory (doc/changelog?) and start with a fresh one starting from
 where the old one ends.

 Another is to STOP checking the ChangeLog into the repository but always
 only generate it at "make dist" time, which may be a bit tricky to pass
 "make distcheck" (as it sets the sources read-only) but may set us free
 from future management issues.

 This is propedeutic for moving the codebase from SVN to git.

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/778>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From geos-trac at osgeo.org  Wed May 11 03:41:21 2016
From: geos-trac at osgeo.org (GEOS)
Date: Wed, 11 May 2016 10:41:21 -0000
Subject: [geos-devel] [GEOS] #778: Generate ChangeLog from git log
In-Reply-To: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
References: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
Message-ID: <057.70e12ff0445bdb22349e57cfd3851ff9@osgeo.org>

#778: Generate ChangeLog from git log
------------------------+---------------------------
 Reporter:  strk        |       Owner:  geos-devel@…
     Type:  task        |      Status:  new
 Priority:  major       |   Milestone:  3.6.0
Component:  Default     |     Version:  3.5.0
 Severity:  Unassigned  |  Resolution:
 Keywords:  git         |
------------------------+---------------------------
Changes (by mloskot):

 * version:   => 3.5.0


Comment:

 Another possibility is to stop replicating VCS log in the ChangeLog and
 not to include any revision info.

 Typically, ChangeLog is written, by humans for humans, as a
 chronologically ordered list of '''notable''' changes for each version of
 a project, but not all changes/revisions checked in to the repo. I like
 http://keepachangelog.com/

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/778#comment:1>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From geos-trac at osgeo.org  Wed May 11 04:08:19 2016
From: geos-trac at osgeo.org (GEOS)
Date: Wed, 11 May 2016 11:08:19 -0000
Subject: [geos-devel] [GEOS] #778: Generate ChangeLog from git log
In-Reply-To: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
References: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
Message-ID: <057.9a4db097a75bb6bb582fb8678b764d7a@osgeo.org>

#778: Generate ChangeLog from git log
------------------------+---------------------------
 Reporter:  strk        |       Owner:  geos-devel@…
     Type:  task        |      Status:  new
 Priority:  major       |   Milestone:  3.6.0
Component:  Default     |     Version:  3.5.0
 Severity:  Unassigned  |  Resolution:
 Keywords:  git         |
------------------------+---------------------------

Comment (by strk):

 The "notable changes" role is taken by the NEWS file.

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/778#comment:2>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From geos-trac at osgeo.org  Wed May 11 04:20:44 2016
From: geos-trac at osgeo.org (GEOS)
Date: Wed, 11 May 2016 11:20:44 -0000
Subject: [geos-devel] [GEOS] #778: Generate ChangeLog from git log
In-Reply-To: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
References: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
Message-ID: <057.04ec232a63fea4509e01c6f0031e33bc@osgeo.org>

#778: Generate ChangeLog from git log
------------------------+---------------------------
 Reporter:  strk        |       Owner:  geos-devel@…
     Type:  task        |      Status:  new
 Priority:  major       |   Milestone:  3.6.0
Component:  Default     |     Version:  3.5.0
 Severity:  Unassigned  |  Resolution:
 Keywords:  git         |
------------------------+---------------------------

Comment (by mloskot):

 IMHO, it's much of bureaucracy.

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/778#comment:3>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From geos-trac at osgeo.org  Wed May 11 04:23:55 2016
From: geos-trac at osgeo.org (GEOS)
Date: Wed, 11 May 2016 11:23:55 -0000
Subject: [geos-devel] [GEOS] #778: Generate ChangeLog from git log
In-Reply-To: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
References: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
Message-ID: <057.15e4b3c3b38a2deb7996ab46150991ca@osgeo.org>

#778: Generate ChangeLog from git log
------------------------+---------------------------
 Reporter:  strk        |       Owner:  geos-devel@…
     Type:  task        |      Status:  new
 Priority:  major       |   Milestone:  3.6.0
Component:  Default     |     Version:  3.5.0
 Severity:  Unassigned  |  Resolution:
 Keywords:  git         |
------------------------+---------------------------

Comment (by strk):

 So you agree with removing the ChangeLog file from the repository
 and only manually edit NEWS file (for human-edited "notable" changes) ?

 Then we can automatically generate and include the ChangeLog into
 official releases (which are downloaded w/out the whole git history)

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/778#comment:4>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From geos-trac at osgeo.org  Wed May 11 06:28:28 2016
From: geos-trac at osgeo.org (GEOS)
Date: Wed, 11 May 2016 13:28:28 -0000
Subject: [geos-devel] [GEOS] #778: Generate ChangeLog from git log
In-Reply-To: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
References: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
Message-ID: <057.19b9ba5b5256d0719c8ee38c100d655b@osgeo.org>

#778: Generate ChangeLog from git log
------------------------+---------------------------
 Reporter:  strk        |       Owner:  geos-devel@…
     Type:  task        |      Status:  new
 Priority:  major       |   Milestone:  3.6.0
Component:  Default     |     Version:  3.5.0
 Severity:  Unassigned  |  Resolution:
 Keywords:  git         |
------------------------+---------------------------

Comment (by mloskot):

 What do you think to put into the ChangeLog as revision 'number'?

 I rather meant, drop the idea of generating ChangeLog, rename NEWS to
 ChangeLog and let release manager (not individual committers) to update it
 manually.

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/778#comment:5>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From geos-trac at osgeo.org  Wed May 11 06:33:45 2016
From: geos-trac at osgeo.org (GEOS)
Date: Wed, 11 May 2016 13:33:45 -0000
Subject: [geos-devel] [GEOS] #778: Generate ChangeLog from git log
In-Reply-To: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
References: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
Message-ID: <057.ab5fc813f2288009b2e326b1562f77de@osgeo.org>

#778: Generate ChangeLog from git log
------------------------+---------------------------
 Reporter:  strk        |       Owner:  geos-devel@…
     Type:  task        |      Status:  new
 Priority:  major       |   Milestone:  3.6.0
Component:  Default     |     Version:  3.5.0
 Severity:  Unassigned  |  Resolution:
 Keywords:  git         |
------------------------+---------------------------

Comment (by strk):

 No revision numbers, is my proposal.
 Autogenerated ChangeLog in the release tarball.
 Manually edited NEWS (by maintainer-or-committer).

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/778#comment:6>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From geos-trac at osgeo.org  Mon May 23 03:53:26 2016
From: geos-trac at osgeo.org (GEOS)
Date: Mon, 23 May 2016 10:53:26 -0000
Subject: [geos-devel] [GEOS] #778: Generate ChangeLog from git log
In-Reply-To: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
References: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
Message-ID: <057.7c134a42a5df2154ad1eaf9d831ebc34@osgeo.org>

#778: Generate ChangeLog from git log
------------------------+---------------------------
 Reporter:  strk        |       Owner:  geos-devel@…
     Type:  task        |      Status:  new
 Priority:  major       |   Milestone:  3.6.0
Component:  Default     |     Version:  3.5.0
 Severity:  Unassigned  |  Resolution:
 Keywords:  git         |
------------------------+---------------------------
Changes (by strk):

 * cc: mloskot (added)


Comment:

 do you receive a notification now Mat  ?

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/778#comment:7>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From geos-trac at osgeo.org  Mon May 23 04:11:55 2016
From: geos-trac at osgeo.org (GEOS)
Date: Mon, 23 May 2016 11:11:55 -0000
Subject: [geos-devel] [GEOS] #778: Generate ChangeLog from git log
In-Reply-To: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
References: <042.ba71032c1b7d3476935a3ac4bb4417f7@osgeo.org>
Message-ID: <057.86e8951bf76e3258bae4361ecc5f7d2a@osgeo.org>

#778: Generate ChangeLog from git log
------------------------+---------------------------
 Reporter:  strk        |       Owner:  geos-devel@…
     Type:  task        |      Status:  new
 Priority:  major       |   Milestone:  3.6.0
Component:  Default     |     Version:  3.5.0
 Severity:  Unassigned  |  Resolution:
 Keywords:  git         |
------------------------+---------------------------

Comment (by mloskot):

 Sandro, yes, I have received it.

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/778#comment:8>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

From strk at kbt.io  Sun May 29 13:42:57 2016
From: strk at kbt.io (Sandro Santilli)
Date: Sun, 29 May 2016 22:42:57 +0200
Subject: [geos-devel] git-appraise testing
Message-ID: <20160529204257.GD32010@tuscia.pallamondo.net>

As we move from SVN to GIT (sloowly, I know, sorry for that)
I started looking at options to get peer reviews w/out being
dependent on a git hosting service (like OSGeo's Gogs or
gitlab) and found this:

  https://github.com/google/git-appraise

It promises to support for distributed reviews, up to line-oriented 
comments, by placing reviews within the git repository (in a custom
ref).

For testing, I pushed a review request for GEOS to the Gogs mirror.
It should show up if you:

  $ git remote add osgeo https://git.osgeo.org/gogs/geos/geos
  $ git appraise pull osgeo
  $ git appraise list

Maybe the bots could pick review requests, test the build
for them and report the build status (thinking forward).

--strk;

  ()   Free GIS & Flash consultant/developer
  /\   https://strk.kbt.io/services.html

From gdt at ir.bbn.com  Tue May 31 10:45:29 2016
From: gdt at ir.bbn.com (Greg Troxel)
Date: Tue, 31 May 2016 13:45:29 -0400
Subject: [geos-devel] git-appraise testing
In-Reply-To: <20160529204257.GD32010@tuscia.pallamondo.net> (Sandro Santilli's
 message of "Sun, 29 May 2016 22:42:57 +0200")
References: <20160529204257.GD32010@tuscia.pallamondo.net>
Message-ID: <rmih9dep1dy.fsf@fnord.ir.bbn.com>


Sandro Santilli <strk at kbt.io> writes:

> As we move from SVN to GIT (sloowly, I know, sorry for that)
> I started looking at options to get peer reviews w/out being
> dependent on a git hosting service (like OSGeo's Gogs or
> gitlab) and found this:
>
>   https://github.com/google/git-appraise
>
> It promises to support for distributed reviews, up to line-oriented 
> comments, by placing reviews within the git repository (in a custom
> ref).

(I was going to send a private reply but List-Reply-To: considered
harmful. :-)

From a quick look, it seems the review data is somewhat awkward to type,
so that this would only really work with an editor plugin.  It seems
there is one for eclipse, but not for the far more important emacs and
vi.

Have you tried to do a real review, and with what editing tool?  How did
it work?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 180 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/geos-devel/attachments/20160531/a8d3be06/attachment.sig>

From strk at kbt.io  Tue May 31 11:55:16 2016
From: strk at kbt.io (Sandro Santilli)
Date: Tue, 31 May 2016 20:55:16 +0200
Subject: [geos-devel] git-appraise testing
In-Reply-To: <rmih9dep1dy.fsf@fnord.ir.bbn.com>
References: <20160529204257.GD32010@tuscia.pallamondo.net>
 <rmih9dep1dy.fsf@fnord.ir.bbn.com>
Message-ID: <20160531185516.GA1307@localhost>

On Tue, May 31, 2016 at 01:45:29PM -0400, Greg Troxel wrote:
> Sandro Santilli <strk at kbt.io> writes:
> 
> >   https://github.com/google/git-appraise
> 
> Have you tried to do a real review, and with what editing tool?  How did
> it work?

I tried, and pushed to gogs (https://git.osgeo.org/gogs/geos/geos)
If you "git appraise pull <gogs-remote-name>" you should then be
able to see it with "git appraise list".

IIRC I used the commandline, no editor.
A google guy just accepted a PR of mine, so maybe we can send
more, for an editor :)

--strk;