<div dir="ltr"><font color="#000000">Hey,</font><div><div><font color="#000000">I suppose only those test cases needs to be ported that correspond to Voronoi class. But i see many other test cases for other class that are missing. So just asking for clarification, do we need to ported other test cases as well?</font></div>
</div><div><font color="#000000"><br></font></div><div><b style="font-weight:normal"><p dir="ltr" style="line-height:1.15;margin-top:0pt;margin-bottom:0pt"><font color="#000000"><span style="background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><font face="arial, helvetica, sans-serif">And as for the C-API this is what i have understood: it provides a wrapper to the C++ functions. All the reference functions are implemented in geos_ts_c.cpp. And all the functions that are exposed to the users are in geos_c.cpp and its header file, </font></span><span style="font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">geos_c.h.</span></font></p>
<p dir="ltr" style="line-height:1.15;margin-top:0pt;margin-bottom:0pt"><font color="#000000"><span style="font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><br></span></font></p>
<p style="line-height:1.15;margin-top:0pt;margin-bottom:0pt"><font color="#000000"><span style="font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Regarding the Gsoc proposal in the 'Describe your idea' section of the OSGeo proposal Application, this is what i have thought about from our discussion on the project:</span></font></p>
<p style="line-height:1.15;margin-top:0pt;margin-bottom:0pt"><a href="https://docs.google.com/document/d/1biGlOqTnS7SnlxPOcFKrxj7_QEMYd1VtAFDms6L3AnY/edit">https://docs.google.com/document/d/1biGlOqTnS7SnlxPOcFKrxj7_QEMYd1VtAFDms6L3AnY/edit</a><font color="#000000"><span style="font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><br>
</span></font></p><p style="line-height:1.15;margin-top:0pt;margin-bottom:0pt"><br></p><p style="line-height:1.15;margin-top:0pt;margin-bottom:0pt"><span style="font-family:arial,sans-serif;font-size:12.727272033691406px;line-height:normal"><font color="#000000">Looking for your feedback on how it can further be improved.</font></span><br>
</p><p style="line-height:1.15;margin-top:0pt;margin-bottom:0pt"><font color="#000000"><span style="font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><br></span></font></p><p style="line-height:1.15;margin-top:0pt;margin-bottom:0pt">
<font color="#000000"><span style="font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Thanks and kind regards,</span></font></p><p style="line-height:1.15;margin-top:0pt;margin-bottom:0pt">
<font color="#000000"><span style="font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Vishal</span></font></p>
<p dir="ltr" style="line-height:1.15;margin-top:0pt;margin-bottom:0pt"><font color="#000000"><span style="font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><br></span></font></p>
<p dir="ltr" style="line-height:1.15;margin-top:0pt;margin-bottom:0pt"><font color="#000000"><span style="font-family:Arial;background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><br></span></font></p>
</b></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 4 April 2013 19:46, Sandro Santilli <span dir="ltr"><<a href="mailto:strk@keybit.net" target="_blank">strk@keybit.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div>On Thu, Apr 04, 2013 at 05:02:56PM +0530, vishal tiwari wrote:<br>
> Hey,<br>
</div>> Here is the structure of classes that is required by the *<br>
> VoronoiDiagramBuilder* class: (The ones in *bold* needs to be ported)<br>
><br>
> 1. Geometry<br>
> 2. Geometry Factor<br>
> 3. QuadEdgeSubdivision:<br>
> - Methods required for *VoronoiDigramBuilder*:<br>
> - *getVoronoiDiagram*<br>
> - *getVoronoiCellPolugons*<br>
> - *getVoronoiCellPolugon*<br>
> - visitTriangle<br>
> - *getVertexUniqueEdges*<br>
> - TriangleCoordinateVisitor<br>
> - *TriangleCircumcenterVisitor*<br>
> - *TriangleEdgeListVisitor*<br>
> - *TriangleVertexListVisitor*<br>
> - *isFrameVertex*<br>
> 4. TriangleVisitor(Interface)<br>
<div>><br>
> Plz let me know if i am missing some method or class which is required<br>
> for VoronoiDiagramBuilder port.<br>
<br>
</div>Again, looking is part of the work.<br>
You'll find out as you start porting if anything is missing.<br>
<div><br>
> Is it me or its very few work for a Gsoc Project?<br>
<br>
</div>Don't forget the testcases for the C++ implementation,<br>
the C-API exposure and relative testcases and audit for<br>
memory leakage.<br>
<br>
After you've done, if you still have time it'd be nice to<br>
work on improving the performance of it :)<br>
<br>
--strk;<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Vishal Tiwari<div>Undergraduate</div><div>Computer Science and Engineering</div><div>Lab for Spatial Informatics</div><div>IIIT-Hyderabad</div></div>
</div></div>