<div dir="ltr">Hey!<div>I have submitted my GSoC Proposal for the project "<span style="font-size:12.800000190734863px;font-family:Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif">Adding Voronoi Diagrams to GEOS" here:</span></div>
<div><a href="http://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/vishal_tiwari/13001" target="_blank">http://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/vishal_tiwari/13001</a><span style="font-size:12.800000190734863px;font-family:Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif"><br>
</span></div><div><br></div><div style>kindly review it and give me feedback so that i can further improve it before the application deadline.</div><div style>Thanks,</div><div style>Vishal Tiwari</div><div class="gmail_extra">
<br><div class="gmail_quote">On 10 April 2013 15:38, Sandro Santilli <span dir="ltr"><<a href="mailto:strk@keybit.net" target="_blank">strk@keybit.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Wed, Apr 10, 2013 at 02:17:44PM +0530, vishal tiwari wrote:<br>
> Hey,<br>
> I suppose only those test cases needs to be ported that correspond to<br>
> Voronoi class. But i see many other test cases for other class that are<br>
> missing. So just asking for clarification, do we need to ported other test<br>
> cases as well?<br>
<br>
</div>For the purpose of Voronoi you only need to port tests for the Voronoi<br>
class and any class used by the Voronoi class. But if you find yourself<br>
having more time porting more tests would be very useful<br>
<div><br>
> And as for the C-API this is what i have understood: it provides a wrapper<br>
> to the C++ functions. All the reference functions are implemented in<br>
> geos_ts_c.cpp. And all the functions that are exposed to the users are in<br>
> geos_c.cpp and its header file, geos_c.h.<br>
<br>
</div>More or less. Actually geos_ts.cpp contains the _Thread_Safe_ (supposedly)<br>
version of the functions. It's been added later so the old API (officially<br>
non thread-safe) is retained. In theory, new functions could STOP exposing<br>
a non-thread-safe version of the signature but I haven't started this to<br>
avoid having a mix of new and old APIs around. So at the moment it's<br>
recommended to always keep both APIs.<br>
<br>
Both TS and non-TS function are found in geos_c.h. The non-TS function are<br>
all simple wrappers to the TS ones.<br>
<div><br>
> Regarding the Gsoc proposal in the 'Describe your idea' section of the<br>
> OSGeo proposal Application, this is what i have thought about from our<br>
> discussion on the project:<br>
><br>
> <a href="https://docs.google.com/document/d/1biGlOqTnS7SnlxPOcFKrxj7_QEMYd1VtAFDms6L3AnY/edit" target="_blank">https://docs.google.com/document/d/1biGlOqTnS7SnlxPOcFKrxj7_QEMYd1VtAFDms6L3AnY/edit</a><br>
<br>
</div>Sounds good to me. Maybe Anne has some suggestions for the<br>
gsoc-specific needs.<br>
<br>
--strk;<br>
<div><div><br>
><br>
><br>
> Looking for your feedback on how it can further be improved.<br>
><br>
><br>
> Thanks and kind regards,<br>
><br>
> Vishal<br>
><br>
><br>
><br>
> *<br>
><br>
><br>
> On 4 April 2013 19:46, Sandro Santilli <<a href="mailto:strk@keybit.net" target="_blank">strk@keybit.net</a>> wrote:<br>
><br>
> > On Thu, Apr 04, 2013 at 05:02:56PM +0530, vishal tiwari wrote:<br>
> > > Hey,<br>
> > > Here is the structure of classes that is required by the *<br>
> > > VoronoiDiagramBuilder* class: (The ones in *bold* needs to be ported)<br>
> > ><br>
> > > 1. Geometry<br>
> > > 2. Geometry Factor<br>
> > > 3. QuadEdgeSubdivision:<br>
> > > - Methods required for *VoronoiDigramBuilder*:<br>
> > > - *getVoronoiDiagram*<br>
> > > - *getVoronoiCellPolugons*<br>
> > > - *getVoronoiCellPolugon*<br>
> > > - visitTriangle<br>
> > > - *getVertexUniqueEdges*<br>
> > > - TriangleCoordinateVisitor<br>
> > > - *TriangleCircumcenterVisitor*<br>
> > > - *TriangleEdgeListVisitor*<br>
> > > - *TriangleVertexListVisitor*<br>
> > > - *isFrameVertex*<br>
> > > 4. TriangleVisitor(Interface)<br>
> > ><br>
> > > Plz let me know if i am missing some method or class which is required<br>
> > > for VoronoiDiagramBuilder port.<br>
> ><br>
> > Again, looking is part of the work.<br>
> > You'll find out as you start porting if anything is missing.<br>
> ><br>
> > > Is it me or its very few work for a Gsoc Project?<br>
> ><br>
> > Don't forget the testcases for the C++ implementation,<br>
> > the C-API exposure and relative testcases and audit for<br>
> > memory leakage.<br>
> ><br>
> > After you've done, if you still have time it'd be nice to<br>
> > work on improving the performance of it :)<br>
> ><br>
> > --strk;<br>
> ><br>
><br>
><br>
><br>
> --<br>
> Vishal Tiwari<br>
> Undergraduate<br>
> Computer Science and Engineering<br>
> Lab for Spatial Informatics<br>
> IIIT-Hyderabad<br>
</div></div><div><div>_______________________________________________<br>
geos-devel mailing list<br>
<a href="mailto:geos-devel@lists.osgeo.org" target="_blank">geos-devel@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/geos-devel" target="_blank">http://lists.osgeo.org/mailman/listinfo/geos-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Vishal Tiwari<div>Undergraduate</div><div>Computer Science and Engineering</div><div>Lab for Spatial Informatics</div><div>IIIT-Hyderabad</div>
</div>
</div></div>