<div dir="ltr">Hey,<div><br></div><div style>In order to submit a subset, should i make different branches in the git repository and send a pull request for each of them separately? Or there is some other way?</div><div style>
<br></div><div style>Thanks,</div><div style>Vishal </div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 23 July 2013 14:05, vishal tiwari <span dir="ltr"><<a href="mailto:hi.vishal123@gmail.com" target="_blank">hi.vishal123@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>I tried to send a pull request for Triangle class, but seems like every commit has been sent for the review(new to git), sorry for that. I ll send it as subsets and i ll clean it as u mentioned before.<br>
</div><div><br></div><div>Thanks,</div><div>Vishal</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On 23 July 2013 11:38, Sandro Santilli <span dir="ltr"><<a href="mailto:strk@keybit.net" target="_blank">strk@keybit.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Vishal, I think the biggest issue so far has been making peer reviewing easy.<br>
One way to improve that would be to cleanup a subset of what you've been<br>
modifying and submit it for inclusion upstream. The subset should be small<br>
enough to be easy to read and complete with testcases. I'm thinking it<br>
could be changes to the Triangle class with its tests, and next one<br>
could maybe be changes to the CoordinateList class, with relative tests.<br>
<br>
Cleaning that up means removing all changes that are not directly<br>
related to the focus of the work. For example making sure that you<br>
don't have style changes for a change that's addressing adding new<br>
functionality. The diff must be _easy_ to read as that gives your<br>
code better opportunities to be commented on.<br>
<br>
Looking forward for your pull request as soon as possible, I'd like<br>
to have the time to merge it in before evaluation time.<br>
<br>
Thank you for the care you'll put into this :)<br>
<br>
--strk;<br>
<div><br>
On Sat, Jul 20, 2013 at 01:45:54AM +0530, vishal tiwari wrote:<br>
> Hey,<br>
><br>
> My week 5 report is as follows:<br>
><br>
</div>> *1. Work Done:*<br>
><br>
> - This week was spent mainly, in fixing the memory leaks and<br>
<div>> segmentation faults. I have tested all the methods and classes that have<br>
> been ported. Everything seems to be working fine. Thus completion of the<br>
> Voronoi port via C++ interface.<br>
><br>
</div>> *2. Problems Faced:*<br>
><br>
> - No problems other than memory leaks and seg faults.<br>
><br>
> *3. Work to be done in the next week:*<br>
><br>
> - Check for bugs because of the coming evaluation.<br>
> - I will look into, how the C-api of geos has been implemented.<br>
<div>><br>
><br>
> wiki link: <a href="http://trac.osgeo.org/geos/wiki/GSoC" target="_blank">http://trac.osgeo.org/geos/wiki/GSoC</a><br>
> Repository link : <a href="https://github.com/vishaltiwari/libgeos" target="_blank">https://github.com/vishaltiwari/libgeos</a><br>
><br>
> Thanks and kind regards,<br>
><br>
> --<br>
> Vishal Tiwari<br>
> Undergraduate<br>
> Computer Science and Engineering<br>
> Lab for Spatial Informatics<br>
> IIIT-Hyderabad<br>
</div><div><div>_______________________________________________<br>
geos-devel mailing list<br>
<a href="mailto:geos-devel@lists.osgeo.org" target="_blank">geos-devel@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/geos-devel" target="_blank">http://lists.osgeo.org/mailman/listinfo/geos-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Vishal Tiwari<div>Undergraduate</div><div>Computer Science and Engineering</div><div>Lab for Spatial Informatics</div><div>IIIT-Hyderabad</div>
</div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Vishal Tiwari<div>Undergraduate</div><div>Computer Science and Engineering</div><div>Lab for Spatial Informatics</div><div>IIIT-Hyderabad</div>
</div>
</div>