<div dir="ltr">Hi,<div><br></div><div>You had earlier pointed out that initGEOS signature cannot be changed so the PrecisionModel parameters cannot be the parameters of a context. So according Sean Gillies requirements, a default geometry factory will be created first and later the precision model can be changed. Something similar to this: </div>
<div>handle->geomFactory = GeometryFactory ( const PrecisionModel * pm)</div><div><br></div><div>Now coming to what happens to previously set PrecisionModel. If I am not wrong, a copy of the PrecisionModel is made, so deleting the previously set PrecisionModel should not make a problem.</div>
<div><br></div><div>Regards,</div><div>Varun Saraf</div><div><br></div><div><div class="gmail_extra"><div class="gmail_quote">On Fri, Mar 7, 2014 at 1:46 PM, Sandro Santilli <span dir="ltr"><<a href="mailto:strk@keybit.net" target="_blank">strk@keybit.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">On Fri, Mar 07, 2014 at 12:54:19AM +0530, Varun Saraf wrote:<br>
<br>
> I have made a temporary proposal. Below is the link to the wiki page.<br>
><br>
> <a href="http://trac.osgeo.org/geos/wiki/GSoC/CAPI_PrecisionModel" target="_blank">http://trac.osgeo.org/geos/wiki/GSoC/CAPI_PrecisionModel</a><br>
<br>
</div>You propose to expose a new "PrecisionModel" object, but not<br>
the exposure of a "GeometryFactory" ? Is that correct ?<br>
<br>
Did you understand the proposal of Sean Gillies ?<br>
He proposed to expose no new objects, but simply pretend the<br>
"PrecisionModel" parameters are really parameters of a "context".<br>
<br>
What problems do you see with that proposal ?<br>
Have you read the problems I individuated about that ?<br>
Can you think about solutions to them ?<br>
<br>
--strk;<br>
<div class=""><div class="h5"><br>
> On Thu, Mar 6, 2014 at 5:44 PM, Sandro Santilli <<a href="mailto:strk@keybit.net">strk@keybit.net</a>> wrote:<br>
><br>
> > On Thu, Mar 06, 2014 at 05:23:43PM +0530, Varun Saraf wrote:<br>
> > > Hi,<br>
> > ><br>
> > > We either create the PrecisionModel and the GeometryFactory in the<br>
> > > GEOSContext_setPrecisionModel or pass a pointer to the<br>
> > > new PrecisionModel to this method. But the signature of<br>
> > initGEOS/initGEOS_r<br>
> > > cannot be changed so how to pass it to the initGEOS. Please clarify.<br>
> ><br>
> > Please make proposals.<br>
> > My proposal was in the mail you quoted, did you understand it ?<br>
> ><br>
> > --strk;<br>
> ><br>
> > > On Thu, Feb 20, 2014 at 12:00 PM, Sandro Santilli <<a href="mailto:strk@keybit.net">strk@keybit.net</a>><br>
> > wrote:<br>
> > > ><br>
> > > > I agree about making the precision model part of the context.<br>
> > > > But we can't change the initGEOS signature, so we'll need<br>
> > > > some GEOSContext_setPrecisionModel kind of method.<br>
> > > > At that point, we have to decide what happens with a previously<br>
> > > > set PrecisionModel, if it has to be allowed at all.<br>
> > > ><br>
> > > > Deleting the PrecisionModel and the GeometryFactory on finishGEOS<br>
> > > > is fine, but note that this would make any created geometry also<br>
> > > > broken (they hold a reference to the GeometryFactory that created<br>
> > > > them). Not a big deal, as long as it's clearely documented. Dunno<br>
> > > > if it would make sense for the opaque GEOSGeometry type to also<br>
> > > > hold a pointer to the context, just in case...<br>
> > _______________________________________________<br>
> > geos-devel mailing list<br>
> > <a href="mailto:geos-devel@lists.osgeo.org">geos-devel@lists.osgeo.org</a><br>
> > <a href="http://lists.osgeo.org/mailman/listinfo/geos-devel" target="_blank">http://lists.osgeo.org/mailman/listinfo/geos-devel</a><br>
> ><br>
<br>
> _______________________________________________<br>
> geos-devel mailing list<br>
> <a href="mailto:geos-devel@lists.osgeo.org">geos-devel@lists.osgeo.org</a><br>
> <a href="http://lists.osgeo.org/mailman/listinfo/geos-devel" target="_blank">http://lists.osgeo.org/mailman/listinfo/geos-devel</a><br>
<br>
<br>
</div></div><div class="im">--<br>
<br>
() ASCII ribbon campaign -- Keep it simple !<br>
/\ <a href="http://strk.keybit.net/rants/ascii_mails.txt" target="_blank">http://strk.keybit.net/rants/ascii_mails.txt</a><br>
</div><div class=""><div class="h5">_______________________________________________<br>
geos-devel mailing list<br>
<a href="mailto:geos-devel@lists.osgeo.org">geos-devel@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/geos-devel" target="_blank">http://lists.osgeo.org/mailman/listinfo/geos-devel</a><br>
</div></div></blockquote></div><br></div></div></div>