<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 10/6/2017 2:13 PM, Even Rouault wrote:<br>
<blockquote type="cite" cite="mid:29003962.Qj20OlUqS0@even-i700">
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">> 1) It's just a warning that shows when
compiling code that uses the C++ API</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">> so doesn't impact existing compiles. No
one has to change their compile</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">> scripts.</p>
<p style="-qt-paragraph-type:empty; margin-top:0px;
margin-bottom:0px; margin-left:0px; margin-right:0px;
-qt-block-indent:0; text-indent:0px; "> </p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">Not that I'd be impacted myself, but that is
not true if they build with</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">-Werror, or expect that their build log
remains clean if it was already.</p>
</blockquote>
<br>
Yes - and for development and CI this is a good practice. That's why
I think it's better to avoid adding this to old versions. It's not a
versioning violating, but it will require some people to change
scripts.<br>
<br>
<blockquote type="cite" cite="mid:29003962.Qj20OlUqS0@even-i700">
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;">(but my experience building GDAL with -Werror
and most pedantic warnings turned on has demonstrated that for a
lot of packages you have to include external headers with
compiler mechanism to temporarily turn off warnings due to them)</p>
<p style="-qt-paragraph-type:empty; margin-top:0px;
margin-bottom:0px; margin-left:0px; margin-right:0px;
-qt-block-indent:0; text-indent:0px; "> </p>
</blockquote>
<br>
GEOS, GDAL, and other system libraries should be included with
-isystem. This will stop warnings being generated for questionable
syntax, etc. I don't think it will suppress warnings that *are*
generated, such as in this case where there's an explicit
preprocessor directive.<br>
</body>
</html>