<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:989166389;
mso-list-type:hybrid;
mso-list-template-ids:1658356036 67698703 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I just started working with version 3.8.0, trying to build it on Windows. I ran into two issues:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<ol style="margin-top:0in" start="1" type="1">
<li class="MsoListParagraph" style="margin-left:0in;mso-list:l0 level1 lfo1">Out of the box I can’t build geos 3.8.0 with a fully-updated Visual Studio 2017, because geos wants cmake 3.13 and VS2017 only has 3.12. If I change line 22 of the top-level CMakeLists.txt
to require only 3.12, then I can build fine in Release mode, either 32 or 64 bit, and ctest shows no failures.<o:p></o:p></li><li class="MsoListParagraph" style="margin-left:0in;mso-list:l0 level1 lfo1">If I build in Debug mode, with either VS2017 or VS2019, I get tons of assertion failures when I do ctest. They all come from line 115 of MonotoneChainBuilder.cpp, which on the last
time through the loop causes an access of an element one past the end of a std::vector. Even if I ignore the assertion failures, the tests show as fails because the C runtime considers these to be fatal errors.<o:p></o:p></li></ol>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Below is a patch that fixes these issues. Are these reasonable workarounds?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks!<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Asa<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Index: geos-3.8.0/CMakeLists.txt<o:p></o:p></p>
<p class="MsoNormal">===================================================================<o:p></o:p></p>
<p class="MsoNormal">--- geos-3.8.0/CMakeLists.txt<o:p></o:p></p>
<p class="MsoNormal">+++ geos-3.8.0/CMakeLists.tt<o:p></o:p></p>
<p class="MsoNormal">@@ -19,7 +19,7 @@<o:p></o:p></p>
<p class="MsoNormal"># Require CMake 3.13+ with VS generator for complete support of VS versions<o:p></o:p></p>
<p class="MsoNormal"># and support by AppVeyor.<o:p></o:p></p>
<p class="MsoNormal">if(${CMAKE_GENERATOR} MATCHES "Visual Studio")<o:p></o:p></p>
<p class="MsoNormal">- cmake_minimum_required(VERSION 3.13 FATAL_ERROR)<o:p></o:p></p>
<p class="MsoNormal">+ cmake_minimum_required(VERSION 3.12 FATAL_ERROR)<o:p></o:p></p>
<p class="MsoNormal">endif()<o:p></o:p></p>
<p class="MsoNormal"><o:p></o:p></p>
<p class="MsoNormal"> list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake")<o:p></o:p></p>
<p class="MsoNormal">Index: geos-3.8.0/src/index/chain/MonotoneChainBuilder.cpp<o:p></o:p></p>
<p class="MsoNormal">===================================================================<o:p></o:p></p>
<p class="MsoNormal">--- geos-3.8.0/src/index/chain/MonotoneChainBuilder.cpp<o:p></o:p></p>
<p class="MsoNormal">+++ geos-3.8.0/src/index/chain/MonotoneChainBuilder.cpp<o:p></o:p></p>
<p class="MsoNormal">@@ -111,8 +111,10 @@<o:p></o:p></p>
<p class="MsoNormal"> }<o:p></o:p></p>
<p class="MsoNormal"> }<o:p></o:p></p>
<p class="MsoNormal"> ++last;<o:p></o:p></p>
<p class="MsoNormal">- prev = curr;<o:p></o:p></p>
<p class="MsoNormal">- curr = &pts[last];<o:p></o:p></p>
<p class="MsoNormal">+ if (last < npts) {<o:p></o:p></p>
<p class="MsoNormal">+ prev = curr;<o:p></o:p></p>
<p class="MsoNormal">+ curr = &pts[last];<o:p></o:p></p>
<p class="MsoNormal">+ }<o:p></o:p></p>
<p class="MsoNormal"> }<o:p></o:p></p>
<p class="MsoNormal">#if GEOS_DEBUG<o:p></o:p></p>
<p class="MsoNormal"> std::cerr << "MonotoneChainBuilder::findChainEnd() returning" << std::endl;<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto"><b><span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#225EAC">Asa Packer</span></b><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:#225EAC"> </span><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:#BABABA">|</span><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:#225EAC"> Lead
Systems Engineer<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><b><span style="font-size:8.5pt;font-family:"Verdana",sans-serif;color:#7D7D7D"><o:p> </o:p></span></b></p>
<p class="MsoNormal" style="background:white"><b><span style="font-size:8.5pt;font-family:"Verdana",sans-serif;color:#7D7D7D">BioSonics, Inc.</span></b><span style="font-size:8.5pt;font-family:"Verdana",sans-serif;color:#7D7D7D"> <o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="font-size:8.5pt;font-family:"Verdana",sans-serif;color:#7D7D7D">2356 W Commodore Way, Unit 110<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="font-size:8.5pt;font-family:"Verdana",sans-serif;color:#7D7D7D">Seattle WA 98199-1258 USA<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><b><span style="font-size:8.5pt;font-family:"Verdana",sans-serif;color:#46C3D2">tel</span></b><span style="font-size:8.5pt;font-family:"Verdana",sans-serif;color:#7D7D7D"> 206.782.2211
</span><span style="font-size:8.5pt;font-family:"Verdana",sans-serif;color:#BABABA">|</span><span style="font-size:8.5pt;font-family:"Verdana",sans-serif;color:#7D7D7D">
</span><span style="font-size:8.5pt;font-family:"Verdana",sans-serif;color:black"><a href="http://www.biosonicsinc.com/" target="_blank"><b><span style="color:#46C3D2">biosonicsinc.com</span></b></a><o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>