<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">No objection. I’m not sure how it got bumped so high to start w/.<div class="">BTW, how do you confirm what feature set we’re using? Is there a magic test?</div><div class="">P<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 23, 2019, at 6:13 PM, Daniel Baston <<a href="mailto:dbaston@gmail.com" class="">dbaston@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hello Asa,<div class=""><br class=""></div><div class="">Thank you for the reports. I ticketed the assertion failure issue at: <a href="https://trac.osgeo.org/geos/ticket/1002" class="">https://trac.osgeo.org/geos/ticket/1002</a></div><div class=""><br class=""></div><div class="">I'm not sure why the CMake version check for MSVC needs to be a fatal error, since we're not using any features from CMake > 3.8. Does anyone object to changing this?</div><div class=""><br class=""></div><div class="">Dan</div><div class=""><br class=""></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 21, 2019 at 3:14 PM Asa Packer <<a href="mailto:APacker@biosonicsinc.com" class="">APacker@biosonicsinc.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US" class="">
<div class="gmail-m_4313905844877912698WordSection1"><p class="MsoNormal">Hi,<u class=""></u><u class=""></u></p><p class="MsoNormal"><u class=""></u> <u class=""></u></p><p class="MsoNormal">I just started working with version 3.8.0, trying to build it on Windows. I ran into two issues:<u class=""></u><u class=""></u></p><p class="MsoNormal"><u class=""></u> <u class=""></u></p>
<ol style="margin-top:0in" start="1" type="1" class="">
<li class="gmail-m_4313905844877912698MsoListParagraph" style="margin-left:0in">Out of the box I can’t build geos 3.8.0 with a fully-updated Visual Studio 2017, because geos wants cmake 3.13 and VS2017 only has 3.12. If I change line 22 of the top-level CMakeLists.txt
to require only 3.12, then I can build fine in Release mode, either 32 or 64 bit, and ctest shows no failures.<u class=""></u><u class=""></u></li><li class="gmail-m_4313905844877912698MsoListParagraph" style="margin-left:0in">If I build in Debug mode, with either VS2017 or VS2019, I get tons of assertion failures when I do ctest. They all come from line 115 of MonotoneChainBuilder.cpp, which on the last
time through the loop causes an access of an element one past the end of a std::vector. Even if I ignore the assertion failures, the tests show as fails because the C runtime considers these to be fatal errors.<u class=""></u><u class=""></u></li></ol><p class="MsoNormal"><u class=""></u> <u class=""></u></p><p class="MsoNormal">Below is a patch that fixes these issues. Are these reasonable workarounds?<u class=""></u><u class=""></u></p><p class="MsoNormal"><u class=""></u> <u class=""></u></p><p class="MsoNormal">Thanks!<u class=""></u><u class=""></u></p><p class="MsoNormal"><u class=""></u> <u class=""></u></p><p class="MsoNormal">Asa<u class=""></u><u class=""></u></p><p class="MsoNormal"><u class=""></u> <u class=""></u></p><p class="MsoNormal">Index: geos-3.8.0/CMakeLists.txt<u class=""></u><u class=""></u></p><p class="MsoNormal">===================================================================<u class=""></u><u class=""></u></p><p class="MsoNormal">--- geos-3.8.0/CMakeLists.txt<u class=""></u><u class=""></u></p><p class="MsoNormal">+++ geos-3.8.0/CMakeLists.tt<u class=""></u><u class=""></u></p><p class="MsoNormal">@@ -19,7 +19,7 @@<u class=""></u><u class=""></u></p><p class="MsoNormal"># Require CMake 3.13+ with VS generator for complete support of VS versions<u class=""></u><u class=""></u></p><p class="MsoNormal"># and support by AppVeyor.<u class=""></u><u class=""></u></p><p class="MsoNormal">if(${CMAKE_GENERATOR} MATCHES "Visual Studio")<u class=""></u><u class=""></u></p><p class="MsoNormal">- cmake_minimum_required(VERSION 3.13 FATAL_ERROR)<u class=""></u><u class=""></u></p><p class="MsoNormal">+ cmake_minimum_required(VERSION 3.12 FATAL_ERROR)<u class=""></u><u class=""></u></p><p class="MsoNormal">endif()<u class=""></u><u class=""></u></p><p class="MsoNormal"><u class=""></u><u class=""></u></p><p class="MsoNormal"> list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake")<u class=""></u><u class=""></u></p><p class="MsoNormal">Index: geos-3.8.0/src/index/chain/MonotoneChainBuilder.cpp<u class=""></u><u class=""></u></p><p class="MsoNormal">===================================================================<u class=""></u><u class=""></u></p><p class="MsoNormal">--- geos-3.8.0/src/index/chain/MonotoneChainBuilder.cpp<u class=""></u><u class=""></u></p><p class="MsoNormal">+++ geos-3.8.0/src/index/chain/MonotoneChainBuilder.cpp<u class=""></u><u class=""></u></p><p class="MsoNormal">@@ -111,8 +111,10 @@<u class=""></u><u class=""></u></p><p class="MsoNormal"> }<u class=""></u><u class=""></u></p><p class="MsoNormal"> }<u class=""></u><u class=""></u></p><p class="MsoNormal"> ++last;<u class=""></u><u class=""></u></p><p class="MsoNormal">- prev = curr;<u class=""></u><u class=""></u></p><p class="MsoNormal">- curr = &pts[last];<u class=""></u><u class=""></u></p><p class="MsoNormal">+ if (last < npts) {<u class=""></u><u class=""></u></p><p class="MsoNormal">+ prev = curr;<u class=""></u><u class=""></u></p><p class="MsoNormal">+ curr = &pts[last];<u class=""></u><u class=""></u></p><p class="MsoNormal">+ }<u class=""></u><u class=""></u></p><p class="MsoNormal"> }<u class=""></u><u class=""></u></p><p class="MsoNormal">#if GEOS_DEBUG<u class=""></u><u class=""></u></p><p class="MsoNormal"> std::cerr << "MonotoneChainBuilder::findChainEnd() returning" << std::endl;<u class=""></u><u class=""></u></p><p class="MsoNormal"><u class=""></u> <u class=""></u></p><p class="MsoNormal"><u class=""></u> <u class=""></u></p><p class="MsoNormal"><b class=""><span style="font-size:10pt;font-family:Verdana,sans-serif;color:rgb(34,94,172)" class="">Asa Packer</span></b><span style="font-size:9pt;font-family:Verdana,sans-serif;color:rgb(34,94,172)" class=""> </span><span style="font-size:9pt;font-family:Verdana,sans-serif;color:rgb(186,186,186)" class="">|</span><span style="font-size:9pt;font-family:Verdana,sans-serif;color:rgb(34,94,172)" class=""> Lead
Systems Engineer<u class=""></u><u class=""></u></span></p><p class="MsoNormal" style="background:white"><b class=""><span style="font-size:8.5pt;font-family:Verdana,sans-serif;color:rgb(125,125,125)" class=""><u class=""></u> <u class=""></u></span></b></p><p class="MsoNormal" style="background:white"><b class=""><span style="font-size:8.5pt;font-family:Verdana,sans-serif;color:rgb(125,125,125)" class="">BioSonics, Inc.</span></b><span style="font-size:8.5pt;font-family:Verdana,sans-serif;color:rgb(125,125,125)" class=""> <u class=""></u><u class=""></u></span></p><p class="MsoNormal" style="background:white"><span style="font-size:8.5pt;font-family:Verdana,sans-serif;color:rgb(125,125,125)" class="">2356 W Commodore Way, Unit 110<u class=""></u><u class=""></u></span></p><p class="MsoNormal" style="background:white"><span style="font-size:8.5pt;font-family:Verdana,sans-serif;color:rgb(125,125,125)" class="">Seattle WA 98199-1258 USA<u class=""></u><u class=""></u></span></p><p class="MsoNormal" style="margin-bottom:12pt;background:white"><b class=""><span style="font-size:8.5pt;font-family:Verdana,sans-serif;color:rgb(70,195,210)" class="">tel</span></b><span style="font-size:8.5pt;font-family:Verdana,sans-serif;color:rgb(125,125,125)" class=""> 206.782.2211
</span><span style="font-size:8.5pt;font-family:Verdana,sans-serif;color:rgb(186,186,186)" class="">|</span><span style="font-size:8.5pt;font-family:Verdana,sans-serif;color:rgb(125,125,125)" class="">
</span><span style="font-size: 8.5pt; font-family: Verdana, sans-serif;" class=""><a href="http://www.biosonicsinc.com/" target="_blank" class=""><b class=""><span style="color:rgb(70,195,210)" class="">biosonicsinc.com</span></b></a><u class=""></u><u class=""></u></span></p><p class="MsoNormal"><u class=""></u> <u class=""></u></p>
</div>
</div>
_______________________________________________<br class="">
geos-devel mailing list<br class="">
<a href="mailto:geos-devel@lists.osgeo.org" target="_blank" class="">geos-devel@lists.osgeo.org</a><br class="">
<a href="https://lists.osgeo.org/mailman/listinfo/geos-devel" rel="noreferrer" target="_blank" class="">https://lists.osgeo.org/mailman/listinfo/geos-devel</a></blockquote></div>
_______________________________________________<br class="">geos-devel mailing list<br class=""><a href="mailto:geos-devel@lists.osgeo.org" class="">geos-devel@lists.osgeo.org</a><br class="">https://lists.osgeo.org/mailman/listinfo/geos-devel</div></blockquote></div><br class=""></div></body></html>