<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Paul,</p>
<p>no impact for GDAL test suite. It tests MakeValid() in a very
light way (using mostly the "hourglass" looking invalid polygon)</p>
<p>Even<br>
</p>
<div class="moz-cite-prefix">Le 19/04/2021 à 22:44, Paul Ramsey a
écrit :<br>
</div>
<blockquote type="cite"
cite="mid:CACowWR03Pxh49hCkUw0J1mxb1=GVsTXjZm4mTkaXky5cQMicfA@mail.gmail.com">
<div dir="ltr">
<div>Important question for downstream maintainers: how wedded
are you to current 'makevalid' output? If you have tests of
'makevalid' right now, and we replaced the default behaviour
with the GeometryFixer, you'd get different looking (valid)
results. <br>
</div>
<div><br>
</div>
<div><a
href="https://github.com/libgeos/geos/pull/433#issuecomment-821597724"
moz-do-not-send="true">https://github.com/libgeos/geos/pull/433#issuecomment-821597724</a></div>
<div><br>
</div>
<div>However different looking, they are in many cases "more
right" looking (in some cases there's no obviously "right"
answer, but in many there are ones with more rightnesss). In
general the processing in geometryfixer should be faster too
(fewer big overlay ops in total).</div>
<div><br>
</div>
<div>But still: different. All those unit tests. <br>
</div>
<div><br>
</div>
<div>What's your tradeoff?</div>
<div><br>
</div>
<div>P<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Apr 16, 2021 at 1:05
PM Martin Davis <<a href="mailto:mtnclimb@gmail.com"
moz-do-not-send="true">mtnclimb@gmail.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote">
<div dir="ltr">JTS recently had a class called GeometryFixer
added. The class provides functionality to accept any
invalid geometry and convert it to a valid one. This plugs
a noticeable gap in the JTS API!
<div><br>
</div>
<div>Paul R has ported this to GEOS: <a
href="https://github.com/libgeos/geos/pull/433"
target="_blank" moz-do-not-send="true">https://github.com/libgeos/geos/pull/433</a><br>
</div>
<div><br>
</div>
<div>It performs a similar function to the existing GEOS
MakeValid (which was a port of the PostGIS ST_MakeValid).
But it has some differences in semantics which are simpler
and (hopefully) a useful alternative.
<div><br>
</div>
<div>See the PR for links to documentation of the
functionality of GeometryFixer (and there will be more
docs and images coming soon).</div>
<div><br>
</div>
<div>Feedback is welcome, as always.</div>
<div> </div>
<div><br>
</div>
<div><br>
</div>
</div>
</div>
_______________________________________________<br>
geos-devel mailing list<br>
<a href="mailto:geos-devel@lists.osgeo.org" target="_blank"
moz-do-not-send="true">geos-devel@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/geos-devel"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.osgeo.org/mailman/listinfo/geos-devel</a><br>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
geos-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:geos-devel@lists.osgeo.org">geos-devel@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/geos-devel">https://lists.osgeo.org/mailman/listinfo/geos-devel</a>
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
<a class="moz-txt-link-freetext" href="http://www.spatialys.com">http://www.spatialys.com</a>
My software is free, but my time generally not.</pre>
</body>
</html>