<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>I’m fine with the behavior changing and agree it makes sense. Only issue is with it breaking someone’s existing good. Though I’d doubt if anyone would rely on that as an output, but you never know.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>I think it’s still good to have a test for it in GEOS to catch these, so it can at least be noted in notes as a breaking change.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>I’ll take the test out of PostGIS if the behavior is kept in GEOS.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Regina<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'> geos-devel [mailto:geos-devel-bounces@lists.osgeo.org] <b>On Behalf Of </b>Martin Davis<br><b>Sent:</b> Friday, October 21, 2022 12:48 PM<br><b>To:</b> GEOS Development List <geos-devel@lists.osgeo.org><br><b>Subject:</b> Re: [geos-devel] GEOS 3.12 regression failure in PostGIS<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Validity is only tested in the XY dimensions. So it's actually more appropriate that only the XY value is reported.<o:p></o:p></p></div><p class=MsoNormal><o:p> </o:p></p><div><div><p class=MsoNormal>On Fri, Oct 21, 2022 at 7:35 AM Regina Obe <<a href="mailto:lr@pcorp.us">lr@pcorp.us</a>> wrote:<o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal>Hi all,<br><br>PostGIS geos310 regression test, detailed here:<br><br><a href="https://trac.osgeo.org/postgis/ticket/5260" target="_blank">https://trac.osgeo.org/postgis/ticket/5260</a><br><br>Started failing around October 18th.<br><br>The test is this:<br>SELECT '#168', ST_NPoints(g), ST_AsText(g), ST_isValidReason(g)<br>FROM ( VALUES<br>('01060000C00100000001030000C00100000003000000E3D9107E234F5041A3DB66BC97A30F<br>4122ACEF440DAF9440FFFFFFFFFFFFEFFFE3D9107E234F5041A3DB66BC97A30F4122ACEF440D<br>AF9440FFFFFFFFFFFFEFFFE3D9107E234F5041A3DB66BC97A30F4122ACEF440DAF9440FFFFFF<br>FFFFFFEFFF'::geometry)<br>) AS v(g);<br><br><br>I'm guessing might be caused by this commit -<br><a href="https://github.com/libgeos/geos/commit/32348a68c5212c89cfefab46891d2b3aada4ab40" target="_blank">https://github.com/libgeos/geos/commit/32348a68c5212c89cfefab46891d2b3aada4a<br>b40</a> <br>which happened around the same time tests started failing.<br><br>The difference from prior versions is that the 3.12 (main branch) now emits<br>for isValidReason one less coordinate<br><br>Too few points in geometry component[4275341.96977851 259186.966993061]<br><br>Instead of:<br>Too few points in geometry component[4275341.96977851 259186.966993061<br>1323.76295828331]<br><br><br>Which to me makes sense if we are only considering 2 dimensions for<br>validity.<br><br>Before I change the test, I want to confirm that this is an intentional<br>change.<br><br>Thanks,<br>Regina<br><br><br><br>_______________________________________________<br>geos-devel mailing list<br><a href="mailto:geos-devel@lists.osgeo.org" target="_blank">geos-devel@lists.osgeo.org</a><br><a href="https://lists.osgeo.org/mailman/listinfo/geos-devel" target="_blank">https://lists.osgeo.org/mailman/listinfo/geos-devel</a><o:p></o:p></p></blockquote></div></div></div></body></html>