<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Dieter<br>
<br>
Very good catch, I own you my congratulation! (as it was deep in the
code). This bug has been introduced when we migrated from <tt>javax.vecmath</tt>
matrices to the Apache SIS matrices. Vecmath performed the
multiplication in-place (overwriting the source matrix) while SIS
returns the result in a new matrix. In the migration to SIS, we
forgot to assign the result in this particular place.<br>
<br>
I just fixed the bug and pushed the fix to GitHub. Would you have a
chance to test again?<br>
<br>
On the code accuracy, the testing effort has shifted to Apache SIS.
Some Geotk tests have been ignored because I was planning to review
them in depth when those parts will migrate to SIS (SIS has a more
reproductive testing environment with better diagnostics in case of
failure).<br>
<br>
My apologize for the inconvenience...<br>
<br>
Martin<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">Le 05/09/14 14:13, Dieter Stüken a
écrit :<br>
<br>
</div>
<blockquote
cite="mid:18C8C3682054CB48990864C67A009E123C3054AC@hydra.esri-de.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from rtf -->
<style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
<font face="Arial" size="2"><span style="font-size:11pt;">
<div>Hi,</div>
<div><font face="Calibri"> </font></div>
<div>I participate on developing some frequency-analysis
software tool (Java) for about ten years now:</div>
<div><font face="Calibri"><a moz-do-not-send="true"
href="http://www.irt.de/en/activities/programme-distribution/frequency-planning-software.html"><font
color="#0563C1" face="Arial"><u>http://www.irt.de/en/activities/programme-distribution/frequency-planning-software.html</u></font></a><font
face="Arial">
</font></font></div>
<div><font face="Calibri"> </font></div>
<div>We have a lot of legacy code on board, but we also try to
introduce advanced technologies. </div>
<div>We switched to Java8 already and started using JavaFX
instead of Swing, since it is (still) a desktop
application….</div>
<div><font face="Calibri"> </font></div>
<div>I observe the development of Geotk and SIS since a year,
and the transition to SIS has many ideas in common with our
current approach.</div>
<div>So my first try was to use the referencing module to
replace our internal coordinate transformations.</div>
<div>Our current implementation depends on a very old
geotoolkit version I want to get rid of.</div>
<div><font face="Calibri"> </font></div>
<div>Since we use only a small set of CRs (about 5-6) those
are hardcoded and I don’t like to involve the full EPSG
database.</div>
<div>Unfortunately I did not get the datum shift working. </div>
<div><font face="Calibri"> </font></div>
<div>I tracked it down to where the transformation matrices
are build and ended up here:</div>
<div><font face="Calibri"> </font></div>
<div><font face="Calibri"><a moz-do-not-send="true"
href="https://github.com/Geomatys/geotoolkit/blob/master/modules/referencing/geotk-referencing/src/main/java/org/geotoolkit/referencing/operation/DefaultCoordinateOperationFactory.java#L1080"><font
color="#0563C1" face="Arial"><u>https://github.com/Geomatys/geotoolkit/blob/master/modules/referencing/geotk-referencing/src/main/java/org/geotoolkit/referencing/operation/DefaultCoordinateOperationFactory.java#L1080</u></font></a></font></div>
<div><font face="Calibri"> </font></div>
<div>which performs the concatenation but finally does not use
the result matrix returned <font face="Wingdings">L</font></div>
<div><font face="Calibri"> </font></div>
<div>I even found a unit test for this:</div>
<div><font face="Calibri"> </font></div>
<div><font face="Calibri"><a moz-do-not-send="true"
href="https://github.com/Geomatys/geotoolkit/blob/master/modules/referencing/geotk-referencing/src/test/java/org/geotoolkit/referencing/operation/COFactoryUsingMolodenskyTest.java#L451"><font
color="#0563C1" face="Arial"><u>https://github.com/Geomatys/geotoolkit/blob/master/modules/referencing/geotk-referencing/src/test/java/org/geotoolkit/referencing/operation/COFactoryUsingMolodenskyTest.java#L451</u></font></a><font
face="Arial">
</font></font></div>
<div><font face="Calibri"> </font></div>
<div>but unfortunately it is @Ignored.</div>
<div> </div>
<div>Do I miss something?</div>
<div><font face="Calibri"> </font></div>
<div>Dieter.</div>
</span></font></blockquote>
<br>
</body>
</html>