[GRASS-git] [OSGeo/grass] 772b64: check: add -Wpendantic compiler flag to CI builds

Nicklas Larsson noreply at github.com
Wed Nov 22 04:14:59 PST 2023 

  Branch: refs/heads/fix_external_warnings
  Home:   https://github.com/OSGeo/grass
  Commit: 772b64d5bc29052344f1146266cf7b95521baa04
      https://github.com/OSGeo/grass/commit/772b64d5bc29052344f1146266cf7b95521baa04
  Author: Nicklas Larsson <n_larsson at yahoo.com>
  Date:   2023-11-18 (Sat, 18 Nov 2023)

  Changed paths:
    M .github/workflows/build_ubuntu-22.04.sh
    M .github/workflows/gcc.yml
    M .github/workflows/macos_install.sh
    M include/grass/vect/dig_defines.h

  Log Message:
  -----------
  check: add -Wpendantic compiler flag to CI builds


  Commit: ec4081702dd2bd2577251e7b02b2c3591a12ffc4
      https://github.com/OSGeo/grass/commit/ec4081702dd2bd2577251e7b02b2c3591a12ffc4
  Author: Nicklas Larsson <n_larsson at yahoo.com>
  Date:   2023-11-18 (Sat, 18 Nov 2023)

  Changed paths:

  Log Message:
  -----------
  Merge branch 'fix_external_warnings' of ssh://github.com/OSGeo/grass into fix_external_warnings


  Commit: 6164ea14182862678a6366ee4e6b3894af5e5292
      https://github.com/OSGeo/grass/commit/6164ea14182862678a6366ee4e6b3894af5e5292
  Author: Yann Chemin <dr.yann.chemin at gmail.com>
  Date:   2023-11-19 (Sun, 19 Nov 2023)

  Changed paths:
    M contributors.csv

  Log Message:
  -----------
  Update contributors.csv: Yann Chemin (#3244)


  Commit: 97da922159ded9590b354527441972fa0490d169
      https://github.com/OSGeo/grass/commit/97da922159ded9590b354527441972fa0490d169
  Author: Huidae Cho <grass4u at gmail.com>
  Date:   2023-11-19 (Sun, 19 Nov 2023)

  Changed paths:
    M scripts/v.db.join/v.db.join.py

  Log Message:
  -----------
  v.db.join: Add exclude_columns= option (#3174)


  Commit: b3ef90b3db64372006432310c370386dd4a553ab
      https://github.com/OSGeo/grass/commit/b3ef90b3db64372006432310c370386dd4a553ab
  Author: Tomas Zigo <50632337+tmszi at users.noreply.github.com>
  Date:   2023-11-19 (Sun, 19 Nov 2023)

  Changed paths:
    M utils/mkhtml.py

  Log Message:
  -----------
  utils: fix add HTML module man page Source code section for all module HTML files (#3248)

* utils: fix add HTML module man page Source code section for all module HTML files

* Source code section start on the new line


  Commit: fb083e16556107752d163ecdbe8fd2a8d1e22f86
      https://github.com/OSGeo/grass/commit/fb083e16556107752d163ecdbe8fd2a8d1e22f86
  Author: Markus Neteler <neteler at osgeo.org>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M vector/v.clean/main.c

  Log Message:
  -----------
  v.clean threshold description: clarify map units (#2950)

* v.clean threshold description: clarify map units

This PR de-confuses the current description of `threshold` from the misleading

```
  threshold   Threshold in map units, one value for each tool
```

to

```
  threshold   One value for each tool; for threshold units, see each tool
```

The point is that users need to look it up in the manual page.
Esp. in long-lat locations, map units for area based tools are to be given in sqm.


  Commit: a21ecf1695c02fb92b98d27a055874ba27ca15b7
      https://github.com/OSGeo/grass/commit/a21ecf1695c02fb92b98d27a055874ba27ca15b7
  Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M Dockerfile
    M docker/ubuntu/Dockerfile

  Log Message:
  -----------
  CI(deps): Update docker/dockerfile Docker tag to v1.6 (#3240)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


  Commit: 6a4b46d6dcb0e3b3d0bca18678c950ee748ba4c9
      https://github.com/OSGeo/grass/commit/6a4b46d6dcb0e3b3d0bca18678c950ee748ba4c9
  Author: Vaclav Petras <wenzeslaus at gmail.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M display/d.legend.vect/draw.c

  Log Message:
  -----------
  d.legend.vect: Initialize title size (#3095)

Later test (line 270) uses title width to compute background size regardless of title presence, but original code initialized title_w only when title was set.

This fixes occasional extra wide legend background rectangle.

Identified by valgrind as: Conditional jump or move depends on uninitialized value(s).


  Commit: 765b2e9c0a2d9346d0d593be65b253068f3e5606
      https://github.com/OSGeo/grass/commit/765b2e9c0a2d9346d0d593be65b253068f3e5606
  Author: Nicklas Larsson <n_larsson at yahoo.com>
  Date:   2023-11-21 (Tue, 21 Nov 2023)

  Changed paths:
    M include/grass/defs/vector.h
    M lib/vector/Vlib/area.c
    M lib/vector/Vlib/area_pg.c
    M lib/vector/Vlib/array.c
    M lib/vector/Vlib/box.c
    M lib/vector/Vlib/buffer2.c
    M lib/vector/Vlib/build.c
    M lib/vector/Vlib/build_sfa.c
    M lib/vector/Vlib/cindex.c
    M lib/vector/Vlib/close.c
    M lib/vector/Vlib/constraint.c
    M lib/vector/Vlib/copy.c
    M lib/vector/Vlib/dbcolumns.c
    M lib/vector/Vlib/field.c
    M lib/vector/Vlib/geos_to_wktb.c
    M lib/vector/Vlib/header.c
    M lib/vector/Vlib/header_finfo.c
    M lib/vector/Vlib/hist.c
    M lib/vector/Vlib/init_head.c
    M lib/vector/Vlib/level.c
    M lib/vector/Vlib/level_two.c
    M lib/vector/Vlib/line.c
    M lib/vector/Vlib/local_proto.h
    M lib/vector/Vlib/net_analyze.c
    M lib/vector/Vlib/open.c
    M lib/vector/Vlib/pg_local_proto.h
    M lib/vector/Vlib/poly.c
    M lib/vector/Vlib/read.c
    M lib/vector/Vlib/read_ogr.c
    M lib/vector/Vlib/simple_features.c
    M lib/vector/Vlib/write.c
    M lib/vector/Vlib/write_nat.c
    M lib/vector/Vlib/write_pg.c
    M vector/v.colors/local_proto.h
    M vector/v.colors/read_rgb.c
    M vector/v.colors/scan_attr.c
    M vector/v.colors/scan_cats.c
    M vector/v.colors/write_rgb.c
    M vector/v.decimate/copy_tab.c
    M vector/v.decimate/main.c
    M vector/v.distance/distance.c
    M vector/v.distance/local_proto.h
    M vector/v.extract/copy_tab.c
    M vector/v.extract/local_proto.h
    M vector/v.info/local_proto.h
    M vector/v.info/print.c
    M vector/v.out.postgis/local_proto.h
    M vector/v.out.postgis/table.c

  Log Message:
  -----------
  libvector : reading files with 'struct Map_info*' objects is technically not const (#2894)

The qualifier is removed from the API and code using it.

Co-authored-by: Māris Nartišs <maris.gis at gmail.com>


  Commit: d757e423de89711217fbf3cc7b175ea2dbe8a2d7
      https://github.com/OSGeo/grass/commit/d757e423de89711217fbf3cc7b175ea2dbe8a2d7
  Author: Māris Nartišs <maris.gis at gmail.com>
  Date:   2023-11-21 (Tue, 21 Nov 2023)

  Changed paths:
    M display/d.vect/label.c

  Log Message:
  -----------
  d.vect: label vertical alignment workaround (#2857)

Fixes #2854


  Commit: 816c25f62cd6723aa956939b157ac1f3da1c8f44
      https://github.com/OSGeo/grass/commit/816c25f62cd6723aa956939b157ac1f3da1c8f44
  Author: Tomas Zigo <50632337+tmszi at users.noreply.github.com>
  Date:   2023-11-21 (Tue, 21 Nov 2023)

  Changed paths:
    M display/d.vect/d.vect.html
    M python/grass/script/utils.py

  Log Message:
  -----------
  python/grass/script: split the command string using shell-like syntax on the win32 platform same as on POSIX-compliant platforms (#1908)

e.g. run 'd.vect map=census where="cat > 10 AND cat < 20"' with
where parameter from Command Prompt CMD/emulator terminal:

non-POSIX platform

```
>>> import shlex
>>> shlex.split('where="cat > 10 AND cat < 20"', posix=False)
['where="cat', '>', '10', 'AND', 'cat', '<', '20"']
```

POSIX-compliant platform

```
>>> import shlex
>>> shlex.split('where="cat > 10 AND cat < 20"', posix=True)
['where=cat > 10 AND cat < 20']
```

Under OS MS Windows 'd.vect map=census where="cat > 10 AND cat < 20"'
command runned from Command Prompt CMD require use ^ carret symbol for
escaping special characters < > ( ) & | , ; ".

e.g. 'd.vect map=census where="cat ^> 10 AND cat ^< 20"'

---------

Co-authored-by: Anna Petrasova <kratochanna at gmail.com>


  Commit: 49fb2d97e4f1c6c73d1ae75e49720d66b9d092ca
      https://github.com/OSGeo/grass/commit/49fb2d97e4f1c6c73d1ae75e49720d66b9d092ca
  Author: Nicklas Larsson <n_larsson at yahoo.com>
  Date:   2023-11-22 (Wed, 22 Nov 2023)

  Changed paths:
    M .pre-commit-config.yaml

  Log Message:
  -----------
  pre-commit: set min-space to 1 for in-line comments in yaml files (#3254)

Renovate bot commit may contain trailing comments with 1 space from
the content. This is caused by Renovate's use of 'prettier' for formatting, which
has a different default compared to yamllint, and that is not likely to change.
This is completely arbitrary, thus to avoid further linting issues cased by
Renovate we can as well adapt to use 1 min-space from content.

Prepare for 'pre-commit.ci' use 'Skip flake8', as the '.flake8' file is ignored
by pre-commit.ci. For some unknown reason the 'clang-format' of pre-commit.ci
also formats ipynb files (being json files), but local use of pre-commit
does not. Exclude ipynb files from clang-format.


  Commit: 0cc0929930de5d5bc88cc866489e332f009a3ece
      https://github.com/OSGeo/grass/commit/0cc0929930de5d5bc88cc866489e332f009a3ece
  Author: Nicklas Larsson <n_larsson at yahoo.com>
  Date:   2023-11-22 (Wed, 22 Nov 2023)

  Changed paths:
    M .pre-commit-config.yaml
    M Dockerfile
    M contributors.csv
    M display/d.legend.vect/draw.c
    M display/d.vect/d.vect.html
    M display/d.vect/label.c
    M docker/ubuntu/Dockerfile
    M include/grass/defs/vector.h
    M lib/vector/Vlib/area.c
    M lib/vector/Vlib/area_pg.c
    M lib/vector/Vlib/array.c
    M lib/vector/Vlib/box.c
    M lib/vector/Vlib/buffer2.c
    M lib/vector/Vlib/build.c
    M lib/vector/Vlib/build_sfa.c
    M lib/vector/Vlib/cindex.c
    M lib/vector/Vlib/close.c
    M lib/vector/Vlib/constraint.c
    M lib/vector/Vlib/copy.c
    M lib/vector/Vlib/dbcolumns.c
    M lib/vector/Vlib/field.c
    M lib/vector/Vlib/geos_to_wktb.c
    M lib/vector/Vlib/header.c
    M lib/vector/Vlib/header_finfo.c
    M lib/vector/Vlib/hist.c
    M lib/vector/Vlib/init_head.c
    M lib/vector/Vlib/level.c
    M lib/vector/Vlib/level_two.c
    M lib/vector/Vlib/line.c
    M lib/vector/Vlib/local_proto.h
    M lib/vector/Vlib/net_analyze.c
    M lib/vector/Vlib/open.c
    M lib/vector/Vlib/pg_local_proto.h
    M lib/vector/Vlib/poly.c
    M lib/vector/Vlib/read.c
    M lib/vector/Vlib/read_ogr.c
    M lib/vector/Vlib/simple_features.c
    M lib/vector/Vlib/write.c
    M lib/vector/Vlib/write_nat.c
    M lib/vector/Vlib/write_pg.c
    M python/grass/script/utils.py
    M scripts/v.db.join/v.db.join.py
    M utils/mkhtml.py
    M vector/v.clean/main.c
    M vector/v.colors/local_proto.h
    M vector/v.colors/read_rgb.c
    M vector/v.colors/scan_attr.c
    M vector/v.colors/scan_cats.c
    M vector/v.colors/write_rgb.c
    M vector/v.decimate/copy_tab.c
    M vector/v.decimate/main.c
    M vector/v.distance/distance.c
    M vector/v.distance/local_proto.h
    M vector/v.extract/copy_tab.c
    M vector/v.extract/local_proto.h
    M vector/v.info/local_proto.h
    M vector/v.info/print.c
    M vector/v.out.postgis/local_proto.h
    M vector/v.out.postgis/table.c

  Log Message:
  -----------
  Merge branch 'main' into fix_external_warnings


  Commit: 65bdbccdb08156548a6ed7d751db3f9c214f0d17
      https://github.com/OSGeo/grass/commit/65bdbccdb08156548a6ed7d751db3f9c214f0d17
  Author: Nicklas Larsson <n_larsson at yahoo.com>
  Date:   2023-11-22 (Wed, 22 Nov 2023)

  Changed paths:
    M .github/workflows/gcc.yml

  Log Message:
  -----------
  revert unrelated change


Compare: https://github.com/OSGeo/grass/compare/e89b57514070...65bdbccdb081

More information about the grass-commit mailing list