[GRASS5] Changes between 5.0.1 release and current CVS head

[Glynn Clements]

Markus Neteler wrote:

> > > html/index.html
> > > html/searchhtml.html
> > > 	index2.html -> index.html
> > 
> > Don't know.
> 
> Yes (index2.html doesn't exist any more on the web)

If the URLs are meant to refer to the GRASS website, they should be
absolute URLs. Bear in mind that these files are installed into
$GISBASE/documents; relative URLs should only be used when the target
is also in $GISBASE/documents.

I think that I was getting confused with the following (from
html/index.html):

	<a href="../nviz/index.html">nviz visualization tool tutorial</A>

This URL is wrong for a local copy of index.html (".." doesn't make
any sense from the top-level directory); it should be:

	<a href="nviz/index.html">nviz visualization tool tutorial</A>

If the GRASS website is layed out differently, then the file should be
pre-processed for use on the web site.

> > > src.contrib/GMSL/NVIZ2.2/doconfigure
> > > - src.contrib/GMSL/NVIZ2.2/src/query_postgr_dummy.c
> > > - src.contrib/GMSL/NVIZ2.2/src/query_postgr_orig.c
> > > 	Remove query_postgr_{orig,dummy}.c
> > 
> > Don't know.
> > 
> > > src.contrib/GMSL/NVIZ2.2/src/query_postgr.c
> > > 	Remove query_postgr_{orig,dummy}.c
> > > 	???
> > 
> > Don't know.
> 
> AFAIK this simplifies the PG dependency.
> Didn't cause problems here so far.

The doconfigure simplification is good; however, there appear to be
some other changes which I'm unsure about.

> > > src.contrib/GMSL/NVIZ2.2/scripts/fileBrowser.tcl
> > > 	Default to cwd instead of $HOME
> > 
> > No; use built-in "pwd" rather than "exec pwd".
> 
> Should the suggestion be uploaded?

I think so.

> > > src.contrib/GMSL/NVIZ2.2/scripts/panel_kanimator.tcl
> > > src.contrib/GMSL/NVIZ2.2/scripts/panel_main.tcl
> > > src.contrib/GMSL/NVIZ2.2/src/anim_support.c
> > > src.contrib/GMSL/NVIZ2.2/src/change_view.c
> > > src.contrib/GMSL/NVIZ2.2/src/getCat.c
> > > src.contrib/GMSL/NVIZ2.2/src/init_commands.c
> > > src.contrib/GMSL/NVIZ2.2/src/interface.h
> > > src.contrib/GMSL/NVIZ2.2/src/position.c
> > > 	???
> > 
> > Don't know.
> 
> Mostly IRIX fixes from Paul, I think.

I think that most of this (along with the ogsf changes) was a
substantial update from Bob Covill.

> > > src/CMD/generic/gmake.sh
> > > 	Allow C++ files (incomplete)
> > 
> > Don't know.
> 
> Wasn't the logic fixed recently?

It was "fixed" so as to be harmless (the first attempt broke the case
when the .c file was generated, e.g. by lex/yacc). However, it's far
from correct: C++ files should use $(CXX) instead of $(CC), and
$(CXXFLAGS) instead of $(CFLAGS). This would require changes to
several other files (configure[.in], head.in).

See my previous message:

	From: Glynn Clements <glynn.clements at virgin.net>
	Subject: Re: [GRASS5] C++ compilation
	Date: Thu, 23 Jan 2003 21:43:40 +0000
	Message-ID: <15920.25100.848724.42087 at cerise.nosuchdomain.co.uk>

> > > src/general/g.region/cmd/printwindow.c
> > > src/mapdev/v.in.gshhs/main.c
> > > src/misc/m.ll2db/main.c
> > > src/raster/r.sun/main.c
> > > src/raster/r.sunmask/g_solposition.c
> > > src/sites/s.datum.shift/main.c
> > > 	Don't call pj_zero_proj()
> > 
> > Don't know (related to generalised datum transformations?)
> 
> related to generalised datum transformations.
> What do you think, Paul?

Paul says not yet, so no.

> > > src/general/init/grass.src
> > > 	Trap signals
> > 
> > Don't know.
> 
> I have added this to avoid that GRASS continues when the user
> hits CTRL-C while defining a new location. I never liked that
> GRASS continues and generates a broken new location, when
> I try to stop the create-location procedure.
> 
> So, IMHO yes.

Doesn't this belong in Init.sh, then? That's where the code in
question is.

> > > src/imagery/i.ortho.photo/photo.rectify/write.c
> > > 	Error messages
> > 
> > No.
> 
> 2002-09-24 14:57  markus
>  
>         * src/imagery/i.ortho.photo/photo.rectify/write.c: changed write
>         error to strerror(errno) as suggested by Glynn
> 
> Is this dangerous? Of yes, it should be also reverted in HEAD.

Two issues: Regarding the first message, I don't know how portable
strerror() is; older BSDs don't have it.

Regarding the second, the message is over 80 characters; also, you
could reasonably argue for adding the same message to every module
which writes files (i.e. most modules), which is really an argument
for putting it lower down. Also, permissions definitely aren't an
issue, as they are checked upon open and not upon write.

> > > 	G__getsome
> > > 	G_number_of_tokens
> > 
> > Don't know.
> 
> G_number_of_tokens is needed by g.mapsets add= and is just a shift
> of a function into the library.
> G_number_of_tokens(): Yes.

OK.

> > > src/libes/gis/ellipse.table
> > > 	Enable "sphere"
> > 
> > Yes.
> 
> Note that "sphere" doesn't seem to work (will have to retry).

Please do.

> > > src/libes/imagery/vask_group.c
> > > 	Increase field length 20 -> 30
> > 
> > Don't know.
> 
> Allow for longer group names. No problems so far.

OK, then yes.

-- 
Glynn Clements <glynn.clements at virgin.net>