[GRASS5] r.thin lseek problems for large files

Brad Douglas rez at touchofmadness.com
Wed Sep 7 22:16:14 EDT 2005


On Wed, 2005-09-07 at 19:31 -0400, Andrew Danner wrote:
> r.thin is segfaulting on large files because of a bad type in a couple
> of lseeks.
> 
>  grass61.cvs/raster/r.thin/io.c
>  
>  lines 71 and 77 read
> 
>  lseek(file,(long) row * buf_len,0);
> 
>  but should be
> 
>  lseek(file, ((off_t)row) * buf_len,0);
> 
> can some make the change in CVS?

Done, but I really don't see it helping.

What happens if a map exceeds a number of rows greater than the max of
type int?

Does it exit gracefully, or is it a disaster waiting to happen?
lib/rowio is not designed to handle very large rows, AFAICT.


PS -
Take my words lightly.  My ammonia levels are in the triple digits of
late and I am not thinking clearly.


-- 
Brad Douglas <rez at touchofmadness.com>




More information about the grass-dev mailing list