[GRASS-dev] [bug #5094] (grass) r.support from the GUI is broken

[Glynn Clements]

Request Tracker wrote:

> this bug's URL: http://intevation.de/rt/webrt?serial_num=5094

> Subject: r.support from the GUI is broken

> The grass-run.sh script pauses if the module exited with an error. Maybe
> grass-xterm-wrapper should too?  (this doesn't seem to help with the r.support
> problem though)

There is no point doing it in grass-xterm-wrapper, for several
reasons:

1. grass-xterm-wrapper's stdout will typically be the pipe set up by
Tcl's "exec" or "open |..." commands, its stderr will either refer to
the same pipe or be redirected to /dev/null, and it won't have a
stdin.

2. Once $GRASS_XTERM completes, the terminal window has gone; there
doesn't seem to be much point pausing here.

3. xterm's exit code doesn't reflect the exit code of the program
which is run via -e, so grass-xterm-wrapper doesn't know whether the
command succeeded or failed.

4. Anything which d.m/gis.m run via an xterm needs to use grass-run.sh
(otherwise the program may be unable to find the GRASS shared
libraries), which already includes the pause.

-- 
Glynn Clements <glynn at gclements.plus.com>