[GRASS-dev] ps.map fprintf -> G_

Moritz Lennert mlennert at club.worldonline.be
Mon Jan 8 07:29:42 EST 2007


On 08/01/07 08:26, Martin Landa wrote:
> Hi,
> 
> 2007/1/7, Jachym Cepicky <jachym.cepicky at centrum.cz>:
> 
>> On this place, I would vote for just a warning, so
>>
>> +      /* Please, remove before GRASS 7 released */
>>   if (KEY("verbose"))
>>   {
>> -      if (sscanf(data, "%d", &verbose) != 1) verbose = 2;
>> +      G_warning(_("verbose instruction was removed. Please use 
>> --verbose instead"));
>>       continue;
>>   }
>>
>> Otherwise, tha patch looks good to me
> 
> done & committed to CVS.

Just in case you missed this (from bottom of 
http://grass.itc.it/pipermail/grass5/2007-January/028390.html):

Hamish wrote:
> pps- ps.map verbose command IS used in the wild, so don't break scripts by
> removing it altogether. Note it is multi-leveled, so it should keep at least 3
> levels of verbosity triggered by --q,<>,--v, i.e. standard messages should use
> G_message(), but very verbose messages should hide G_message() in if(verbose >=
> G_max_verbose()) or whatever. I am in favour of separating mapping commands
> from program control, and letting the parser deal with the latter.


Moritz




More information about the grass-dev mailing list