[GRASS-dev] i.image.mosaic/i.landsat.rgb

[Glynn Clements]

Daniel Calvelo wrote:

> > i.image.mosaic errors out with the following:
> >
> > GRASS 6.3.cvs (black_rock):~ > i.image.mosaic image1=etm1.1
> > image2=etm2.1 image3=etm3.1
> >
> > ATTENTION: Do not forget to set region properly to cover all images!
> >
> > i.image.mosaic: line 85: [: argument expected
> > i.image.mosaic: line 106: [: argument expected
> > i.image.mosaic: line 119: [: too many arguments
>
> Try this version.

Looks good to me.

FWIW, looking for unquoted variable substitutions with:

	cd $GISBASE/scripts
	grep -n '[^"]\$' *

suggests that there may be quite a lot of these issues remaining.

Many of those are false positives, e.g. because the variable
substitution appears later in a quoted string rather than immediately
after the opening quote.

Also, some don't actually matter because the variable will always have
a value which is a single word to the shell, but it's always a good
idea to quote every variable substitution unless you actually *need*
the value to be subjected to further parsing.

Unquoted variable substitutions should be the exception rather than
the norm.

-- 
Glynn Clements <glynn at gclements.plus.com>