[GRASS-dev] Re: [GRASS GIS] #44: ./configure: cosmetics

GRASS GIS trac at osgeo.org
Sun Feb 10 13:24:20 EST 2008


#44: ./configure: cosmetics
----------------------+-----------------------------------------------------
  Reporter:  hamish   |       Owner:  grass-dev at lists.osgeo.org
      Type:  task     |      Status:  new                      
  Priority:  trivial  |   Milestone:  6.4.0                    
 Component:  default  |     Version:  svn-trunk                
Resolution:           |    Keywords:                           
----------------------+-----------------------------------------------------
Comment (by hamish):

 Markus:
 > Just run autoconf-2.13. I do it like this:
 {{{
 $ patch -p0 < /tmp/config.in_reorder.diff
 ...
 $ autoconf-2.13
 }}}

 > Indent-fixed patch uploaded.

 Ok, that's both very easy. Two problems-

 - I notice that after running autoconf2.13 there is an extra reference to
 *.$ac_ext,
 ??? should I have run 'make distclean' before autoconf2.13 or do our
 autoconf's differ?

 {{{
 --- configure   (revision 30045)
 +++ configure   (working copy)
 @@ -1014,7 +1014,7 @@
    if { (eval echo configure:1015: \"$ac_link\") 1>&5; (eval $ac_link)
 2>&5; }; then
      for file in conftest.*; do
        case $file in
 -      *.c | *.o | *.obj) ;;
 +      *.$ac_ext | *.c | *.o | *.obj) ;;
        *) ac_cv_exeext=`echo $file | sed -e s/conftest//` ;;
        esac
      done
 }}}


 - top section indenting now lines up but "yes|no" part for MacOSX App
 doesn't.

 {{{
   Building shared libraries:   yes
   64bit support:               no
   OpenGL platform:             X11
   MacOSX application:         no

   NVIZ:                       yes

   BLAS support:               no
   C++ support:                yes
   Cairo support:              yes
   DWG support:                no
 }}}



 Martin:
 > Q: Should I wait with changes in python/wxwidgets or just to commit to
 SVN now?
 > (#38)

 because it's so trivial I don't see a reason not to combine them, but on
 the other hand this patch does not cause more than a few lines of change
 in configure (typically autoconf causes a huge patch) so it wouldn't be
 inefficient to do it by itself. shrug.

 Outstanding question:
 > > Q: move LFS and/or NLS to the top section as well?


 Hamish

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/44#comment:6>
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/


More information about the grass-dev mailing list