[GRASS-dev] Raster lib in GRASS7

[Glynn Clements]

Martin Landa wrote:

> >> >> I started a wiki page dedicated to the raster lib in GRASS7. The page
> >> >> currently contains initial list of functions which should be moved
> >> >> from libGIS.
> >> >>
> >> >> http://trac.osgeo.org/grass/wiki/Grass7RasterLib
> >> >>
> >> >> Logically raster lib should be placed in 'lib/raster'. Currently there
> >> >> are R_() functions. Where should be moved content of 'lib/raster'?
> >> >
> >> > I suppose that it can be merged into lib/display, as that's mostly
> >> > what uses it.
> >>
> >> I don't know display library so well, but I would guess that the
> >> merging cannot be done automatically (just rename R_ to D_). I have
> >> created for this purpose wiki page, feel free to updated it
> >
> > I don't suggest renaming the functions, just moving raster.c to
> > lib/display.
> 
> OK, but shouldn't be better to use the same prefix for all fns from
> the display library?

Many of the R_* functions have matching D_* functions with the same
name (modulo the prefix) and "matching" functionality.

OTOH, many of the R_* functions no longer need to be externally
visible. AFAICT, only the following are used other than by
lib/display:

R_close_driver
R_encoding
R_erase
R_font
R_font_info
R_font_list
R_get_window
R_open_driver
R_text
R_text_rotation
R_text_size

Everything else can be made "static" (or eliminated; most of them are
just aliases for the corresponding COM_* functions in lib/driver).

AFAICT, all of the above except for R_erase() can be changed to D_*;
none of the other R_* functions which have matching D_* versions are
used externally.

-- 
Glynn Clements <glynn at gclements.plus.com>