[GRASS-dev] Re: [GRASS GIS] #928: 6.4: wx addon scripts never return

[GRASS GIS]

#928: 6.4: wx addon scripts never return
-----------------------+----------------------------------------------------
  Reporter:  hamish    |       Owner:  grass-dev at lists.osgeo.org
      Type:  defect    |      Status:  new                      
  Priority:  critical  |   Milestone:  6.4.0                    
 Component:  default   |     Version:  svn-releasebranch64      
Resolution:            |    Keywords:  addons                   
  Platform:  Linux     |         Cpu:  x86-64                   
-----------------------+----------------------------------------------------
Changes (by hamish):

  * priority:  blocker => critical
  * summary:  6.4: all shell scripts broken from command line + tcl; wx
              addon scripts broken => 6.4: wx addon scripts
              never return

Comment:

 Replying to [comment:2 glynn]:
 > But that's not the problem here. The problem is r40716, which
 > back-ports r40713. This was fixed in 6.5 with r40724, which also
 > needs to be back-ported.

 ok, done. "`sh: $GRASS_WISH: command not found`" is fixed.


 > In 6.x, it isn't used at all; with popen() being eliminated,

 (I guess you mean G_popen() there)

 > lib/gis/popen.c can (and should) be removed.

 I am not very happy about non-necessary API changes / dropping of long
 standing functions in the stable branch as we don't know what 3rd party
 modules are relying on. Adding `G_warning("oi! stop using this function!
 use bar() instead!")` is more productive IMO.
 In trunk anything goes, but..

 ----

 Still broken:
  * add-on scripts run through the wx module GUI in 6.4 finish but never
 return. when you hit the [Stop] button you get this error in the term:
 `AttributeError: 'CmdThread' object has no attribute 'requestCmd'`


 Outstanding wish:
  * Tcl/Tk gis.m output window: can we label that command prompt frame
 somehow? it is impossible to guess that typing something there does
 anything. perhaps sacrifice one of the 3 input lines for a "Command:"
 label?


 thanks,
 Hamish

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/928#comment:3>
GRASS GIS <http://grass.osgeo.org>