[GRASS-dev] Re: [GRASS GIS] #800: r.random and r.reclass - buffer overflow on long mapset/map names

GRASS GIS trac at osgeo.org
Wed Jun 30 18:33:32 EDT 2010


#800: r.random and r.reclass - buffer overflow on long mapset/map names
--------------------------+-------------------------------------------------
 Reporter:  ferrouswheel  |       Owner:  grass-dev@…              
     Type:  defect        |      Status:  new                      
 Priority:  normal        |   Milestone:  6.5.0                    
Component:  Raster        |     Version:  svn-develbranch6         
 Keywords:                |    Platform:  All                      
      Cpu:  All           |  
--------------------------+-------------------------------------------------

Comment(by neteler):

 Replying to [comment:2 glynn]:
 > Replying to [ticket:800 ferrouswheel]:
 > > In r.random/support.c there are sprintf calls which cause buffer
 overflow errors when the map names and mapsets are too long. I've attached
 a patch to replace with snprintf.
 >
 > snprintf() isn't in C89; if you want to use it, you need to add a
 configure check, and provide an alternate in case it isn't available.

 We do have G_snprintf() in lib/gis/snprintf.c which is a "private"
 implementation.
 Should that be used instead?

 Markus

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/800#comment:6>
GRASS GIS <http://grass.osgeo.org>



More information about the grass-dev mailing list