[GRASS-dev] i.topo.corr ported to GRASS 7

[Markus Neteler]

On Fri, Aug 12, 2011 at 9:29 AM, Glynn Clements
<glynn at gclements.plus.com> wrote:
>
> Markus Neteler wrote:
>
>> This problem remains:
>>
>> i.topo.corr input=myplane_pyr_band output=myplane_pyr_topocorr_percent
>> basemap=myplane_pyr_illumination zenith=45.652668 method=percent
>> Band myplane_pyr_band:
>> ERROR: Input window changed while maps are open for read
>
> You fixed the first occurrence of G_get_set_window() in
> illumination.c, in eval_c_cosi(), but missed the others, in
> eval_f_cosi() and eval_d_cosi().

Fixed.

> BTW, does it really need three separate versions of what appears to be
> essentially the same function?

I guess not (I am not the original author). Rather likely it can be reduced
to one routine. I suppose that the DOUBLE function should survive and
the result be casted appropriately.

Markus