[GRASS-dev] r45050: v.info: -r/-m/-t -> shell param; GEM; parser.c

[Martin Landa]

Hi,

2011/1/18 Hamish <hamish_b at yahoo.com>:

[...]

> Index: grass/branches/releasebranch_6_4/lib/gis/parser.c
> ===================================================================
> --- a/grass/branches/releasebranch_6_4/lib/gis/parser.c
> +++ b/grass/branches/releasebranch_6_4/lib/gis/parser.c
> @@ -632,16 +632,16 @@
>         Opt->key = "input";
>         Opt->type = TYPE_STRING;
> -        Opt->key_desc = "name";
> +        Opt->key_desc = "path";
>         Opt->required = YES;
>         Opt->gisprompt = "old_file,file,input";
> -        Opt->description = _("Name of input file");
> +        Opt->description = _("Path to input file");
>         break;
>     case G_OPT_F_OUTPUT:
>         Opt->key = "output";
>         Opt->type = TYPE_STRING;
> -        Opt->key_desc = "name";
> +        Opt->key_desc = "path";
>         Opt->required = YES;
>         Opt->gisprompt = "new_file,file,output";
> -        Opt->description = _("Name for output file");
> +        Opt->description = _("Path for output file");
>         break;
>     case G_OPT_F_SEP:
>
> Hamish:
>> > and fwiw this one I think makes things more confusing,
>> > as it implies `dirname` (vs `basename`), when the correct
>> > usage is like [/path/to/]filename.ext.
> Martin:
>> Sorry I don't understand, this parameter takes path to the
>> file (relative or absolute)...
>
> it takes both the path and the file name. the path is optional
> while the file name is not. The change makes it seem like the
> path is required but the filename is optional. in absence of
> experience, many new users will take these words literally and
> become very confused.
>
> Partly I complain because we have been very loose with "bug fixes
> only in the 6.4 branch"; especially parser.c and gisdefs.h need a
> very good reason to touch at this point. any change to them is
> dangerous.

filename can be seen as a relative path in this case. Anyway you can
be right that `path` can be confusing for the user. No problem for me
to revert this change.

Martin

-- 
Martin Landa <landa.martin gmail.com> * http://geo.fsv.cvut.cz/~landa